can you give feedabck to alain on preference cleaning

http://code.google.com/p/pharo/issues/detail?id=810
Especially for the annotation panes in the old browser.

Stef

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

annotation pane is very useful thing. This is first thing i turning
on, when start using new image.

2009/5/21 Stéphane Ducasse <[hidden email]>:


--
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

fun this is the first thing I remove.

Stef

On May 21, 2009, at 8:55 PM, Igor Stasenko wrote:


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

2009/5/22 Stéphane Ducasse <[hidden email]>:
> fun this is the first thing I remove.
the most annoyng for me, that when i use "show all categories" in
method's categories then for currently selected method i can't see to
which category it belongs to.
Not saying that method's change record information sometimes is useful as well.



--
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Igor Stasenko a écrit :
> annotation pane is very useful thing. This is first thing i turning
> on, when start using new image.
>  
Hi Igor,

how do you makes it work on old  browser. It is never updated.
However, It is well implemented by OB, and  works very well with it.
So the question is can I remove it from old browser (from the core).
We can keep OB implementation and introduce an OB specific setting for it.

Regarding the old browser, It is very badly implemented and introduces
very dirty dependences.
See pieces of code below.
We hare removing etoy or bookmorph for the same reasons.

CodeHolder>>refreshAnnotation
"If the receiver has an annotation pane that does not
        bear unaccepted edits, refresh it"
        (aPane := self dependents
                                detect: [:m | (m inheritsFromAnyIn: #('PluggableTextView'
'PluggableTextMorph' ))
                                                and: [m getTextSelector == #annotation]]
                                ifNone: [])
                ifNotNil: [:aPane | aPane hasUnacceptedEdits
                                ifFalse: [aPane update: #annotation]]

other "cool" pieces of code:
PluggableTextMorph>>accept
 ....
        ok := self acceptTextInModel.
        ok == true
                ifTrue: [self setText: self getText.
                        self hasUnacceptedEdits: false.
                        (model dependents
                                detect: [:dep | (dep isKindOf: PluggableTextMorph)
                                                and: [dep getTextSelector == #annotation]]
                                ifNone: [])
                                ifNotNilDo: [:aPane | model changed: #annotation]].
 ...
PluggableTextMorph>>cancel
        self setText: self getText.
        self setSelection: self getSelection.
        getTextSelector == #annotation
                ifFalse: [(aPane := model dependents
                                                detect: [:dep | (dep isKindOf: PluggableTextMorph)
                                                                and: [dep getTextSelector == #annotation]]
                                                ifNone: [])


                                ifNotNil: [:aPane | model changed: #annotation]]

Cheers
Alain

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

I also never use the annotations.

On May 22, 2009, at 03:05 , Igor Stasenko wrote:

> 2009/5/22 Stéphane Ducasse <[hidden email]>:
>> fun this is the first thing I remove.
> the most annoyng for me, that when i use "show all categories" in
> method's categories then for currently selected method i can't see to
> which category it belongs to.

If I need to know this, I do a "Command-shift-c"

> Not saying that method's change record information sometimes is  
> useful as well.

For this I browse the versions with "Command-v"

Adrian


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

2009/5/22 Alain Plantec <[hidden email]>: I'm using OB in Pharo, so removing this from old browsers doesn't
hurts much, i guess :)



--
Best regards,
Igor Stasenko AKA sig.
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

I like your proposal.

Stef

On May 22, 2009, at 9:59 AM, Adrian Lienhard wrote:


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Igor Stasenko a écrit : ok, OB will not be touched. Thank for your feedback Igor.
Cheers
Alain


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project