class API question

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

class API question

Stéphane Ducasse
We are not consistent:

        do we want
                renameInstVar:to:
        or
                removeInstVarName:
                        I prefer that.

We have addInstVarName:
        -> should be addInstVarNamed: from my taste


Now we want to have first class instance variable in the near future so I would like to have

        addInstVar: aVariable
        addInstVarNamed: aString

What do you think?

Stef



_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: class API question

Marcus Denker-4

On Aug 27, 2010, at 11:02 AM, Stéphane Ducasse wrote:

> We are not consistent:
>
> do we want
> renameInstVar:to:
> or
> removeInstVarName:
> I prefer that.
>
> We have addInstVarName:
> -> should be addInstVarNamed: from my taste
>
>
> Now we want to have first class instance variable in the near future so I would like to have
>
> addInstVar: aVariable
> addInstVarNamed: aString
>
> What do you think?
>

Yes!


--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: class API question

Stéphane Ducasse
done :)
I could not let that like that.

Stef

On Aug 27, 2010, at 11:11 AM, Marcus Denker wrote:

>
> On Aug 27, 2010, at 11:02 AM, Stéphane Ducasse wrote:
>
>> We are not consistent:
>>
>> do we want
>> renameInstVar:to:
>> or
>> removeInstVarName:
>> I prefer that.
>>
>> We have addInstVarName:
>> -> should be addInstVarNamed: from my taste
>>
>>
>> Now we want to have first class instance variable in the near future so I would like to have
>>
>> addInstVar: aVariable
>> addInstVarNamed: aString
>>
>> What do you think?
>>
>
> Yes!
>
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: class API question

Lukas Renggli
I think it would be beneficial to adapt the protocol of the refactoring browser.

It especially spells out all the names:

    #addInstanceVariable:
    #allInstanceVariableNames
    #instanceVariableNames

Lukas

On 27 August 2010 11:50, Stéphane Ducasse <[hidden email]> wrote:

> done :)
> I could not let that like that.
>
> Stef
>
> On Aug 27, 2010, at 11:11 AM, Marcus Denker wrote:
>
>>
>> On Aug 27, 2010, at 11:02 AM, Stéphane Ducasse wrote:
>>
>>> We are not consistent:
>>>
>>>      do we want
>>>              renameInstVar:to:
>>>      or
>>>              removeInstVarName:
>>>                      I prefer that.
>>>
>>> We have addInstVarName:
>>>      -> should be addInstVarNamed: from my taste
>>>
>>>
>>> Now we want to have first class instance variable in the near future so I would like to have
>>>
>>>      addInstVar: aVariable
>>>      addInstVarNamed: aString
>>>
>>> What do you think?
>>>
>>
>> Yes!
>>
>>
>> --
>> Marcus Denker  -- http://www.marcusdenker.de
>> INRIA Lille -- Nord Europe. Team RMoD.
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: class API question

Jorge Ressia
Yep,

It would be much better to sell out the names.


On Fri, Aug 27, 2010 at 11:53 AM, Lukas Renggli <[hidden email]> wrote:

> I think it would be beneficial to adapt the protocol of the refactoring browser.
>
> It especially spells out all the names:
>
>    #addInstanceVariable:
>    #allInstanceVariableNames
>    #instanceVariableNames
>
> Lukas
>
> On 27 August 2010 11:50, Stéphane Ducasse <[hidden email]> wrote:
>> done :)
>> I could not let that like that.
>>
>> Stef
>>
>> On Aug 27, 2010, at 11:11 AM, Marcus Denker wrote:
>>
>>>
>>> On Aug 27, 2010, at 11:02 AM, Stéphane Ducasse wrote:
>>>
>>>> We are not consistent:
>>>>
>>>>      do we want
>>>>              renameInstVar:to:
>>>>      or
>>>>              removeInstVarName:
>>>>                      I prefer that.
>>>>
>>>> We have addInstVarName:
>>>>      -> should be addInstVarNamed: from my taste
>>>>
>>>>
>>>> Now we want to have first class instance variable in the near future so I would like to have
>>>>
>>>>      addInstVar: aVariable
>>>>      addInstVarNamed: aString
>>>>
>>>> What do you think?
>>>>
>>>
>>> Yes!
>>>
>>>
>>> --
>>> Marcus Denker  -- http://www.marcusdenker.de
>>> INRIA Lille -- Nord Europe. Team RMoD.
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>
> --
> Lukas Renggli
> www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Jorge Ressia
www.jorgeressia.com

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: class API question

Stéphane Ducasse
In reply to this post by Lukas Renggli
> I think it would be beneficial to adapt the protocol of the refactoring browser.
>
> It especially spells out all the names:
>
>    #addInstanceVariable:
>    #allInstanceVariableNames
>    #instanceVariableNames
>
> Lukas

I thought about it too but since we will add first class instances variables then I preferred to use named: for now
and like that we can have both interfaces in the future for compatibility.

Stef
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project