but the problem is now I need a second call to this url :
https://www.rijksmuseum.nl/api/nl/collection/<<objectNumber>/tiles?key=[API_KEY]&format=json
and then need a new imageUrl out of it.
and then have one object with objectNumber and the new url
Also I have to make a call to this url : https://www.rijksmuseum.nl/api/nl/collection/<<<objectNumber>>?key=[API_KEY]&format=json
and also get some data out of it so that a painting will be one object with the objectNumber, new imageurl
and some data out of the last call
Do I need to make some more object to get this working or is there a way I can change the code I use now
to get things working
Regards,
Roelof
but the problem is now I need a second call to this url :
https://www.rijksmuseum.nl/api/nl/collection/<<objectNumber>/tiles?key=[API_KEY]&format=json
and then need a new imageUrl out of it.
and then have one object with objectNumber and the new url
Also I have to make a call to this url : https://www.rijksmuseum.nl/api/nl/collection/<<<objectNumber>>?key=[API_KEY]&format=json
and also get some data out of it so that a painting will be one object with the objectNumber, new imageurl
and some data out of the last call
Do I need to make some more object to get this working or is there a way I can change the code I use now
to get things working
Regards,
Roelof
Its hard to tell from your description.
You say "the problem is now I need a second call" but you've not shown the code that does the calling,
and you've not shown the first call, or where you are looping through multiple paintings (I'm guessing that is the requirement)
You say "Do I need to make some more object", but are you referring to more Paintings objects or more Painting objects?
So speaking only very generally, this might be implemented in two ways...
A1. Request the json of paintings into a Paintings object
A2 Loop that json requesting each individual painting json to fully initialized Painting object
or...
B1. Request the json of paintings into a Paintings object
B2. Loop that json create empty Painting objects
B3. Iterate those Painting objects with each one requesting its own json from the server, and can do multiple requests if necessary
And btw, very very generally, if you see even a hint of one way to do it - do it that way first and see what insights arise from that to improve it.
Particularly when exploring a new domain like an unfamiliar API, the usual approach is...
1. Make it work
2. Make it right
3. Make it fast
Use whatever hackery you need to get step 1 done before moving to step 2, which you are inquiring about. And often you don't even need step 3.
but the problem is now I need a second call to this url
:
https://www.rijksmuseum.nl/api/nl/collection/<<objectNumber>/tiles?key=[API_KEY]&format=json
and then need a new imageUrl out of it.
and then have one object with objectNumber and the new url
Also I have to make a call to this url : https://www.rijksmuseum.nl/api/nl/collection/<<<objectNumber>>?key=[API_KEY]&format=json
and also get some data out of it so that a painting will be one object with the objectNumber, new imageurl
and some data out of the last call
Do I need to make some more object to get this working or is there a way I can change the code I use now
to get things working
Regards,
Roelof
Its hard to tell from your description.
You say "the problem is now I need a second call" but
you've not shown the code that does the calling,
and you've not shown the first call, or where you are
looping through multiple paintings (I'm guessing that is
the requirement)
You say "Do I need to make some more object", but are
you referring to more Paintings objects or more Painting
objects?
So speaking only very generally, this might be
implemented in two ways...
A1. Request the json of paintings into a Paintings
object
A2 Loop that json requesting each individual painting
json to fully initialized Painting object
or...
B1. Request the json of paintings into a Paintings
object
B2. Loop that json create empty Painting objects
B3. Iterate those Painting objects with each one
requesting its own json from the server, and can do
multiple requests if necessary
And btw, very very generally, if you see even a hint of
one way to do it - do it that way first and see what
insights arise from that to improve it.
Particularly when exploring a new domain like an
unfamiliar API, the usual approach is...
1. Make it work
2. Make it right
3. Make it fast
Use whatever hackery you need to get step 1 done
before moving to step 2, which you are inquiring about.
And often you don't even need step 3.
cheers -ben
Hello Ben
Sorry for the general thing. Im thinking how I can solve things
before begin with coding
but as I try to say I do not see how and where to place the second
call and process the json
as far as I know I cannot make a second fromJSON in a paintings
object
if you need I can make a fileout of place the image so far on for
example dropbox
but the problem is now I need a second call to this
url :
https://www.rijksmuseum.nl/api/nl/collection/<<objectNumber>/tiles?key=[API_KEY]&format=json
and then need a new imageUrl out of it.
and then have one object with objectNumber and the new url
Also I have to make a call to this url : https://www.rijksmuseum.nl/api/nl/collection/<<<objectNumber>>?key=[API_KEY]&format=json
and also get some data out of it so that a painting will be one object with the objectNumber, new imageurl
and some data out of the last call
Do I need to make some more object to get this working or is there a way I can change the code I use now
to get things working
Regards,
Roelof
Its hard to tell from your description.
You say "the problem is now I need a second call" but
you've not shown the code that does the calling,
and you've not shown the first call, or where you are
looping through multiple paintings (I'm guessing that is
the requirement)
You say "Do I need to make some more object", but are
you referring to more Paintings objects or more Painting
objects?
So speaking only very generally, this might be
implemented in two ways...
A1. Request the json of paintings into a Paintings
object
A2 Loop that json requesting each individual painting
json to fully initialized Painting object
or...
B1. Request the json of paintings into a Paintings
object
B2. Loop that json create empty Painting objects
B3. Iterate those Painting objects with each one
requesting its own json from the server, and can do
multiple requests if necessary
And btw, very very generally, if you see even a hint
of one way to do it - do it that way first and see what
insights arise from that to improve it.
Particularly when exploring a new domain like an
unfamiliar API, the usual approach is...
1. Make it work
2. Make it right
3. Make it fast
Use whatever hackery you need to get step 1 done
before moving to step 2, which you are inquiring
about. And often you don't even need step 3.
cheers -ben
Hello Ben
Sorry for the general thing. Im thinking how I can solve things
before begin with coding
but as I try to say I do not see how and where to place the second
call and process the json
as far as I know I cannot make a second fromJSON in a paintings
object
if you need I can make a fileout of place the image so far on for
example dropbox
and you get to see the painting shown in the Inspector.
Now if I understand your question... "Do I need to make some more object to get this working..."
I'd say... No. You only want one object for each painting. Once you have a painting object, it should handle all getting all further data it needs for itself.
You don't want duplicate objects each having half of the data.
can I for example name the function fromJson2 or
fromJSONFromLink2 ?
By naming convention #fromJson: implies it sits on the class side.
To get further data for an existing object you want an instance-side method, maybe named #getLink2Json.
and you get to see
the painting shown in
the Inspector.
Now if I understand
your question... "Do I
need to make some more
object to get this
working..."
I'd say... No. You
only want one object
for each
painting. Once you
have a painting
object, it should
handle all getting all
further data it needs
for itself.
You don't want
duplicate objects each
having half of the
data.
can
I for example name
the function
fromJson2 or
fromJSONFromLink2
?
By naming
convention #fromJson:
implies it sits on the
class side.
To get further data
for an existing
object you want an
instance-side method,
maybe named
#getLink2Json.
HTH,
cheers -ben
oke
numbers schould be the objectNumbers because for the rest I need
them
I use a instance variable called painting to hold the data.
so I can change the call to get data for the painting to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json at: #objectNumber).
^ instance
so numbers should be a collection of 10 ObjectNumbers
so I should use a loop to make a call to the second api call
getImages
| json numbers |
json := NeoJSONReader
fromString:
(ZnEasy
get:
'https://www.rijksmuseum.nl/api/nl/collection?key=14OGzuak&format=json&type=schilderij&toppieces=True')
contents.
numbers painting := self class fromJSON: json
numbers do: [each | json := call to the second url.here I
used each
imageData = self class
getLink2Json
json2 := call to the
3th url
otherData := self
class getLink3Json
Then I can I hope on every json method fill in the data I need
and you get to see
the painting shown in
the Inspector.
Now if I understand
your question... "Do I
need to make some more
object to get this
working..."
I'd say... No. You
only want one object
for each
painting. Once you
have a painting
object, it should
handle all getting all
further data it needs
for itself.
You don't want
duplicate objects each
having half of the
data.
can
I for example name
the function
fromJson2 or
fromJSONFromLink2
?
By naming
convention #fromJson:
implies it sits on the
class side.
To get further data
for an existing
object you want an
instance-side method,
maybe named
#getLink2Json.
HTH,
cheers -ben
oke
numbers should be the objectNumbers because for the rest I need
them
I use a instance variable called painting to hold the data.
so I can change the call to get data for the painting to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json at: #objectNumber).
^ instance
so numbers should be a collection of 10 ObjectNumbers
I'm presuming that 10 objectNumbers relate to 10 different paintings,
in which case, No, you should never need to deal with a collection of 10 objectNumbers.
What you should have is a collection of painting-objects which know their own objectNumber
and then iterate that collection sending each painting-object the message "getLink2Json".
so I should use a loop to make a call to the second api call
In Pharo OO approach, you don't "loop" on the "calls",
you "iterate" on the "objects" asking them to use their own data to do the stuff they know how to do.
i.e. Let each object take care of itself.
Which class is getImages defined on? That is really important to understand your proposed solution.
I'm just presuming its defined on the class side of Paintings since your are referring to the same URL as before.
and you
get to see the
painting shown
in the
Inspector.
Now if I
understand
your
question...
"Do I need to
make some more
object to get
this
working..."
I'd
say... No. You
only want one
object for
each
painting. Once
you have a
painting
object, it
should handle
all getting
all further
data it needs
for itself.
You don't
want duplicate
objects each
having half of
the data.
can
I for example
name the
function
fromJson2 or
fromJSONFromLink2
?
By naming
convention
#fromJson:
implies it
sits on the
class side.
To get
further data
for an
existing
object you
want an
instance-side
method, maybe
named
#getLink2Json.
HTH,
cheers
-ben
oke
numbers should be the objectNumbers because for the
rest I need them
I use a instance variable called painting to hold the
data.
so I can change the call to get data for the painting
to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json at:
#objectNumber).
^ instance
so numbers should be a collection of 10
ObjectNumbers
I'm presuming that 10 objectNumbers relate to 10
different paintings,
in which case, No, you should never need to deal with
a collection of 10 objectNumbers.
What you should have is a collection of
painting-objects which know their own objectNumber
and then iterate that collection sending each
painting-object the message "getLink2Json".
so I should use a loop to make a call to the
second api call
In Pharo OO approach, you don't "loop" on the
"calls",
you "iterate" on the "objects" asking them to use
their own data to do the stuff they know how to do.
i.e. Let each object take care of itself.
Which class is getImages defined on? That is really
important to understand your proposed solution.
I'm just presuming its defined on the class side of
Paintings since your are referring to the same URL as
before.
{"elapsedMilliseconds":27,"artObject":{"links":{"search":"https://www.rijksmuseum.nl/api/nl/collection"},"id":"nl-SK-C-5","priref":"5216","objectNumber":"SK-C-5","language":"nl","title":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’","tags":[{"userId":3530,"name":"margaret barrett my first collection","lang":"en","objectNumber":"SK-C-5"},// more results...],"copyrightHolder":null,"webImage":{"guid":"92253da1-794d-49f4-9e3c-e4c160715f53","offsetPercentageX":50,"offsetPercentageY":100,"width":2500,"height":2034,"url":"http://lh6.ggpht.com/wwx2vAS9DzFmmyeZefPjMtmCNOdjD80gvkXJcylloy40SiZOhdLHVddEZLBHtymHu53TcvqJLYZfZF7M-uvoMmG_wSI=s0"},"colors":["#261808",// more results...],"colorsWithNormalization":[{"originalHex":"#261808","normalizedHex":"#000000"},// more results...],"normalizedColors":["#000000",// more results...],"normalized32Colors":["#000000",// more results...],"titles":["Officieren en andere schutters van wijk II in Amsterdam onder leiding van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de ‘Nachtwacht’","Het korporaalschap van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de 'Nachtwacht'"],"description":"Het korporaalschap van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de 'Nachtwacht'. Schutters van de kloveniersdoelen uit een poort naar buiten tredend. Op een schild aangebracht naast de poort staan de namen van de afgebeelde personen: Frans Banninck Cocq, heer van purmerlant en Ilpendam, Capiteijn Willem van Ruijtenburch van Vlaerdingen, heer van Vlaerdingen, Lu[ij]tenant, Jan Visscher Cornelisen Vaendrich, Rombout Kemp Sergeant, Reijnier Engelen Sergeant, Barent Harmansen, Jan Adriaensen Keyser, Elbert Willemsen, Jan Clasen Leydeckers, Jan Ockersen, Jan Pietersen bronchorst, Harman Iacobsen wormskerck, Jacob Dircksen de Roy, Jan vander heede, Walich Schellingwou, Jan brugman, Claes van Cruysbergen, Paulus Schoonhoven. De schutters zijn gewapend met lansen, musketten en hellebaarden. Rechts de tamboer met een grote trommel. Tussen de soldaten links staat een meisje met een dode kip om haar middel, rechts een blaffende hond. Linksboven de vaandrig met de uitgestoken vaandel.","labelText":null,"objectTypes":["schilderij"],"objectCollection":["schilderijen"],"makers":[{"name":"Rembrandt Harmensz. van Rijn","unFixedName":"Rembrandt Harmensz. van Rijn","placeOfBirth":"Leiden","dateOfBirth":"1606-07-15","dateOfBirthPrecision":null,"dateOfDeath":"1669-10-08","dateOfDeathPrecision":null,"placeOfDeath":"Amsterdam","occupation":["prentmaker","tekenaar","schilder"],"roles":["schilder"],"nationality":"Noord-Nederlands","biography":null,"productionPlaces":[],"schoolStyles":[],"qualification":null}],"principalMakers":[{"name":"Rembrandt Harmensz. van Rijn","unFixedName":"Rembrandt Harmensz. van Rijn","placeOfBirth":"Leiden","dateOfBirth":"1606-07-15","dateOfBirthPrecision":null,"dateOfDeath":"1669-10-08","dateOfDeathPrecision":null,"placeOfDeath":"Amsterdam","occupation":["prentmaker","tekenaar","schilder"],"roles":["schilder"],"nationality":"Noord-Nederlands","biography":null,"productionPlaces":[],"schoolStyles":[],"qualification":null}],"plaqueDescriptionDutch":"Rembrandts beroemdste en grootste doek werd gemaakt voor de Kloveniersdoelen. Dit was een van de verenigingsgebouwen van de Amsterdamse schutterij, de burgerwacht van de stad. \r\nRembrandt was de eerste die op een groepsportret de figuren in actie weergaf. De kapitein, in het zwart, geeft zijn luitenant opdracht dat de compagnie moet gaan marcheren. De schutters stellen zich op. Met behulp van licht vestigde Rembrandt de aandacht op belangrijke details, zoals het handgebaar van de kapitein en het kleine meisje op de achtergrond. Zij is de mascotte van de schutters.","plaqueDescriptionEnglish":null,"principalMaker":"Rembrandt Harmensz. van Rijn","artistRole":null,"associations":[],"acquisition":{"method":"bruikleen","date":"1808-01-01T00:00:00Z","creditLine":"Bruikleen van de gemeente Amsterdam"},"exhibitions":[],"materials":["doek","olieverf"],"techniques":[],"productionPlaces":[],"dating":{"presentingDate":"ca. 1642","sortingDate":1642,"period":17},"classification":{"iconClassIdentifier":["45(+26)","45C1","48C7341","31D11222","45D12","34B11"],"motifs":[],"events":[],"periods":[],"places":["Amsterdam"],"people":[]},"hasImage":true,"historicalPersons":[],"inscriptions":["Rembrandt f 1642","signatuur en datum","Frans Banning Cocq, heer van purmerlant en Ilpendam, Capiteijn Willem van Ruijtenburch van Vlaerdingen, heer van Vlaerdingen, Lu[ij]tenant, Jan Visscher Cornelisen Vaendrich, Rombout Kemp Sergeant, Reijnier Engelen Sergeant, Barent Harmansen, Jan Adriaensen Keyser, Elbert Willemsen, Jan Clasen Leydeckers, Jan Ockersen, Jan Pietersen bronchorst, Harman Iacobsen wormskerck, Jacob Dircksen de Roy, Jan vander heede, Walich Schellingwou, Jan brugman, Claes van Cruysbergen, Paulus Schoonhoven","inscriptie"],"documentation":["Inzoomer object op zaal, 2013 (Nederlands/English).","A. Jensen Adams, Public Faces and Private Identities in Seventeenth-Century Holland, Portraiture and the Production of Community, New York 2009, p. 211-217, fig. 60.","M. Rayssac, 'l'Exode des Musées, Histoire des oeuvres d'art sous l'Occupation', Parijs 2007.",// more results...],"catRefRPK":[],"principalOrFirstMaker":"Rembrandt Harmensz. van Rijn","dimensions":[{"unit":"cm","type":"hoogte","part":null,"value":"379,5"},{"unit":"cm","type":"breedte","part":null,"value":"453,5"},{"unit":"kg","type":"gewicht","part":null,"value":"337"},{"unit":"kg","type":"gewicht","part":null,"value":"170"}],"physicalProperties":[],"physicalMedium":"olieverf op doek","longTitle":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’, Rembrandt Harmensz. van Rijn, 1642","subTitle":"h 379,5cm × b 453,5cm × g 337kg","scLabelLine":"Rembrandt Harmensz. van Rijn (15-jul-1606 - 08-okt-1669), 1642, olieverf op doek","label":{"title":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’","makerLine":"Rembrandt Harmensz van Rijn (1606–1669), olieverf op doek, 1642","description":null,"notes":null,"date":"2013-05-22"},"showImage":true},"artObjectPage":{"id":"nl-sk-c-5","similarPages":[],"lang":"nl","objectNumber":"sk-c-5","tags":[],"plaqueDescription":null,"audioFile1":null,"audioFileLabel1":null,"audioFileLabel2":null,"createdOn":"0001-01-01T00:00:00Z","updatedOn":"0001-01-01T00:00:00Z","adlibOverrides":{"titel":null,"maker":null,"etiketText":null}}
where I at this moment need only artObjects -> makers -> name and artobject -> title
And I need to do that for all 10
But as far as I know I can only have one fromJson so how do I take care that the second one is called and parsed
and the right info is on the Painting object
That is my question all the time
Roelof
and you
get to see the
painting shown
in the
Inspector.
Now if I
understand
your
question...
"Do I need to
make some more
object to get
this
working..."
I'd
say... No. You
only want one
object for
each
painting. Once
you have a
painting
object, it
should handle
all getting
all further
data it needs
for itself.
You don't
want duplicate
objects each
having half of
the data.
can
I for example
name the
function
fromJson2 or
fromJSONFromLink2
?
By naming
convention
#fromJson:
implies it
sits on the
class side.
To get
further data
for an
existing
object you
want an
instance-side
method, maybe
named
#getLink2Json.
HTH,
cheers
-ben
oke
numbers should be the objectNumbers because for the
rest I need them
I use a instance variable called painting to hold the
data.
so I can change the call to get data for the painting
to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json at:
#objectNumber).
^ instance
so numbers should be a collection of 10
ObjectNumbers
I'm presuming that 10 objectNumbers relate to 10
different paintings,
in which case, No, you should never need to deal with
a collection of 10 objectNumbers.
What you should have is a collection of
painting-objects which know their own objectNumber
and then iterate that collection sending each
painting-object the message "getLink2Json".
so I should use a loop to make a call to the
second api call
In Pharo OO approach, you don't "loop" on the
"calls",
you "iterate" on the "objects" asking them to use
their own data to do the stuff they know how to do.
i.e. Let each object take care of itself.
Which class is getImages defined on? That is really
important to understand your proposed solution.
I'm just presuming its defined on the class side of
Paintings since your are referring to the same URL as
before.
and you
get to see the
painting shown
in the
Inspector.
Now if I
understand
your
question...
"Do I need to
make some more
object to get
this
working..."
I'd
say... No. You
only want one
object for
each
painting. Once
you have a
painting
object, it
should handle
all getting
all further
data it needs
for itself.
You don't
want duplicate
objects each
having half of
the data.
can
I for example
name the
function
fromJson2 or
fromJSONFromLink2
?
By naming
convention
#fromJson:
implies it
sits on the
class side.
To get
further data
for an
existing
object you
want an
instance-side
method, maybe
named
#getLink2Json.
HTH,
cheers
-ben
oke
numbers should be the objectNumbers
because for the rest I need them
I use a instance variable called
painting to hold the data.
so I can change the call to get data
for the painting to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json
at: #objectNumber).
^ instance
so numbers should be a collection of
10 ObjectNumbers
I'm presuming that 10 objectNumbers
relate to 10 different paintings,
in which case, No, you should never
need to deal with a collection of 10
objectNumbers.
What you should have is a collection
of painting-objects which know their own
objectNumber
and then iterate that collection
sending each painting-object the message
"getLink2Json".
so I should use a loop to make a
call to the second api call
In Pharo OO approach, you don't
"loop" on the "calls",
you "iterate" on the "objects" asking
them to use their own data to do the
stuff they know how to do.
i.e. Let each object take care of
itself.
Which class is getImages defined on?
That is really important to understand
your proposed solution.
I'm just presuming its defined on the
class side of Paintings since your are
referring to the same URL as before.
On Wed, 13 Mar 2019 at 00:43, Roelof Wobben <[hidden email]> wrote: > I did try to make this idea work but now im complete lost. > > Right now the collection that should contain the objectNumbers is total empty > anyone who can see where I went wrong. > > I included my code so far.
A few things...
!Paintings class methodsFor: 'instance creation' stamp: 'RoelofWobben 3/12/2019 17:26'!
getImagesDataFromJSON: json
| instance |
instance := Painting new.
(json at: #values)
do: [ :artObjectJson |
| painting |
painting := Painting new.
painting imageUrl: (json at: #name).
instance addPainting: painting ].
^ instance! !
You are adding a painting to a painting, which semantically makes no sense.
i.e. where #addPainting: is sent to "instance" , that is holding a Painting.
I would not expect your Painting class to have a method addPainting: Paintings should have that method.
btw, Stop using "instance" as a variable name.
Its as bad as variables named "a", "i", "t", "z" - it provides no semantic context.
--------------------
Object subclass: #Paintings
instanceVariableNames: 'paintings numbers'
Paintings class
instanceVariableNames: 'numbers paintings'!
You've defined these variables on both the instance-side and class-side.
I'll hazard a guess that you should delete the class-side definition.
On Wed, 13 Mar 2019 at 00:43, Roelof
Wobben <[hidden email]>
wrote:
> I did try to make this idea work but now im
complete lost.
>
> Right now the collection that should contain
the objectNumbers is total empty
> anyone who can see where I went wrong.
>
> I included my code so far.
A few things...
!Paintings class methodsFor: 'instance
creation' stamp: 'RoelofWobben 3/12/2019
17:26'!
getImagesDataFromJSON: json
|
instance |
instance
:= Painting new.
(json
at: #values)
do:
[ :artObjectJson |
|
painting |
painting
:= Painting new.
painting
imageUrl: (json at: #name).
instance
addPainting: painting ].
^
instance! !
You are adding a painting to a painting,
which semantically makes no sense.
i.e. where #addPainting: is sent to
"instance" , that is holding a Painting.
I would not expect your Painting class to
have a method addPainting:
Paintings should have that method.
btw, Stop using "instance" as a variable
name.
Its as bad as variables named "a", "i", "t",
"z" - it provides no semantic context.
--------------------
Object subclass: #Paintings
instanceVariableNames:
'paintings numbers'
Paintings class
instanceVariableNames:
'numbers paintings'!
You've defined these variables on both the
instance-side and class-side.
I'll hazard a guess that you should delete
the class-side definition.
https://www.rijksmuseum.nl/api/nl/collection/<one objectNumber/tiles?key=14OGzuak&format=json
and I do not store the objectNumber in Paintings because I do not use it to display it in a seaside project.
Roelof
no. it gives you a collection of paintings, of which objectNumber is one attribute.
and the objectNumbers I can use for this url :
https://www.rijksmuseum.nl/api/nl/collection/<one objectNumber/tiles?key=14OGzuak&format=json
and I do not store the objectNumber in Paintings because I do not use it to display it in a seaside project.
Regardless of whether you display it or not, objectNumber is supplied by the server "as an attribute belonging to painting"
so store it inside your Painting objects.
Then rather than Seaside asking a collection of dumb numbers for each JPEG to display
it asks a collection of smart Painting objects for their JPEG to display (since they know their own objectNumber, they can get the JPEG themselves).
cheers -ben
On Wed, 13 Mar 2019 at 02:10, Roelof Wobben <[hidden email]> wrote:
Op 12-3-2019 om 18:46 schreef Ben
Coman:
On Wed, 13 Mar 2019 at 00:43, Roelof
Wobben <[hidden email]>
wrote:
> I did try to make this idea work but now im
complete lost.
>
> Right now the collection that should contain
the objectNumbers is total empty
> anyone who can see where I went wrong.
>
> I included my code so far.
A few things...
!Paintings class methodsFor: 'instance
creation' stamp: 'RoelofWobben 3/12/2019
17:26'!
getImagesDataFromJSON: json
|
instance |
instance
:= Painting new.
(json
at: #values)
do:
[ :artObjectJson |
|
painting |
painting
:= Painting new.
painting
imageUrl: (json at: #name).
instance
addPainting: painting ].
^
instance! !
You are adding a painting to a painting,
which semantically makes no sense.
i.e. where #addPainting: is sent to
"instance" , that is holding a Painting.
I would not expect your Painting class to
have a method addPainting:
Paintings should have that method.
btw, Stop using "instance" as a variable
name.
Its as bad as variables named "a", "i", "t",
"z" - it provides no semantic context.
--------------------
Object subclass: #Paintings
instanceVariableNames:
'paintings numbers'
Paintings class
instanceVariableNames:
'numbers paintings'!
You've defined these variables on both the
instance-side and class-side.
I'll hazard a guess that you should delete
the class-side definition.
https://www.rijksmuseum.nl/api/nl/collection/<one objectNumber/tiles?key=14OGzuak&format=json
and I do not store the objectNumber in Paintings because I do not use it to display it in a seaside project.
Roelof
Locked
Paintings.st (9K)