createStone test 3.6.0 failed

I just did a fresh createStone on my machine using a fresh download of 3.6.0 and it ran clean ... I've attached a log of the entire run (as an example of the kind of information I would like to see in bug reports like these).

If you would send me the output for another `createStone` run, that would help me understand what might be going on. I will be able to look at the versions of the various packages that are getting loaded and I might be able to tell what is going wrong by comparing with my successful run.

I'm a bit suspicious that perhaps the `updateGsDevKit -gctsd` jobs did not execute as expected, the error that you are getting implies that some 3.6.x specific packages did not get loaded ... the updateGsDevKit script goes around and tries to pull the latest code from github, but if for some reason the pull did not complete correctly that might explain the failed `bu snapshot` command....

Sooo I would like you to run `updateGsDevKit -gctsd > updateGsDevKit.log 2>&1` again and send me the full updateGsDevKit.log file. Also, in $GS_HOME please send me the output for the following commands:

git log -2
git status

I did an updateGsDevKit -gctsd, but I can not create a 3.6.0 stone via "createStone test 3.6.0"

---Starting backup to '/home/mf/GsDevKit_home/server/stones/test/backups//tode.dbf.gz' (11/24/2020 07:22:03)
---validating backup (11/24/2020 07:22:12)
'/home/mf/GsDevKit_home/server/stones/test/product/bin/copydbf /home/mf/GsDevKit_home/server/stones/test/backups//tode.dbf.gz /dev/null'
Source file: /home/mf/GsDevKit_home/server/stones/test/backups/tode.dbf.gz
File type: backup fileId: 0 in a backup set with 1 files
File size: 22032685 bytes (21 MB)
ByteOrder: Intel (LSB first) compatibilityLevel: 860 
The file was created at: 24.11.2020 16:22:08 CET
Full backup started from checkpoint at: 24.11.2020 16:22:08 CET.
Oldest tranlog needed for restore is fileId 3 ( tranlog3.dbf ).
Backup was created by GemStone Version: 3.6.0, Thu Nov 12 13:55:02 2020, 6da8c2690bad7db0.
Backup Attributes:
Compression: GZIP
Encryption: NONE
Signature Hash: NONE
Encryption Keys: 0

---Finished backup to 24/11/2020 07:22:11 -- tode.dbf.gz

========>Server Stack:

EXCEPTION: UserDefinedError: unexpected format
1. UserDefinedError(AbstractException)>>_signalWith: @5 line 25
2. UserDefinedError(AbstractException)>>signal @2 line 47
3. SmallScaledDecimal(Object)>>error: @6 line 7
4. SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: @11 line 9
5. SmallDateAndTime(DateAndTimeANSI)>>print:on: @50 line 24
6. SmallDateAndTime(DateAndTimeANSI)>>printAnsiOn: @3 line 4
7. SmallDateAndTime(DateAndTimeANSI)>>printOn: @2 line 3
8. SmallDateAndTime(Object)>>printString @6 line 14
9. SmallDateAndTime(DateAndTimeANSI)>>printString @2 line 28
10. [] in TDGemStoneTool>>snapshot:to:suspendInMinutes:safely: @14 line 10
11. ExecBlock0(ExecBlock)>>ensure: @2 line 12
12. TDGemStoneTool>>snapshot:to:suspendInMinutes:safely: @2 line 68
13. TDGemStoneTool>>busnapshot @10 line 34
14. TDGemStoneTool(Object)>>perform: @1 line 8
15. TDGemStoneTool class(TDAbstractDevTool class)>>performSubCommand:objIn:commandOptions:todeCommand: @26 line 23
16. [] in TDGemStoneTool class>>bu @5 line 5
17. ExecBlock4(ExecBlock)>>cull:cull:cull:cull: @20 line 14
18. TDTopezServer>>evaluateCommand:objIn: @18 line 22
19. TDTopezServer>>evaluateSTONCommand: @9 line 6
20. Executed Code
21. GsNMethod class>>_gsReturnToC @1 line 11

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

createstone.log (85K) Download Attachment

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

[hidden email] hat am 30.11.2020 05:37 geschrieben:

Marten,

Could you provide (here or directly to me) enough of the walkback to show where it occurs in Jade?

James

On Nov 27, 2020, at 12:06 AM, Marten Feldtmann via Glass <[hidden email]> wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |

(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]

^1

I know it does not make much sense ...

Marten

_______________________________________________

Glass mailing list

[hidden email]

https://lists.gemtalksystems.com/mailman/listinfo/glass

jade_2_4_6_against_3_6_0.png (14K) Download Attachment

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

Dale Henrichs via Glass <[hidden email]> hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

I've got a fix[1] queued up for ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:[2]. It looks like I should be able to push the fix tomorrow (travis runs take a loooooooong time these days).

Dale

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

On 11/30/20 11:39 AM, Marten Feldtmann wrote:

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

Marten,

fix for #131 (glassdb/glass) has been pushed to github on the master branch, so do a `git pull`, try another 3.6.0 createStone and let me know how it works ...

Dale

On 11/30/20 6:46 PM, Dale Henrichs wrote:

I've got a fix[1] queued up for ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:[2]. It looks like I should be able to push the fix tomorrow (travis runs take a loooooooong time these days).

Dale

[1] https://github.com/GsDevKit/GsDevKit/issues/131
[2] https://travis-ci.org/github/glassdb/glass/builds/746889098

On 11/30/20 6:30 PM, Dale Henrichs wrote:

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

On 11/30/20 11:39 AM, Marten Feldtmann wrote:

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

Dale Henrichs <[hidden email]> hat am 01.12.2020 18:22 geschrieben:

Marten,

fix for #131 (glassdb/glass) has been pushed to github on the master branch, so do a `git pull`, try another 3.6.0 createStone and let me know how it works ...

Dale

On 11/30/20 6:46 PM, Dale Henrichs wrote:

I've got a fix[1] queued up for ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:[2]. It looks like I should be able to push the fix tomorrow (travis runs take a loooooooong time these days).

Dale

[1] https://github.com/GsDevKit/GsDevKit/issues/131
[2] https://travis-ci.org/github/glassdb/glass/builds/746889098

On 11/30/20 6:30 PM, Dale Henrichs wrote:

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

On 11/30/20 11:39 AM, Marten Feldtmann wrote:

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

Marten Feldtmann via Glass <[hidden email]> hat am 01.12.2020 20:49 geschrieben:

Hello Dale,

I did a "git pull", I did a " updateGsDevKit -g -t -i" , but the createStone script is still crashing at the end due to the same error. "git log -2" shows only changes up to 24.11.2020 ...

The reason are still some *squeak extension methods, so that

SmallDateAndTime now inspect

throws an unexpected Format error.

Marten

Dale Henrichs <[hidden email]> hat am 01.12.2020 18:22 geschrieben:

Marten,

fix for #131 (glassdb/glass) has been pushed to github on the master branch, so do a `git pull`, try another 3.6.0 createStone and let me know how it works ...

Dale

On 11/30/20 6:46 PM, Dale Henrichs wrote:

I've got a fix[1] queued up for ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:[2]. It looks like I should be able to push the fix tomorrow (travis runs take a loooooooong time these days).

Dale

[1] https://github.com/GsDevKit/GsDevKit/issues/131
[2] https://travis-ci.org/github/glassdb/glass/builds/746889098

On 11/30/20 6:30 PM, Dale Henrichs wrote:

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

On 11/30/20 11:39 AM, Marten Feldtmann wrote:

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

"git log -2" shows only changes up to 24.11.2020

You are clearly missing the commit from November 26 and 30.  In my clone I'm seeing all of the commits on the master branch.

Here's picture of the commits up on github:

So it means that somehow the `git pull` didn't work??

Here's a series of commands that I ran in my repo and you should see pretty much the same thing:

rogue:instance>git remote -v
gsdevkit	[hidden email] (fetch)
gsdevkit	[hidden email] (push)
origin	[hidden email] (fetch)
origin	[hidden email] (push)
rogue:instance>git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
rogue:instance>git log
commit be86d29fcc3efd86dc59d6ab6ccddb3480c2f2ea (HEAD -> master, origin/master, origin/issue_130, origin/HEAD, issue_130)
Author: Dale Henrichs [hidden email]
Date:   Mon Nov 30 18:40:59 2020 -0800

    Issue #130: remove a debug statement

commit 0226e549a0c43181587525212cf8bfbbff6ea331
Author: Dale Henrichs [hidden email]
Date:   Mon Nov 30 12:44:44 2020 -0800

    Issue #131: use Locale class>>decimalPoint in ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

commit 7a6df0e62cf39f1b0292a4040249dcea64dc5e21
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 13:11:33 2020 -0800

    Issue #130: one final change needed to properly load a definition with a nil superclass

commit f450354df2e09acbb24420402e7b60662c1279bc
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 12:05:15 2020 -0800

    Issue #130: also missing UndefinedObject>>subclass:instVarNames:classVars:classInstVars:poolDictionaries:inDictionary:category:options:

commit c88ba2ad3e500e3df7ceb88ba1df40846b4d8992
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 11:32:30 2020 -0800

    proposed fix for Isssue #130

commit 463fc94d28ace7dbebeb11fea1de43b0d0e76887
Author: Dale Henrichs [hidden email]
Date:   Sun Nov 1 13:03:55 2020 -0800

    Issue #129: bump the monticello versions again, since they need to trump versions on GemSource

Run these four commands and send me the output so I can try to understand why  you are not able to get the newer commits:

  git remote -v
  git status
  git pull origin master
  git log -2

Dale

Marten,

I need to see stacks, and the expression used to create them, please.

Dale

Well, a simple DateAndTime now asString will also fail. In 3.5.x the printing stuff ends somewhere in SmallDouble and uses asStringLocaleC, now the method is ending up in ScaledDecimal and there is US oriented parsing on a string created via asString (and not asStringLocaleC).

Marten

Marten Feldtmann via Glass [hidden email] hat am 01.12.2020 20:49 geschrieben:

Hello Dale,

I did a "git pull", I did a " updateGsDevKit -g -t -i" , but the createStone script is still crashing at the end due to the same error. "git log -2" shows only changes up to 24.11.2020 ...

The reason are still some *squeak extension methods, so that

SmallDateAndTime now inspect

throws an unexpected Format error.

Marten

Dale Henrichs [hidden email] hat am 01.12.2020 18:22 geschrieben:

Marten,

fix for #131 (glassdb/glass) has been pushed to github on the master branch, so do a `git pull`, try another 3.6.0 createStone and let me know how it works ...

Dale

On 11/30/20 6:46 PM, Dale Henrichs wrote:

I've got a fix[1] queued up for ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:[2]. It looks like I should be able to push the fix tomorrow (travis runs take a loooooooong time these days).

Dale

[1] https://github.com/GsDevKit/GsDevKit/issues/131
[2] https://travis-ci.org/github/glassdb/glass/builds/746889098

On 11/30/20 6:30 PM, Dale Henrichs wrote:

That was my guess ... so `Locale decimalPoint` returns a $, ... as it should?

Dale

On 11/30/20 11:39 AM, Marten Feldtmann wrote:

My decimal point here in Germany is $, and therefore NOT $.

Marten

Dale Henrichs via Glass [hidden email] hat am 30.11.2020 20:08 geschrieben:

Marten,

Could you confirm that your `Locale decimalPoint` is not $. ... I'm assuming that that's the case, but I would like a confirmation ...

Thanks,

Dale

On 11/30/20 10:13 AM, Dale Henrichs wrote:

Hold the phone ... it turns out that your the code in 3.6.0 is expecting there to be a $. in the printString for a ScaledDecimal, and I'm going to assume that you've got a comma ... I should be able to patch that this afternoon ...

Sorry for the confusion, but I _assumed_ that the unexpected format error was related to an instance variable reference in a method executed against a Small* class, since we had that problem along the way during the development of 3.6.0 ...

Also not that the old implementation of ScaledDecimal>>_printAsDateAndTimeANSISecondsOn: has the same test (for $.), so I guess it _is_ surprising that you haven't hit this problem before ... hmm, maybe we fixed a bug with ScaledDecimal so that it's printString uses the local for printing ...

Dale

On 11/30/20 10:02 AM, Dale Henrichs wrote:

could you send me the implementation of SmallScaledDecimal(ScaledDecimal)>>_printAsDateAndTimeANSISecondsOn: in your image?

Use the following topaz command in a topaz session, logged in as DataCurator:

lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

From the error you are getting it seems that you must be touching an instance variable in ScaledDecimal in the method that causes the message to fail with the "unexpected format" message..

For the record here is the old implementation (from 3.5.4):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream

        | string i |
        "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
        string := (self + 100) asString.        
        (string at: 4) = $. ifFalse: [self error: 'unexpected format'].
        i := string size.
        [
                (string at: i) = $0 or: [ (string at: i) = $. ].
        ] whileTrue: [
                i := i - 1.
        ].
        aStream nextPutAll: (string copyFrom: 2 to: i).
%

and the new implementation (for 3.6.0):

topaz 1> lookup ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:
    category: '*squeak'
method: ScaledDecimal
_printAsDateAndTimeANSISecondsOn: aStream
  | string i noDecimalPoint |
  "Adding 100 causes a very tiny loss of precission but makes parsing much easier"
  self = 0
    ifTrue: [ aStream nextPutAll: '00' ]
    ifFalse: [ 
      string := (self + 100) asString.
      (string at: 4) = $.
        ifFalse: [ self error: 'unexpected format' ].
      i := string size.
      noDecimalPoint := true.
      [ 
      | char |
      "strip trailing 0's"
      char := string at: i.
      noDecimalPoint
        ifTrue: [ noDecimalPoint := char ~= $. ].
      noDecimalPoint and: [ char = $0 ] ]
        whileTrue: [ i := i - 1 ].
      noDecimalPoint
        ifFalse: [ 
          "don't include the decimal point in the printString, if $. is last character"
          i := i - 1 ].
      aStream nextPutAll: (string copyFrom: 2 to: i) ]
%

I pretty much compared all of the code loaded into the image, and other than an older version of AST-Core (AST-Core-dkh.105 instead of AST-Core-dkh.106) ... so the RB git repo is apparently not on the latest version ...

The code in question is in Squeak.v36-dkh.351 and you have loaded that version as well ...

Dale

On 11/27/20 12:06 AM, Marten Feldtmann via Glass wrote:

Hey,

actually something must be strange on my system. The original error is still there, but I was able to create a stone using "createStone -g test 3.6.0", but I can't do anything with it.

I tried Jade 2.4.6 with this running stone, but Jade complains (while connecting and starting) a compile error ...

_keysForDictionary: aDictionary

and as I understand it complains an undefined symbol (which seems to be the parameter aDictionary):

| keys |


(aDictionary isKindOf: RubyHash) ifFalse:[ ^super _keysForDictionary: aDictionary ]


                                                                      ^1



I know it does not make much sense ...



Marten

_______________________________________________
Glass mailing list
[hidden email]
https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________ Glass mailing list [hidden email] https://lists.gemtalksystems.com/mailman/listinfo/glass

git log -2
commit 96495d6dc7b83eb511a11fc2b2777e88e68b24d4 (HEAD -> master, origin/master, origin/HEAD)
Author: Dale Henrichs <[hidden email]>
Date: Tue Nov 24 09:11:33 2020 -0800

no travis keyfile needed for 3.6

commit f6c226f3fddfa161eae8d2f5baf75adf39a86f43
Author: Dale Henrichs <[hidden email]>
Date: Mon Nov 23 16:36:57 2020 -0800

add 3.6.0 to lineup

Dale Henrichs <[hidden email]> hat am 02.12.2020 18:20 geschrieben:

On 12/1/20 11:49 AM, Marten Feldtmann wrote:

"git log -2" shows only changes up to 24.11.2020

You are clearly missing the commit from November 26 and 30.  In my clone I'm seeing all of the commits on the master branch.

Here's picture of the commits up on github:

So it means that somehow the `git pull` didn't work??

Here's a series of commands that I ran in my repo and you should see pretty much the same thing:

rogue:instance>git remote -v
gsdevkit [hidden email] (fetch)
gsdevkit [hidden email] (push)
origin [hidden email] (fetch)
origin [hidden email] (push)
rogue:instance>git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
rogue:instance>git log
commit be86d29fcc3efd86dc59d6ab6ccddb3480c2f2ea (HEAD -> master, origin/master, origin/issue_130, origin/HEAD, issue_130)
Author: Dale Henrichs [hidden email]
Date:   Mon Nov 30 18:40:59 2020 -0800

    Issue #130: remove a debug statement

commit 0226e549a0c43181587525212cf8bfbbff6ea331
Author: Dale Henrichs [hidden email]
Date:   Mon Nov 30 12:44:44 2020 -0800

    Issue #131: use Locale class>>decimalPoint in ScaledDecimal>>_printAsDateAndTimeANSISecondsOn:

commit 7a6df0e62cf39f1b0292a4040249dcea64dc5e21
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 13:11:33 2020 -0800

    Issue #130: one final change needed to properly load a definition with a nil superclass

commit f450354df2e09acbb24420402e7b60662c1279bc
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 12:05:15 2020 -0800

    Issue #130: also missing UndefinedObject>>subclass:instVarNames:classVars:classInstVars:poolDictionaries:inDictionary:category:options:

commit c88ba2ad3e500e3df7ceb88ba1df40846b4d8992
Author: Dale Henrichs [hidden email]
Date:   Thu Nov 26 11:32:30 2020 -0800

    proposed fix for Isssue #130

commit 463fc94d28ace7dbebeb11fea1de43b0d0e76887
Author: Dale Henrichs [hidden email]
Date:   Sun Nov 1 13:03:55 2020 -0800

    Issue #129: bump the monticello versions again, since they need to trump versions on GemSource

Run these four commands and send me the output so I can try to understand why  you are not able to get the newer commits:

  git remote -v
  git status
  git pull origin master
  git log -2

Dale

I don't see the output for git log -2 after the git pull ...

Dale

mf@mf-HP-ZBook-17-G2:~/GsDevKit_home$ git remote -v 
origin https://github.com/GsDevKit/GsDevKit_home.git (fetch)
origin https://github.com/GsDevKit/GsDevKit_home.git (push)


git status
Auf Branch master
Ihr Branch ist auf demselben Stand wie 'origin/master'.

Unversionierte Dateien:
(benutzen Sie "git add <Datei>...", um die Änderungen zum Commit vorzumerken)

Obx/
deb.oberon.org.gpg.key
output.txt
st
updateGsDevKit.log
upgrade_1.log

nichts zum Commit vorgemerkt, aber es gibt unversionierte Dateien
(benutzen Sie "git add" zum Versionieren)


mf@mf-HP-ZBook-17-G2:~/GsDevKit_home$ git pull origin master
Von https://github.com/GsDevKit/GsDevKit_home
* branch master -> FETCH_HEAD
Bereits aktuell.
 

So, thats i  my output ... seems to be all ok.

Marten

Run these four commands and send me the output so I can try to understand why  you are not able to get the newer commits:

  git remote -v
  git status
  git pull origin master
  git log -2

Dale