dbxtalk working on pharo 3.0

On Fri, Mar 28, 2014 at 4:18 PM, Michael Roland <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="wQ7dZvWZmh4J" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">mrolan...@...> wrote:

On Thursday, February 13, 2014 10:26:55 AM UTC-5, Tudor Girba wrote:

Hi,

I just retried DBXTalk, and it now magically works!

Does anyone know why? :)

I did this:

Gofer new

smalltalkhubUser: 'DBXTalk' project: 'DBXTalkDriver';

package: 'ConfigurationOfOpenDBXDriver';

load.

#ConfigurationOfOpenDBXDriver asClass loadBleedingEdge.

Anyway, the only glitch I found is that the OpenDBX current wrongly returns "NBPharoOpenDBX class" instead of the instance.

I could not figure out where the initialization bug comes from, but I worked around it with:

NBPharoOpenDBX installAsCurrent.

I tested the functionality with an Oracle backend, and it just worked.

Thanks!

Doru

--

<a href="http://www.tudorgirba.com" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwww.tudorgirba.com\46sa\75D\46sntz\0751\46usg\75AFQjCNEXWhswZAwCntaXKQxadKwqlOSOxg';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwww.tudorgirba.com\46sa\75D\46sntz\0751\46usg\75AFQjCNEXWhswZAwCntaXKQxadKwqlOSOxg';return true;">www.tudorgirba.com

"Every thing has its own flow"

I tried DBXTalk today on Pharo 3 and got the NBPharoOpenDBX class error too.

This is my understanding of what causes the error.

The value returned by OpenDBX class>>#current is initialized in ConfigurationOfOpenDBXDriver>>#setNBOpenDBX.

#setNBOpenDBX has one line:

  (Smalltalk at: #OpenDBX) current: (Smalltalk at: #NBPharoOpenDBX).

This sets OpenDBX Current to an NBPharoOpenDBX class instead of an NBPharoOpenDBX instance.

Changing the statement to:

  (Smalltalk at: #NBPharoOpenDBX) installAsCurrent

indirectly sets OpenDBX Current to an instance of NBPharoOpenDBX so that

OpenDBX class>>#current will correctly return an instance of NBPharoOpenDBX.

Using OpenDBX class>>#installAsCurrent is needed because the OpenDBX class has

two class variables: CurrentLibraryFactory and Current.

CurrentLibraryFactory stores a class and Current stores an instance of that class.

The only way to set CurrentLibraryFactory is with the OpenDBX class>>#installAsCurrent method.

Using OpenDBX class>>#current: to set the instance directly can leave the CurrentLibraryFactory and Current variables out of sync.

Thanks! Michael was this committed to the repo?

 

--
Mariano
<a href="http://marianopeck.wordpress.com" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fmarianopeck.wordpress.com\46sa\75D\46sntz\0751\46usg\75AFQjCNF1S5-imMuGTVju-KV_lXzlrdAx0Q';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fmarianopeck.wordpress.com\46sa\75D\46sntz\0751\46usg\75AFQjCNF1S5-imMuGTVju-KV_lXzlrdAx0Q';return true;">http://marianopeck.wordpress.com

Hi!

I'd love to write a test along with the fix, so we can improve the CI infrastructure I set up (see post "[ANN] DBXTalk CI available").

Which is your smalltalkhub user so I give you commit grants?

Guille

On Wed, May 7, 2014 at 7:39 PM, Michael Roland <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="t68oyOSX33cJ" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">mrolan...@...> wrote:

No, the change has not been committed. No one else has verified that this change works. It works for me.

The change to the doit method performs the step that Tudor Girba mentioned in the first post: NBPharoOpenDBX installAsCurrent. So I think the change is correct.

 If someone will verify that the change works on their system, I will ask for permission to commit the change.

On Wednesday, May 7, 2014 9:28:11 AM UTC-4, Mariano Martinez Peck wrote:

On Fri, Mar 28, 2014 at 4:18 PM, Michael Roland <[hidden email]> wrote:

On Thursday, February 13, 2014 10:26:55 AM UTC-5, Tudor Girba wrote:

Hi,

I just retried DBXTalk, and it now magically works!

Does anyone know why? :)

I did this:

Gofer new

smalltalkhubUser: 'DBXTalk' project: 'DBXTalkDriver';

package: 'ConfigurationOfOpenDBXDriver';

load.

#ConfigurationOfOpenDBXDriver asClass loadBleedingEdge.

Anyway, the only glitch I found is that the OpenDBX current wrongly returns "NBPharoOpenDBX class" instead of the instance.

I could not figure out where the initialization bug comes from, but I worked around it with:

NBPharoOpenDBX installAsCurrent.

I tested the functionality with an Oracle backend, and it just worked.

Thanks!

Doru

--

<a href="http://www.tudorgirba.com" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwww.tudorgirba.com\46sa\75D\46sntz\0751\46usg\75AFQjCNEXWhswZAwCntaXKQxadKwqlOSOxg';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwww.tudorgirba.com\46sa\75D\46sntz\0751\46usg\75AFQjCNEXWhswZAwCntaXKQxadKwqlOSOxg';return true;">www.tudorgirba.com

"Every thing has its own flow"

I tried DBXTalk today on Pharo 3 and got the NBPharoOpenDBX class error too.

This is my understanding of what causes the error.

The value returned by OpenDBX class>>#current is initialized in ConfigurationOfOpenDBXDriver>>#setNBOpenDBX.

#setNBOpenDBX has one line:

  (Smalltalk at: #OpenDBX) current: (Smalltalk at: #NBPharoOpenDBX).

This sets OpenDBX Current to an NBPharoOpenDBX class instead of an NBPharoOpenDBX instance.

Changing the statement to:

  (Smalltalk at: #NBPharoOpenDBX) installAsCurrent

indirectly sets OpenDBX Current to an instance of NBPharoOpenDBX so that

OpenDBX class>>#current will correctly return an instance of NBPharoOpenDBX.

Using OpenDBX class>>#installAsCurrent is needed because the OpenDBX class has

two class variables: CurrentLibraryFactory and Current.

CurrentLibraryFactory stores a class and Current stores an instance of that class.

The only way to set CurrentLibraryFactory is with the OpenDBX class>>#installAsCurrent method.

Using OpenDBX class>>#current: to set the instance directly can leave the CurrentLibraryFactory and Current variables out of sync.

Thanks! Michael was this committed to the repo?

 

--
Mariano
<a href="http://marianopeck.wordpress.com" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fmarianopeck.wordpress.com\46sa\75D\46sntz\0751\46usg\75AFQjCNF1S5-imMuGTVju-KV_lXzlrdAx0Q';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fmarianopeck.wordpress.com\46sa\75D\46sntz\0751\46usg\75AFQjCNF1S5-imMuGTVju-KV_lXzlrdAx0Q';return true;">http://marianopeck.wordpress.com

--
You received this message because you are subscribed to the Google Groups "DBXTalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="t68oyOSX33cJ" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">dbxtalk+u...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.