empty class comments

If you load a new class from store, it defines the class with an empty
class comment. This makes the comment warning icons a lot less useful.

It is easy to test this -- create a package with a new class, publish
the package, unload the package, and then load the package. After
loading the package, the class will have an empty class comment. It
appears that this was introduced in 7.7 as I can load the same published
package in 7.6 and the class will not have an empty comment.


John Brant
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

I remember there was related discussion in "[oct09.5] Classes with empty
comments", perhaps this is a side effect of changes that were taking
place there...

-Boris

--
DeepCove Labs Ltd.
+1 (604) 689-0322
4th floor, 595 Howe Street
Vancouver, British Columbia
Canada V6C 2T5
http://tinyurl.com/r7uw4

PacNet Services (Europe) Ltd.
+353 (0)61 714-360
Shannon Airport House, SFZ
County Clare, Ireland
http://tinyurl.com/y952amr

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message header.
Unless otherwise indicated, it contains information that is private and
confidential. If you have received it in error, please notify the sender
and delete the entire message including any attachments.

Thank you.


-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On
Behalf Of John Brant
Sent: 12 February 2010 14:11
To: VW NC
Subject: [vwnc] empty class comments

If you load a new class from store, it defines the class with an empty
class comment. This makes the comment warning icons a lot less useful.

It is easy to test this -- create a package with a new class, publish
the package, unload the package, and then load the package. After
loading the package, the class will have an empty class comment. It
appears that this was introduced in 7.7 as I can load the same published
package in 7.6 and the class will not have an empty comment.


John Brant
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

I don't get this, publishing and loading to a Postgresql repository. What type of database are you using? Is there anything peculiar about the comment?

At 09:11 AM 2010-02-12, John Brant wrote:

If you load a new class from store, it defines the class with an empty
class comment. This makes the comment warning icons a lot less useful.

It is easy to test this -- create a package with a new class, publish
the package, unload the package, and then load the package. After
loading the package, the class will have an empty class comment. It
appears that this was introduced in 7.7 as I can load the same published
package in 7.6 and the class will not have an empty comment.


John Brant
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight wrote:
> I don't get this, publishing and loading to a Postgresql repository.
> What type of database are you using? Is there anything peculiar about
> the comment?

I'm using postgresql, and there isn't a comment on the class. It appears
that Class>>asStoreClassDefinition always stores the comment since "self
comment" returns an empty string if there isn't a comment. Furthermore,
it appears that even if there wasn't an empty comment stored, it would
always create an empty comment (StoreSourceObject>>comment returns an
empty string which is set in
ShadowPackageCompileManager>>shadowDefineRecord:).


John Brant
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Ah, OK. I misunderstood what you were saying. I thought it was losing actual comments.

At 11:33 AM 2010-02-12, John Brant wrote:

Alan Knight wrote:
> I don't get this, publishing and loading to a Postgresql repository.
> What type of database are you using? Is there anything peculiar about
> the comment?

I'm using postgresql, and there isn't a comment on the class. It appears
that Class>>asStoreClassDefinition always stores the comment since "self
comment" returns an empty string if there isn't a comment. Furthermore,
it appears that even if there wasn't an empty comment stored, it would
always create an empty comment (StoreSourceObject>>comment returns an
empty string which is set in
ShadowPackageCompileManager>>shadowDefineRecord:).


John Brant

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc