fixing the tab morph

Hi,

So… summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.

First issue: the tab morph we have is horrible (and makes horrible anything with it). 

I’ve been working on it to fix that “chromish-but-bad” style we had and to fix some (a lot) hardcoded colors there. 

Now, for example, Calypso looks like this: 

which is IMHO a lot better :)

some remarks:  

1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell).

2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family… there should not be more than one widget to do the same in the system. 

So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)

Esteban

Le 07/08/2017 à 17:47, Esteban Lorenzano a écrit :
> Hi,
>
> So… summer project (to do when there is too much hot to go outside): fix
> some minor things that are inside the image that annoys me since some time.
>
> First issue: the tab morph we have is horrible (and makes horrible
> anything with it).
> I’ve been working on it to fix that “chromish-but-bad” style we had and
> to fix some (a lot) hardcoded colors there.
> Now, for example, Calypso looks like this:
>
>
>
>
> which is IMHO a lot better :)
>
> some remarks:
>
> 1) I find TabManagerMorph an ugly name. Do you think we should change
> it? (I tend to think anything called *Manager, *Controller, etc. as a
> bad naming chose and probably the mark of a smell).
> 2) much more important: we should deprecate TabGroupMorph and
> LazyTabGroupMorph family… there should not be more than one widget to do
> the same in the system.
>
> So well, as usual with old things: you fix a little thing and you
> uncover a lot of new problems :)
>
> Esteban
>
>

Hi,

I find those tabs too big. Am I the only one with this impression?

But nice job, those are really better :)

--
Cyril Ferlicot
https://ferlicot.fr

http://www.synectique.eu
2 rue Jacques Prévert 01,
59650 Villeneuve d'ascq France

Hi,

So… summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.

First issue: the tab morph we have is horrible (and makes horrible anything with it). 

I’ve been working on it to fix that “chromish-but-bad” style we had and to fix some (a lot) hardcoded colors there. 

Now, for example, Calypso looks like this: 

which is IMHO a lot better :)

some remarks:  

1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell).

2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family… there should not be more than one widget to do the same in the system. 

So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)

Esteban

I personally think that the tabs in TabGroupMorph look more like tabs :-)

-- Pavel

2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <[hidden email]>:

Hi,

So… summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.

First issue: the tab morph we have is horrible (and makes horrible anything with it). 

I’ve been working on it to fix that “chromish-but-bad” style we had and to fix some (a lot) hardcoded colors there. 

Now, for example, Calypso looks like this: 

which is IMHO a lot better :)

some remarks:  

1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell).

2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family… there should not be more than one widget to do the same in the system. 

So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)

Esteban