gst-package without -t

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

gst-package without -t

Stefan Schmiedl
Package.st (loaded by gst-package) contains the method (line 240)

    destDir: destdir installDir: instDir [
        self validateDestDir: destdir installDir: instDir.
        installDir :=
            File name: destdir, (instDir ifNil: [ self defaultInstallDir ])
    ]

with

    defaultInstallDir [ ^Directory image ]

This does not bode well when you don't supply an installation directory
with -t:

- Directory image  will give something like  <File /usr/local/var/lib/smalltalk>
- '' , <File ...> won't work
- What's the idea of appending an absolute path to destdir,
  whatever that may be?
 
Confused,
s.


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: gst-package without -t

Paolo Bonzini-2
Stefan Schmiedl wrote:

> Package.st (loaded by gst-package) contains the method (line 240)
>
>     destDir: destdir installDir: instDir [
> self validateDestDir: destdir installDir: instDir.
> installDir :=
>    File name: destdir, (instDir ifNil: [ self defaultInstallDir ])
>     ]
>
> with
>
>     defaultInstallDir [ ^Directory image ]
>
> This does not bode well when you don't supply an installation directory
> with -t:
>
> - Directory image  will give something like  <File /usr/local/var/lib/smalltalk>

Yes, one #asString is needed.

> - '' , <File ...> won't work
> - What's the idea of appending an absolute path to destdir,
>   whatever that may be?

To support "make install DESTDIR=/tmp/foo" which creates an installed
tree in /tmp/foo, ready to be packaged and then uncompressed in /.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk