gst-sunit

Hi,

I've extended gst-sunit to run sunit with a package description file
thanks to the Holger patch.

Cheers,
Gwen


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Tue, Jul 02, 2013 at 11:29:16AM +0200, Gwenaël Casaccio wrote:
> Hi,
>
> I've extended gst-sunit to run sunit with a package description file
> thanks to the Holger patch.

look's great

>      | pkg |
> -    pkg := PackageLoader packageAt: arg.
> +            (arg endsWith: '.xml')
> +                ifTrue: [ pkg := PackageLoader loadPackageFromFile: Directory working / arg ]
> +                ifFalse: [ pkg := PackageLoader packageAt: arg ].

mixing tabs/spaces? I think paolo pointed me to a book of kent beck that
argued for

   pkg := (arg endsWith: '.xml')
           ifTrue: [PackageLoader ...]
           ifFalse: [PackageLoader ...]

if you agree i will make these changes and apply.

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/07/2013 16:50, Holger Hans Peter Freyther wrote:
I agree Holger :)


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Mon, Jul 08, 2013 at 04:50:13PM +0200, Holger Hans Peter Freyther wrote:
> On Tue, Jul 02, 2013 at 11:29:16AM +0200, Gwenaël Casaccio wrote:
> > Hi,
> >
> > I've extended gst-sunit to run sunit with a package description file
> > thanks to the Holger patch.
>
> look's great

merged. What would be cool is.. if VisualGST would pop up a debugger
in case gst-sunit is failing (and a parameter is set)... re-running
the tests (saving the sunit script somewhere) and allowing nice fileout
would rock too.. okay I will stop with the wishful thinking.

holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Mon, Jul 08, 2013 at 06:14:19PM +0200, Holger Hans Peter Freyther wrote:
> merged. What would be cool is.. if VisualGST would pop up a debugger
> in case gst-sunit is failing (and a parameter is set)... re-running
> the tests (saving the sunit script somewhere) and allowing nice fileout
> would rock too.. okay I will stop with the wishful thinking.

one thing i realize now is that >>#loadPackageFromFile: will actually
load the package while >>#packageAt: would just return the package and
it would only later file it in. Does it make sense to remove this
difference in the future?

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk