how do I get the git commit diff

Hi

I still think that I would like in the squeak mailing-list to see the
diff of every commit by mail.
How can we enable that? Marcus you complain that not enough people are
active but we do not engage people by showing
changes. oh yes they can - by reading git commit.... oh boy if we
believe that people systematically have a look at that then
we are pretty naive.

Now do not tell me that I can browse git commit I know it and this is
not what I need.
I need SYSTEMATIC awareness of a change. I NEED everybody to be able to
have look before deleting a mail.
It is working in Squeak. I can in my mail look at the changes.

Or of course nobody cares in Pharo about changes and we can get regression.

Another question: how can I get the list of links to git with the commit
logs like
https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a8bab3c28e673114c 
below?
How can I get the list? so that I can browse (I'm probably one of the
two few interested in fixing bugs after they got introduced).


Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core
Commit: 8a1f79b44b14f8eafaf6d91a8bab3c28e673114c
https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a8bab3c28e673114c 

Author: Jenkins Build Server <[hidden email]> Date: 2015-09-04
(Fri, 04 Sep 2015)

Short side note: monday I will give a presentation about a code review tool for Pharo I will work on as an intern at rmod.
It’s called Griotte and there has already been some work done on it by Thomas, a previous intern. We will hold a
discussion afterwards.

Maybe doing something with e-mails is a good idea as well (for example when someone replies on a change).
I will put it in the presentation so that we can discuss this together.

So stay tuned for monday. I see that this is a current problem, so involving you in this project is a good idea (which is the
reason for my reply).

I can send the slides to the mailing list afterwards.

PS: for what it’s worth, when you comment to a diff in a pull request on Github, you also get an e-mail with the relevant
part of the diff.

Le 05/09/2015 19:51, Skip a écrit :
> Short side note: monday I will give a presentation about a code
> review tool for Pharo I will work on as an intern at rmod. It’s
> called Griotte and there has already been some work done on it by
> Thomas, a previous intern. We will hold a discussion afterwards.
>
> Maybe doing something with e-mails is a good idea as well (for
> example when someone replies on a change). I will put it in the
> presentation so that we can discuss this together.

I think the seamless email to web and back implemented by github is very
nice.

> So stay tuned for monday. I see that this is a current problem, so
> involving you in this project is a good idea (which is the reason for
> my reply).
>
> I can send the slides to the mailing list afterwards.
>
> PS: for what it’s worth, when you comment to a diff in a pull request
> on Github, you also get an e-mail with the relevant part of the
> diff.

PS: When you reply to that mail (or to an issue), then your email answer
is integrated in the comments... so you can reply by mail instead of
going to the web.

Little features often matter a lot in such a workflow.

Regards,

Thierry

I would like to see the code changed in email.
In github first I have to go there (does not work when I'm off) or when internet is slow.
Then I have to click/expand and I just want to see the three lines that changes there and there.
It works well for the VM mailing-list. In a glance I can see the changes.
Without any extra tools.

the mail is not made for version control, github is. Why you would prefer a static way of doing things, from a very dynamic website ?

When you commit to a github repo everyone that watches that repo , that is everyone that is either a contributor to that repo or a github user that has clicked the watch button will be alerted about everything related to that repo. The alerts appear in the front page of github.com when you log in. That includes commits, pull requests, new branches, issues, bugs, feature requests you name it. You could link that feed to your email so you get email alerts but personally I prefer keeping my email seperate from version controlling stuff.

The advantages of github are too numerous to go in detail here, just read the github documentation. But to be put short, its easy to link towards other commits, you can comment commits , you can even comment specific lines of code (even using markdown ),  and edit and commit on the fly using the website without opening pharo or git pulling to your local repo. Personally I would prefer to see a lot more pull requests because they are a very nice way to chain commits together and view them as one entity since they will concern the same matter. Pull requests also can be chained to issues and bug reports to mark the closed or open. 

What you list you refer to ? The link https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a8bab3c28e673114c, refers to a single commit with a ton of renamed files. You mean how you can get the list with the diff of each file changed ? thats easy, click on the commit. If you go to the repo for example here https://github.com/pharo-project/pharo-core/commits/4.0 clicking .... will expand the commit message but you if click on the commit itself will send you to the list of the diff log for that commit. Do you mean something else ?

On Sat, Sep 5, 2015 at 10:02 AM stepharo <[hidden email]> wrote:

Hi

I still think that I would like in the squeak mailing-list to see the
diff of every commit by mail.
How can we enable that? Marcus you complain that not enough people are
active but we do not engage people by showing
changes. oh yes they can - by reading git commit.... oh boy if we
believe that people systematically have a look at that then
we are pretty naive.

Now do not tell me that I can browse git commit I know it and this is
not what I need.
I need SYSTEMATIC awareness of a change. I NEED everybody to be able to
have look before deleting a mail.
It is working in Squeak. I can in my mail look at the changes.

Or of course nobody cares in Pharo about changes and we can get regression.

Another question: how can I get the list of links to git with the commit
logs like
https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a8bab3c28e673114c
below?
How can I get the list? so that I can browse (I'm probably one of the
two few interested in fixing bugs after they got introduced).


Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core
Commit: 8a1f79b44b14f8eafaf6d91a8bab3c28e673114c
https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a8bab3c28e673114c

Author: Jenkins Build Server <[hidden email]> Date: 2015-09-04
(Fri, 04 Sep 2015)