how do I push fixed upstream?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

how do I push fixed upstream?

Peter Uhnak
How do I push "fixed upstream"?

Since it doesn't have "Fix Review Needed" nobody will see it, review it and merge it. How should I mark it? Do I need to make another step?


Peter
Reply | Threaded
Open this post in threaded view
|

Re: how do I push fixed upstream?

Andrei Chis
To push it you need to make a version for that project.

Then if that version only fixes a single bug you can put the issue on "fix review needed" and fill in the fields ConfigurationOf and ConfigurationVersion from the issue. 

Alternatively, if you need to integrate more issues, you can put those issues on fixed upstream and create a new issue that you put on "fix review needed", fill in ConfigurationOf and ConfigurationVersion and add in the description the issues that it addresses.

For gtools we usually uses the second approach and integrate when there are 2-3 issues on fixed upstream.
I can make a new version for glamour to integrate on monday (I'm travelling tomorrow) but if you want you can give it a try. Creating a new version for glamour with versioner should be easy :)

Cheers,
Andrei

On Sat, Sep 5, 2015 at 8:51 PM, Peter Uhnák <[hidden email]> wrote:
How do I push "fixed upstream"?

Since it doesn't have "Fix Review Needed" nobody will see it, review it and merge it. How should I mark it? Do I need to make another step?


Peter

Reply | Threaded
Open this post in threaded view
|

Re: how do I push fixed upstream?

Nicolai Hess
In reply to this post by Peter Uhnak
notify the maintainers

2015-09-05 20:51 GMT+02:00 Peter Uhnák <[hidden email]>:
How do I push "fixed upstream"?

Since it doesn't have "Fix Review Needed" nobody will see it, review it and merge it. How should I mark it? Do I need to make another step?


Peter