how to issue a PR that changes package structure?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

how to issue a PR that changes package structure?

Stephane Ducasse-3
Hi guys

I would like to split or/and create packages.
Should I update the Pharo baseline.

Stef

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: how to issue a PR that changes package structure?

CyrilFerlicot
Le 08/07/2017 à 20:15, Stephane Ducasse a écrit :
> Hi guys
>
> I would like to split or/and create packages.
> Should I update the Pharo baseline.
>
> Stef
>

I saw Pavel doing PR to remove packages by removing them from the
baselines.

Example:
https://github.com/pharo-project/pharo/commit/c3ac94585f50e56f574249c1b5113a5c8f5d4e4c


--
Cyril Ferlicot
https://ferlicot.fr

http://www.synectique.eu
2 rue Jacques Prévert 01,
59650 Villeneuve d'ascq France


signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: how to issue a PR that changes package structure?

Pavel Krivanek-3
In reply to this post by Stephane Ducasse-3
Yes, any change in the packages structure needs to be integrated together with the corresponding changes in baselines. BaselineOfIDE has groups so they need to be changed as well.

-- Pavel

2017-07-08 20:15 GMT+02:00 Stephane Ducasse <[hidden email]>:
Hi guys

I would like to split or/and create packages.
Should I update the Pharo baseline.

Stef


Loading...