Smalltalk › Pharo › Pharo Smalltalk Developers

how to issue a PR that changes package structure?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Stephane Ducasse-3

how to issue a PR that changes package structure?

Hi guys

I would like to split or/and create packages.
Should I update the Pharo baseline.

Stef

CyrilFerlicot

Re: how to issue a PR that changes package structure?

Le 08/07/2017 à 20:15, Stephane Ducasse a écrit :
> Hi guys
>
> I would like to split or/and create packages.
> Should I update the Pharo baseline.
>
> Stef
>

I saw Pavel doing PR to remove packages by removing them from the
baselines.

Example:
https://github.com/pharo-project/pharo/commit/c3ac94585f50e56f574249c1b5113a5c8f5d4e4c

--
Cyril Ferlicot
https://ferlicot.fr

http://www.synectique.eu
2 rue Jacques Prévert 01,
59650 Villeneuve d'ascq France

signature.asc (836 bytes) Download Attachment

Pavel Krivanek-3

Re: how to issue a PR that changes package structure?

In reply to this post by Stephane Ducasse-3

Yes, any change in the packages structure needs to be integrated together with the corresponding changes in baselines. BaselineOfIDE has groups so they need to be changed as well.

-- Pavel

2017-07-08 20:15 GMT+02:00 Stephane Ducasse <[hidden email]>:

Hi guys

I would like to split or/and create packages.
Should I update the Pharo baseline.

Stef