http view parameter not working in gemstone

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

http view parameter not working in gemstone

NorbertHartl
I installed a complete new pier on a fresh gemstone image and noticed that the RSS views are not working. This is due another "aString is not equal to aSymbol" issue.

In PRPierFrame class>>classFromRequest: aRequest name: aString base: aBaseClass

there is

^ aBaseClass withAllConcreteClasses
                detect: [ :each |
                        each isAbstract not
                                and: [ each name = value
                                or: [ each label = value ] ] ]
                ifNone: [ nil ]

but class names are symbols and http parameters are strings. So I changed this to

^ aBaseClass withAllConcreteClasses
                detect: [ :each |
                        each isAbstract not
                                and: [ each name = value asSymbol
                                or: [ each label = value ] ] ]
                ifNone: [ nil ]

Norbert
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: http view parameter not working in gemstone

Lukas Renggli
Thank you for the bug report. I've committed a fix.

On 5 April 2010 17:40, Norbert Hartl <[hidden email]> wrote:

> I installed a complete new pier on a fresh gemstone image and noticed that the RSS views are not working. This is due another "aString is not equal to aSymbol" issue.
>
> In PRPierFrame class>>classFromRequest: aRequest name: aString base: aBaseClass
>
> there is
>
> ^ aBaseClass withAllConcreteClasses
>                detect: [ :each |
>                        each isAbstract not
>                                and: [ each name = value
>                                or: [ each label = value ] ] ]
>                ifNone: [ nil ]
>
> but class names are symbols and http parameters are strings. So I changed this to
>
> ^ aBaseClass withAllConcreteClasses
>                detect: [ :each |
>                        each isAbstract not
>                                and: [ each name = value asSymbol
>                                or: [ each label = value ] ] ]
>                ifNone: [ nil ]
>
> Norbert
> _______________________________________________
> Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>



--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki