improving print-it in playground

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Tudor Girba-2
Hi Ben,

In this case, why don't you inspect the list to the right and see a preview within the inspector?

Cheers,
Doru

On Sun, Jan 25, 2015 at 4:55 AM, Ben Coman <[hidden email]> wrote:


On Mon, Jan 19, 2015 at 5:07 PM, Tudor Girba <[hidden email]> wrote:
Thanks for the feedback.

I am still looking for concrete use cases why people need to see the printout in the editor. Could you provide an example of when you need it?


Here is one I just had.  I wanted to select the result of this...

     Object allMethods detect: [ :m | m senders size = 1 ]  

so that I could press the shortcut key for "all senders" on it to view that code.

cheers -ben



--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

wernerk
  > I am still looking for concrete use cases why people need to see the
printout in the editor.

on my pharo i have usually several workspaces flying around, one of them
usually start with
Smalltalk garbageCollect .
followed by a commented printout. if things get strange the commented
printout can become a list. the next line normally looks like this:
(ObjectImWorkinOn  allInstances )size.
followed by a commented printout. if things get strange the commented
printout can become a list.
werner

Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Ben Coman
In reply to this post by Tudor Girba-2


On Sun, Jan 25, 2015 at 2:55 PM, Tudor Girba <[hidden email]> wrote:
Hi Ben,

In this case, why don't you inspect the list to the right and see a preview within the inspector?

Cheers,
Doru

Maybe just habit.  Sometimes its harder to change these little things, or even to recognise that you've got them.  I'll keep my eyes open for a chance to do it the new way and see how it compares.
cheers -ben

Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Tudor Girba-2

On Sun, Jan 25, 2015 at 4:38 PM, Ben Coman <[hidden email]> wrote:


On Sun, Jan 25, 2015 at 2:55 PM, Tudor Girba <[hidden email]> wrote:
Hi Ben,

In this case, why don't you inspect the list to the right and see a preview within the inspector?

Cheers,
Doru

Maybe just habit.  Sometimes its harder to change these little things, or even to recognise that you've got them.  I'll keep my eyes open for a chance to do it the new way and see how it compares.
cheers -ben




--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

sebastianconcept@gmail.co
In reply to this post by Tudor Girba-2
It’s really nice to see innovation in this area. I feel grateful for this work.

Here comes my UX notes

Things I like:

- Publish to the cloud 
- Able to copy-paste the content of the box with feedback
- Encourages inspect of that very instance (this one was really good!)
- transforms the printed result to comment.
- clicking in the workspace makes the result disappear (good!)
- full selects the comment after enter so a second enter can clean it
- the shared snipped page has syntax highlight

Things that I see can be improved:

- the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one
- the printed result transformed to comment gets injected at the cursor position and that functionality doesn’t really make much sense (having it printed always at the end of the line you make more sense for example).
- the inspect button doesn’t look like a button and doesn’t change the cursor on hover
- No undo on cmd-z (this one feels like a deal-breaker)
- The tab for me is a redundant feature with an unclean title (we have how to recall different workspaces from the bottom bar already)
- The icon to publish to the cloud looks like download from the cloud (arrow points down instead of up)
- The inspector is surprisingly complex and abuses the use of tabs
- The inspector for Dictionary by default hides a naive observation of the object and assumes that a “smart” object aware presentation hiding behind a click the tree-like observation of instvars.
- Also in inspector the icon for browse looks like a document, doesn’t feel like a match

good work!




On Jan 19, 2015, at 5:33 AM, Tudor Girba <[hidden email]> wrote:

Hi,

I worked with Andrei to find a solution for improving the print-it support. You can take a look here:

The current solution can be found in the latest Pharo image.

Cheers,
Doru

--

"Every thing has its own flow"

Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Sven Van Caekenberghe-2

> On 25 Jan 2015, at 18:24, Sebastian Sastre <[hidden email]> wrote:
>
> - the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one

He Seb,

I designed that years ago over a WE - you're right, I am really good at design ;-)

It is just one page, do you care to propose a make over in concrete html/css. If you want I can try to give you access to the code that generates it (it is not open source as yet).

Sven



Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

sebastianconcept@gmail.co
Sure, I’d gladly sent you a merge request to get that improved

Let me know how I could take a look



> On Jan 25, 2015, at 3:34 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>
>
>> On 25 Jan 2015, at 18:24, Sebastian Sastre <[hidden email]> wrote:
>>
>> - the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one
>
> He Seb,
>
> I designed that years ago over a WE - you're right, I am really good at design ;-)
>
> It is just one page, do you care to propose a make over in concrete html/css. If you want I can try to give you access to the code that generates it (it is not open source as yet).
>
> Sven
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Sven Van Caekenberghe-2

> On 25 Jan 2015, at 18:59, Sebastian Sastre <[hidden email]> wrote:
>
> Sure, I’d gladly sent you a merge request to get that improved
>
> Let me know how I could take a look

https://github.com/svenvc/zinc/tree/master/repository/Zinc-WWS-Server.package

You can load this using ConfigurationOfZincHTTPComponents group 'WWS'.

Start with the class comment of ZnWebWorkspaceDelegate

the method you are looking for is #generatePageFor:withKey:

Please touch only the HTML/CSS ;-)

Thanks!

>> On Jan 25, 2015, at 3:34 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>>
>>> On 25 Jan 2015, at 18:24, Sebastian Sastre <[hidden email]> wrote:
>>>
>>> - the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one
>>
>> He Seb,
>>
>> I designed that years ago over a WE - you're right, I am really good at design ;-)
>>
>> It is just one page, do you care to propose a make over in concrete html/css. If you want I can try to give you access to the code that generates it (it is not open source as yet).
>>
>> Sven
>>
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

sebastianconcept@gmail.co
thanks for making easy to contribute!

Expect PR anytime


> On Jan 25, 2015, at 4:54 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>
>
>> On 25 Jan 2015, at 18:59, Sebastian Sastre <[hidden email]> wrote:
>>
>> Sure, I’d gladly sent you a merge request to get that improved
>>
>> Let me know how I could take a look
>
> https://github.com/svenvc/zinc/tree/master/repository/Zinc-WWS-Server.package
>
> You can load this using ConfigurationOfZincHTTPComponents group 'WWS'.
>
> Start with the class comment of ZnWebWorkspaceDelegate
>
> the method you are looking for is #generatePageFor:withKey:
>
> Please touch only the HTML/CSS ;-)
>
> Thanks!
>
>>> On Jan 25, 2015, at 3:34 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>>>
>>>
>>>> On 25 Jan 2015, at 18:24, Sebastian Sastre <[hidden email]> wrote:
>>>>
>>>> - the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one
>>>
>>> He Seb,
>>>
>>> I designed that years ago over a WE - you're right, I am really good at design ;-)
>>>
>>> It is just one page, do you care to propose a make over in concrete html/css. If you want I can try to give you access to the code that generates it (it is not open source as yet).
>>>
>>> Sven
>>>
>>>
>>>
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: improving print-it in playground

Tudor Girba-2
In reply to this post by sebastianconcept@gmail.co
Hi Sebastian,

Thanks for the feedback.

On Sun, Jan 25, 2015 at 6:24 PM, Sebastian Sastre <[hidden email]> wrote:
It’s really nice to see innovation in this area. I feel grateful for this work.

Here comes my UX notes

Things I like:

- Publish to the cloud 
- Able to copy-paste the content of the box with feedback
- Encourages inspect of that very instance (this one was really good!)
- transforms the printed result to comment.
- clicking in the workspace makes the result disappear (good!)
- full selects the comment after enter so a second enter can clean it
- the shared snipped page has syntax highlight

Things that I see can be improved:

- the shared snippet page has a terrible design, the contrast issue is probably the most severe, being unclean the second one
- the printed result transformed to comment gets injected at the cursor position and that functionality doesn’t really make much sense (having it printed always at the end of the line you make more sense for example).

This is still under work. The current behavior is the same as the previous print-it. We are considering all this input and we'll come back with a proposal.
 

- the inspect button doesn’t look like a button and doesn’t change the cursor on hover
- No undo on cmd-z (this one feels like a deal-breaker)

What do you mean? Undo should work as expected (even after I insert the code in the editor). Could you give me a way to reproduce the problem?


- The tab for me is a redundant feature with an unclean title (we have how to recall different workspaces from the bottom bar already)

This is a work in progress.

 
- The icon to publish to the cloud looks like download from the cloud (arrow points down instead of up)

Good point. I changed it.
 
- The inspector is surprisingly complex and abuses the use of tabs

What is complex? What do you mean by abuses the use of tabs? Could you give examples of what you saw and what you expected?

In case you did not see it before, the GTInspector wants to be more than a classic inspector, so perhaps that is why the implementation does not seem to align with expectations. Here is a post that describes in some details the concept behind:

 
- The inspector for Dictionary by default hides a naive observation of the object and assumes that a “smart” object aware presentation hiding behind a click the tree-like observation of instvars.

I am not sure what you are saying here, but If I understand correctly, you would prefer to see the raw tally and array of associations instead of a table as the first view for a dictionary. Is that is so, why do you find it a better representation?
 

- Also in inspector the icon for browse looks like a document, doesn’t feel like a match

I am not happy with that one either, but I could not figure out a better one. Do you have a suggestion?

 
good work!

Thanks.

Doru
 



On Jan 19, 2015, at 5:33 AM, Tudor Girba <[hidden email]> wrote:

Hi,

I worked with Andrei to find a solution for improving the print-it support. You can take a look here:

The current solution can be found in the latest Pharo image.

Cheers,
Doru

--

"Every thing has its own flow"




--

"Every thing has its own flow"
12