in issue 2537: OB System Browser fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

in issue 2537: OB System Browser fix

Johan Brichau
A simple fix to an annoying problem ;-)

The OB System Browser's search bar has the annoying property that an expansion of keyworded messages inserts whitespaces between the keywords.
That eventually means the search will not find the keyworded message if you do not remove the whitespace before hitting enter.
This changeset fixes it

Lukas: we can also send the mcz, but where?

----------------------------
Johan Brichau
[hidden email]





_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: in issue 2537: OB System Browser fix

Lukas Renggli
The proposed change unfortunately breaks other queries (string search
and parse tree search).

I committed a slightly different solution:

http://code.google.com/p/pharo/issues/detail?id=2537

Lukas

On 11 June 2010 18:18, Johan Brichau <[hidden email]> wrote:

> A simple fix to an annoying problem ;-)
>
> The OB System Browser's search bar has the annoying property that an expansion of keyworded messages inserts whitespaces between the keywords.
> That eventually means the search will not find the keyworded message if you do not remove the whitespace before hitting enter.
> This changeset fixes it
>
> Lukas: we can also send the mcz, but where?
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: in issue 2537: OB System Browser fix

Johan Brichau
thanks Lukas

just for us to know: where can we find info on those kinds of queries? (we were not aware about them)

On 11 Jun 2010, at 19:15, Lukas Renggli wrote:

> The proposed change unfortunately breaks other queries (string search
> and parse tree search).
>
> I committed a slightly different solution:
>
> http://code.google.com/p/pharo/issues/detail?id=2537
>
> Lukas
>
> On 11 June 2010 18:18, Johan Brichau <[hidden email]> wrote:
>> A simple fix to an annoying problem ;-)
>>
>> The OB System Browser's search bar has the annoying property that an expansion of keyworded messages inserts whitespaces between the keywords.
>> That eventually means the search will not find the keyworded message if you do not remove the whitespace before hitting enter.
>> This changeset fixes it
>>
>> Lukas: we can also send the mcz, but where?
>>
>> ----------------------------
>> Johan Brichau
>> [hidden email]
>>
>>
>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>
> --
> Lukas Renggli
> www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

----------------------------
Johan Brichau
[hidden email]





_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: in issue 2537: OB System Browser fix

Lukas Renggli
I think these queries were originally proposed in a blog post and
eventually they got added to OB. Unfortunately I can find the post
anymore.

I've never used or enabled the mercury panel myself. It was suggested
to be removed from the codebase as only very few people find it useful
or know how to use it. Since there are quite some test cases for the
mercury panel I was hesitating to do so up to now.

I recently removed the protocol browser. I never used it, it was
untested, violated model and view separation, and was badly broken.

Lukas

On 12 June 2010 10:36, Johan Brichau <[hidden email]> wrote:

> thanks Lukas
>
> just for us to know: where can we find info on those kinds of queries? (we were not aware about them)
>
> On 11 Jun 2010, at 19:15, Lukas Renggli wrote:
>
>> The proposed change unfortunately breaks other queries (string search
>> and parse tree search).
>>
>> I committed a slightly different solution:
>>
>> http://code.google.com/p/pharo/issues/detail?id=2537
>>
>> Lukas
>>
>> On 11 June 2010 18:18, Johan Brichau <[hidden email]> wrote:
>>> A simple fix to an annoying problem ;-)
>>>
>>> The OB System Browser's search bar has the annoying property that an expansion of keyworded messages inserts whitespaces between the keywords.
>>> That eventually means the search will not find the keyworded message if you do not remove the whitespace before hitting enter.
>>> This changeset fixes it
>>>
>>> Lukas: we can also send the mcz, but where?
>>>
>>> ----------------------------
>>> Johan Brichau
>>> [hidden email]
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>>
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project