make check fails

        Hello, folks!

I am not sure, that it's a common problem. When I'm sure, I'll make an  
issue on the site.$ make check
...
ERROR: 116 tests were run,
51 failed unexpectedly.
1 test was skipped.

Is it broken or I have a local problem?
Generally the problem appears in (warning?) message like  
this:geometry.st:158: class without indexed instance variables passed  
to instantiate_with

Thanks. Regards,
--
Ildar  Mulyukov,  free SW designer/programmer
================================================
email: [hidden email]
home: http://tuganger.narod.ru/
ALT Linux Sisyphus
================================================


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Ildar Mulyukov wrote:
>
>     Hello, folks!
>
> I am not sure, that it's a common problem. When I'm sure, I'll make an
> issue on the site.

What system and version?

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On 28.11.2007 22:22:36, Paolo Bonzini wrote:
> Ildar Mulyukov wrote:
> >
> >     Hello, folks!
> >
> > I am not sure, that it's a common problem. When I'm sure, I'll make  
> an
> > issue on the site.
>
> What system and version?

        HI, Paolo,

It appeared that the reason for that was the "--enable-checking" option  
to configure. Without it, everything works fine. So I can go further.

Regards, Ildar.
--
Ildar  Mulyukov,  free SW designer/programmer
================================================
email: [hidden email]
home: http://tuganger.narod.ru/
ALT Linux Sisyphus
================================================


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Ildar Mulyukov wrote: This patch fixes all the failures but one.  Thanks!

Paolo

2007-11-29  Paolo Bonzini  <[hidden email]>

        * libgst/dict.inl: Loosen tests of usage of instantiate and
        instantiate_with.


--- orig/libgst/dict.inl
+++ mod/libgst/dict.inl
@@ -674,6 +674,12 @@ instantiate_with (OOP class_oop,
   gst_object p_instance;
 
   instanceSpec = CLASS_INSTANCE_SPEC (class_oop);
+#ifndef OPTIMIZE
+  if (!(instanceSpec & ISP_ISINDEXABLE) && numIndexFields != 0)
+    _gst_errorf
+      ("class without indexed instance variables passed to instantiate_with");
+#endif
+
   indexedBytes = numIndexFields << _gst_log2_sizes[instanceSpec & ISP_SHAPE];
   numBytes = sizeof (gst_object_header)
     + SIZE_TO_BYTES(instanceSpec >> ISP_NUMFIXEDFIELDS)
@@ -697,12 +703,6 @@ instantiate_with (OOP class_oop,
        indexedBytes);
     }
 
-#ifndef OPTIMIZE
-  if (!(instanceSpec & ISP_ISINDEXABLE))
-    _gst_errorf
-      ("class without indexed instance variables passed to instantiate_with");
-#endif
-
   return p_instance;
 }
 
@@ -723,12 +723,6 @@ instantiate (OOP class_oop,
 
   (*p_oop)->flags |= (class_oop->flags & F_UNTRUSTED);
 
-#ifndef OPTIMIZE
-  if (instanceSpec & ISP_ISINDEXABLE)
-    _gst_errorf
-      ("class with indexed instance variables passed to instantiate");
-#endif
-
   nil_fill (p_instance->data, instanceSpec >> ISP_NUMFIXEDFIELDS);
   return p_instance;
 }




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk