misc regressions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

misc regressions

Holger Freyther
Hi all,

this is from a master of today..

        - Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
          bisect is turning up the addition of SCGI to it. I will try to find
          the issue.

        - kernel/*.st not installed properly. In case gst is not yet
          installed, make install will fail as kernel/*.st is not installed.

/usr/bin/install -c -m 644 /home/ich/source/smalltalk/smalltalk/packages.xml
/home/ich/install/gst/share/smalltalk/packages.xml
/bin/mkdir -p /home/ich/install/gst/var/lib/smalltalk
cd /home/ich/install/gst/var/lib/smalltalk && \
   "/home/ich/source/smalltalk/smalltalk/build/gst" --no-user-files -iS \
    --kernel-dir "/home/ich/install/gst/share/smalltalk/kernel" \
    --image "/home/ich/install/gst/var/lib/smalltalk/gst.im" \
    -f "/home/ich/source/smalltalk/smalltalk/build/../scripts/Finish.st" \
    "/home/ich/install/gst/var/lib/smalltalk"
gst: couldn't load system file 'Builtins.st': No such file or directory

        - gst-browser does seem to deadlock on start, or trigger a debugger
          and then deadlock.

it would be nice if someone else can confirm the last two issues. I will work
on the Swazoo issue first (as time permits) and then continue with the others...


holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Paolo Bonzini-2
On 12/08/2010 05:52 PM, Holger Hans Peter Freyther wrote:
> Hi all,
>
> this is from a master of today..
>
> - Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
>            bisect is turning up the addition of SCGI to it. I will try to find
>            the issue.

Thanks.

> - kernel/*.st not installed properly. In case gst is not yet
>            installed, make install will fail as kernel/*.st is not installed.

Possibly already fixed.

> - gst-browser does seem to deadlock on start, or trigger a debugger
>            and then deadlock.

Tried VisualGST master branch and it worked, don't know though.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Holger Freyther
On 12/09/2010 04:13 PM, Paolo Bonzini wrote:

> On 12/08/2010 05:52 PM, Holger Hans Peter Freyther wrote:
>> Hi all,
>>
>> this is from a master of today..
>>
>>     - Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
>>            bisect is turning up the addition of SCGI to it. I will try to find
>>            the issue.
>
> Thanks.

There is something I don't understand. Is there a way to see Exceptions/Error
raised and caught? The SCGI patch has removed the stringMatch: and the
siteMatch: method. The siteMatch: method is marked private but used by ILiad
and by Seaside. Having a MessageNotUnderstood would have eased finding this. I
am still not sure who is handling and ignoring this exception.

I would propose to re-add the siteMatch: method for now.



>
>>     - kernel/*.st not installed properly. In case gst is not yet
>>            installed, make install will fail as kernel/*.st is not installed.
>
> Possibly already fixed.


One other issue. gst-package --test package.xml fails if the package was not
previously installed. I am not sure if it was like this all the time.

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Nicolas Petton
In reply to this post by Holger Freyther
Le mercredi 08 décembre 2010 à 17:52 +0100, Holger Hans Peter Freyther a
écrit :
> git
>           bisect is turning up the addition of SCGI to it.


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Nicolas Petton
In reply to this post by Holger Freyther
Le mercredi 08 décembre 2010 à 17:52 +0100, Holger Hans Peter Freyther a
écrit :
> Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
>           bisect is turning up the addition of SCGI to it. I will try
> to find
>           the issue.

This is probably my fault then :/ If you want I can find the time to fix
it this WE.

Cheers,
Nico


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Paolo Bonzini-2
On 12/10/2010 08:34 AM, Nicolas Petton wrote:
> Le mercredi 08 décembre 2010 à 17:52 +0100, Holger Hans Peter Freyther a
> écrit :
>> Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
>>            bisect is turning up the addition of SCGI to it. I will try
>>            to find the issue.
>
> This is probably my fault then :/ If you want I can find the time to fix
> it this WE.

No, it is due to the refactoring I made to clean up the handling of
SiteIdentifiers, see the subsequent message that Holger sent.

This reintroduces the missing method, can you confirm it's the only problem?

diff --git a/packages/swazoo-httpd/HTTP.st b/packages/swazoo-httpd/HTTP.st
index 062c25b..32c9020 100644
--- a/packages/swazoo-httpd/HTTP.st
+++ b/packages/swazoo-httpd/HTTP.st
@@ -1955,6 +1955,11 @@ Object subclass: URIResolution [
  ^nil
      ]

+    siteMatch: aSite [
+ <category: 'backwards compatibility'>
+ ^aSite match: self request
+    ]
+
      tailPath [
  <category: 'accessing'>
  | fullPath |


Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Paolo Bonzini-2
In reply to this post by Holger Freyther
On 12/10/2010 02:56 AM, Holger Hans Peter Freyther wrote:
> There is something I don't understand. Is there a way to see Exceptions/Error
> raised and caught? [...]  Having a MessageNotUnderstood would have eased finding this. I
> am still not sure who is handling and ignoring this exception.

I usually remove the exception handlers, but you're right that having
that done by a boolean preference on the Site or Server objects would be
better.

> I would propose to re-add the siteMatch: method for now.

Agreed.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Holger Freyther
In reply to this post by Paolo Bonzini-2
On 12/10/2010 09:03 AM, Paolo Bonzini wrote:
> On 12/10/2010 08:34 AM, Nicolas Petton wrote:

>
> This reintroduces the missing method, can you confirm it's the only problem?

Yes, your clean up of siteMatch: is fixing the issue.


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Holger Freyther
In reply to this post by Paolo Bonzini-2
On 12/10/2010 09:47 AM, Paolo Bonzini wrote:
> On 12/10/2010 02:56 AM, Holger Hans Peter Freyther wrote:
>> There is something I don't understand. Is there a way to see Exceptions/Error
>> raised and caught? [...]  Having a MessageNotUnderstood would have eased
>> finding this. I
>> am still not sure who is handling and ignoring this exception.
>
> I usually remove the exception handlers, but you're right that having that
> done by a boolean preference on the Site or Server objects would be better.

How do you do this? Do you grep for on: do: and comment it out? also for ensure:?

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Nicolas Petton
In reply to this post by Paolo Bonzini-2
Le vendredi 10 décembre 2010 à 09:03 +0100, Paolo Bonzini a écrit :

> On 12/10/2010 08:34 AM, Nicolas Petton wrote:
> > Le mercredi 08 décembre 2010 à 17:52 +0100, Holger Hans Peter Freyther a
> > écrit :
> >> Seaside/ILiad are broken for the simple Swazoo HTTPD Server. git
> >>            bisect is turning up the addition of SCGI to it. I will try
> >>            to find the issue.
> >
> > This is probably my fault then :/ If you want I can find the time to fix
> > it this WE.
>
> No, it is due to the refactoring I made to clean up the handling of
> SiteIdentifiers, see the subsequent message that Holger sent.
>
> This reintroduces the missing method, can you confirm it's the only problem?

Yes, I'll try the patch this afternoon.

Nico


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Nicolas Petton
In reply to this post by Holger Freyther
Le samedi 11 décembre 2010 à 03:05 +0100, Holger Hans Peter Freyther a
écrit :
> On 12/10/2010 09:03 AM, Paolo Bonzini wrote:
> > On 12/10/2010 08:34 AM, Nicolas Petton wrote:
>
> >
> > This reintroduces the missing method, can you confirm it's the only problem?
>
> Yes, your clean up of siteMatch: is fixing the issue.

Oops, I didn't see you already checked :)

Nico



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: misc regressions

Paolo Bonzini-2
In reply to this post by Holger Freyther
On 12/11/2010 03:05 AM, Holger Hans Peter Freyther wrote:

> On 12/10/2010 09:47 AM, Paolo Bonzini wrote:
>> On 12/10/2010 02:56 AM, Holger Hans Peter Freyther wrote:
>>> There is something I don't understand. Is there a way to see Exceptions/Error
>>> raised and caught? [...]  Having a MessageNotUnderstood would have eased
>>> finding this. I
>>> am still not sure who is handling and ignoring this exception.
>>
>> I usually remove the exception handlers, but you're right that having that
>> done by a boolean preference on the Site or Server objects would be better.
>
> How do you do this? Do you grep for on: do: and comment it out? also for ensure:?

Only for #on:do:, there are just one or two in Swazoo.  I add "ex pass".

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk