Smalltalk › Pharo › Pharo Smalltalk Developers

missing critics results (maybe important for the issue validation)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Nicolai Hess-3-2

missing critics results (maybe important for the issue validation)

Would be nice if someone can take a look at this issue

16814 Critics Browser seriously broken

demarey

Re: missing critics results (maybe important for the issue validation)

Le 23 oct. 2015 à 11:02, Nicolai Hess a écrit :

Would be nice if someone can take a look at this issue

16814 Critics Browser seriously broken

slice is now in the inbox

smime.p7s (5K) Download Attachment

Nicolai Hess-3-2

Re: missing critics results (maybe important for the issue validation)

2015-10-23 14:35 GMT+02:00 Christophe Demarey <[hidden email]>:

Le 23 oct. 2015 à 11:02, Nicolai Hess a écrit :

Would be nice if someone can take a look at this issue

16814 Critics Browser seriously broken

slice is now in the inbox

Thanks,

but this won't work.

resetResult must be called (see failing RBSmalllintTest/SmalllintMantifestTest)

It is not obvious why this call should be removed, it was already there in the prior working version (pharo 50386).

demarey

Re: missing critics results (maybe important for the issue validation)

Le 23 oct. 2015 à 14:45, Nicolai Hess a écrit :

2015-10-23 14:35 GMT+02:00 Christophe Demarey <[hidden email]>:

Le 23 oct. 2015 à 11:02, Nicolai Hess a écrit :

Would be nice if someone can take a look at this issue

16814 Critics Browser seriously broken

slice is now in the inbox

Thanks,
but this won't work.
resetResult must be called (see failing RBSmalllintTest/SmalllintMantifestTest)

It has to be called but not in #run.

I will check but calling reset from #runRule:onEnvironment: should solve the issue

It is not obvious why this call should be removed, it was already there in the prior working version (pharo 50386).

yes but the run method is never called by #applyRules neither by #reapplyRules

run is called for each rule. If you reset the result, you only get the rule result fir the latest package checked.

smime.p7s (5K) Download Attachment