pending patches/pulls?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

pending patches/pulls?

Paolo Bonzini-2
Hi all,

I should have some time to merge stuff in the upcoming week, so please
reply with patches that I should merge.  Clean patch series are
preferred (such as the ones Holger sends, just to give an example :)).

In particular, I know Gwen has pending patches for the package loader
but I don't remember where to find them, and Mathieu has no-argument
pragmas.

Gwen, in the future can you call branches that are merge-ready with a
name that starts with "for-paolo-", and/or send pull requests for them
via github?

Thanks!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

Mathieu Suen-2
Hi Paolo

On May 9, 2011, at 6:35 PM, Paolo Bonzini wrote:

> Hi all,
>
> I should have some time to merge stuff in the upcoming week, so please reply with patches that I should merge.  Clean patch series are preferred (such as the ones Holger sends, just to give an example :)).
>
> In particular, I know Gwen has pending patches for the package loader but I don't remember where to find them, and Mathieu has no-argument pragmas.
>

Commit for unary pragma are:
1: 26dc39ae9662377c544d
2: 98724f5aefb0ff945024
3: 26c6aa52531f2af75df2

From the master branch.
Let me know if you have any issue.

I have fetch the latest commit of your mater branch without any conflict.

Thanks

> Gwen, in the future can you call branches that are merge-ready with a name that starts with "for-paolo-", and/or send pull requests for them via github?
>
> Thanks!
>
> Paolo
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk

--
Mathieu
_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

Paolo Bonzini-2
On 05/09/2011 07:44 PM, Mathieu Suen wrote:
> Commit for unary pragma are:
> 1: 26dc39ae9662377c544d
> 2: 98724f5aefb0ff945024
> 3: 26c6aa52531f2af75df2
>
>  From the master branch.
> Let me know if you have any issue.

Merged into stable-3.2 and master, thanks.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

MrGwen
In reply to this post by Paolo Bonzini-2
On 05/09/2011 06:35 PM, Paolo Bonzini wrote:

> Hi all,
>
> I should have some time to merge stuff in the upcoming week, so please
> reply with patches that I should merge. Clean patch series are preferred
> (such as the ones Holger sends, just to give an example :)).
>
> In particular, I know Gwen has pending patches for the package loader
> but I don't remember where to find them, and Mathieu has no-argument
> pragmas.
>
> Gwen, in the future can you call branches that are merge-ready with a
> name that starts with "for-paolo-", and/or send pull requests for them
> via github?
>
> Thanks!
>
> Paolo
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk
Hi,

here is a patch for the unicode character creation, instead of
creating all the time a new uchar, I put them in a weak arrays.

Cheers,
Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

uchar.patch (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

MrGwen
On 05/19/2011 11:00 AM, Gwenael Casaccio wrote:

> On 05/09/2011 06:35 PM, Paolo Bonzini wrote:
>> Hi all,
>>
>> I should have some time to merge stuff in the upcoming week, so please
>> reply with patches that I should merge. Clean patch series are preferred
>> (such as the ones Holger sends, just to give an example :)).
>>
>> In particular, I know Gwen has pending patches for the package loader
>> but I don't remember where to find them, and Mathieu has no-argument
>> pragmas.
>>
>> Gwen, in the future can you call branches that are merge-ready with a
>> name that starts with "for-paolo-", and/or send pull requests for them
>> via github?
>>
>> Thanks!
>>
>> Paolo
>>
>> _______________________________________________
>> help-smalltalk mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>
> Hi,
>
> here is a patch for the unicode character creation, instead of
> creating all the time a new uchar, I put them in a weak arrays.
>
> Cheers,
> Gwen
Here is another patch for method hook

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

methodHook.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

Paolo Bonzini-2
> Here is another patch for method hook

Interesting!  Does it work, alternatively, if you use _gst_msg_sendf to
send #at:put: to the MethodDictionary of the class (conditional on
_gst_kernel_initialized)?  Then you can do the hook from there.  It's
much less "magic". :)

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

MrGwen
In reply to this post by MrGwen
On 05/23/2011 10:20 AM, Gwenael Casaccio wrote:

> On 05/19/2011 11:00 AM, Gwenael Casaccio wrote:
>> On 05/09/2011 06:35 PM, Paolo Bonzini wrote:
>>> Hi all,
>>>
>>> I should have some time to merge stuff in the upcoming week, so please
>>> reply with patches that I should merge. Clean patch series are preferred
>>> (such as the ones Holger sends, just to give an example :)).
>>>
>>> In particular, I know Gwen has pending patches for the package loader
>>> but I don't remember where to find them, and Mathieu has no-argument
>>> pragmas.
>>>
>>> Gwen, in the future can you call branches that are merge-ready with a
>>> name that starts with "for-paolo-", and/or send pull requests for them
>>> via github?
>>>
>>> Thanks!
>>>
>>> Paolo
>>>
>>> _______________________________________________
>>> help-smalltalk mailing list
>>> [hidden email]
>>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>>
>> Hi,
>>
>> here is a patch for the unicode character creation, instead of
>> creating all the time a new uchar, I put them in a weak arrays.
>>
>> Cheers,
>> Gwen
>
> Here is another patch for method hook

Here are some other results for packages (subpackages and more information):

https://github.com/MrGwen/GNU-Smalltalk/commit/22f23a7fdb8a91391b336f61d7096c954ff1ed82
https://github.com/MrGwen/GNU-Smalltalk/commit/f9de1c8db9e41be8d41b75f831deff8afc6cbd8d
https://github.com/MrGwen/GNU-Smalltalk/commit/f42b8982473bf29a857d3996b523d0af169952bb
https://github.com/MrGwen/GNU-Smalltalk/commit/8aba9f9f2d9f77a703af161e936be3318d28bbb6

I've another package patch (need to find it ^^)
the problem with the actual load process of packages is if
the package is changed and we access the source code of
a file we can have a bad source code, So I've made a patch
that decompress all the files in the temp dir, and remove it
when the image closed. Thus if we change the package we have no
conflicts, and sovle also the bug with the resources (like png files
in visualgst) they are in /tmp and never removed. But I need to find it
gggrrrrr

Gwen



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

MrGwen
In reply to this post by Paolo Bonzini-2
On 05/23/2011 10:39 AM, Paolo Bonzini wrote:
>> Here is another patch for method hook
>
> Interesting! Does it work, alternatively, if you use _gst_msg_sendf to
> send #at:put: to the MethodDictionary of the class (conditional on
> _gst_kernel_initialized)? Then you can do the hook from there. It's much
> less "magic". :)
>
> Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

methodHook.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pending patches/pulls?

Paolo Bonzini-2
On 05/23/2011 01:05 PM, Gwenael Casaccio wrote:

> diff --git a/libgst/comp.c b/libgst/comp.c
> index 0819e96..9cc5986 100644
> --- a/libgst/comp.c
> +++ b/libgst/comp.c
> @@ -2481,8 +2481,11 @@ install_method (OOP methodOOP, OOP classOOP, mst_Boolean untrusted)
>       }
>
>     MAKE_OOP_READONLY (methodOOP, true);
> -  oldMethod = _gst_identity_dictionary_at_put (methodDictionaryOOP,
> -       selector, methodOOP);
> +  if (_gst_kernel_initialized)
> +      _gst_msg_sendf (&oldMethod, "%o %o at: %o put: %o", methodDictionaryOOP, selector, methodOOP);
> +  else
> +    oldMethod = _gst_identity_dictionary_at_put (methodDictionaryOOP,
> +           selector, methodOOP);
>
>   #ifdef ENABLE_JIT_TRANSLATION
>     if (oldMethod != _gst_nil_oop)

Applied to master branch, thanks.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk