Smalltalk › Pharo › Pharo Smalltalk Developers

[pharo-project/pharo] 20349 cleanup pinning protocols (#224)

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 2 messages Options
David T Lewis
Reply | Threaded
Open this post in threaded view
♦
♦
|

[pharo-project/pharo] 20349 cleanup pinning protocols (#224)

David T Lewis

See https://pharo.fogbugz.com/f/cases/20349/Cleanup-pinning-protocols

Cleanup the method protocols of

  • isPinned move from "system primitive" to "pinning"

  • pin move from "system primitive" to "pinning"

  • unpin move from "system primitive" to "pinning"

  • setPinned: move from "system primitive" to "private" (as this is not part of the public API)

You can view, comment on, or merge this pull request online at:

  https://github.com/pharo-project/pharo/pull/224

Commit Summary

  • Added #testManagersForCategoryDo
  • Merge with refs/remotes/upstream/development
  • Do the supercalss classification before all the others
  • remove lowSpaceWatcher override
  • update loaded Iceberg version to tag 0.5.2
  • Merge pull request #171 from pavel-krivanek/20255-Update-Iceberg-to-version-052-in-Pharo-7
  • Merge pull request #170 from Uko/20252-Automatic-method-categorization-causes-discrepancies-with-superclass-methods-protocols
  • WeakIdentityValueDictionary is done
  • Integrate Hermes
  • update iceberg to v0.5.3
  • first step towards smaller kernel
  • removed refernces to old streams
  • update to iceberg v0.5.4
  • Merge pull request #173 from estebanlm/development
  • Now table notifies existing rows about deletion and new rows about insertion.
  • Name: SLICE-Issue-20230-Space-analysis-resurrection-HernanMoralesDurand.1
  • Adding Hermes generation
  • Merge pull request #4 from tesonep/hermes
  • Merge pull request #154 from akgrant43/Issue20189b
  • Merge pull request #161 from pavel-krivanek/20226-TabMorph-should-use-stepping-mechanism-for-animating-background-building
  • Merge pull request #167 from pharo-project/20242-Manifest-builder-doesn-t-consider-that-a-method-or-a-class-may-nave-no-package
  • update iceberg (v0.5.5)
  • Merge pull request #176 from estebanlm/development
  • fix wrong content of method files
  • wrong method file name
  • reducing dependencies from kernel and system-support to filesystem
  • Merge branch 'hermes' of https://github.com/guillep/pharo into hermes
  • simplify Character class
  • using zinc encoders
  • manage command line handling initialization right
  • cleanup repository
  • Fix: remove symbol duplication by manually setting class names
  • Fixes: avoid recursive exceptions in kernel
  • fixed load st files in bootstrap
  • adding hermes generation
  • simplify bootstrapping first steps
  • fix: can read chunks using files
  • added jenkins file for testing
  • using latest image
  • testing only 32 bits
  • hotfix for CI
  • Hotfix: remove bad code from the script
  • Fix: download vm in jenkins file
  • loading monticello and metacello
  • fixed packages to load
  • Fixed encoding
  • better exception handling
  • refactored list of packages and protocols to create
  • fix: bugs impeding reloading
  • Patch: fix non portable cr in stdout
  • fixed tests
  • running with travis
  • travis: fix dependencies
  • Fix: initialize MultiByteFileStream after FileSystem is loaded
  • fixed source condensation
  • added cairo library to travis file
  • removed patches for class and instance variable creation
  • fixed tab
  • Fix test: Smalltalk image is not in the startup list anymore
  • Fix: fix release tests - force reloading of all mc packages
  • merge with pharo/development
  • removed method properties files
  • Cleanup: remove duplicated class builder package
  • Merge build.sh
  • Fix: remove duplicated byte encoders
  • Cleanup: indentation
  • Fix: loading latest baseline before generating hermes files
  • Fix: monticello bootstrap has to load Kernel-BytecodeEncoders mcz
  • Fixing version of Hermes
  • Fix: restored iceberg commit setup
  • Merge branch 'hermes' of https://github.com/guillep/pharo into hermes
  • test
  • fixed architecture
  • getting find output
  • remove backtick
  • stashing sources file
  • find image files in correct directory
  • archiving artifacts allways
  • archiving only generated images
  • portable shell
  • using portable shell everywhere
  • Update Jenkinsfile
  • Fix: non restricted travis clone depth
  • Update Jenkinsfile
  • Changing the jenkinsfile to not fail if could not find *.xml artifacts
  • Showing the error
  • Update Jenkinsfile
  • Adding runTest.sh
  • Update Jenkinsfile
  • Running tests in windows
  • Update Jenkinsfile
  • Update Jenkinsfile
  • Update runTests.sh
  • Update runTests.sh
  • Removing stupid lines
  • Update runTests.sh
  • Fixing the architecture.
  • Trying to find the files without quotes.
  • Update runTests.sh
  • Trying different quotes
  • Merge pull request #177 from guillep/hermes
  • Merge pull request #178 from guillep/20285-add-jenkins-file-into-repository
  • https://pharo.fogbugz.com/f/cases/20257/bitAnd-description-is-wrong
  • FIX: Revert package loading to a normal load instead of a raw snapshopt installation.
  • Enhancement: Code import should have an argument to not log sources
  • Fix: install multilingual before MC so we can start up source file handling before. Methods installed be the compiler will embed source code if changes file is not available otherwise.
  • Fix: added missing double quote
  • Fix: initialize logSource to true as default
  • FIX: Quality assistant tests should always close windows, even in headless. Otherwise they produce side effects
  • FIX: change position to before the truncated position. Otherwise the linux file plugin does not behave properly
  • Fix: metallo platform tests should use correct path delimiter to work in windows
  • Patch: skip QA buggy tests
  • Revert "FIX: Quality assistant tests should always close windows, even in headless. Otherwise they produce side effects"
  • added script to prepare archives to upload
  • Fix: correct indentation
  • get flat tabs.
  • reduce indented space between tabbar and contents
  • Enhancement: make build tag appear before sha
  • Adding alpha tag
  • reviewed with guille. Now all the tests should be green.
  • added 64 bits preparation also
  • Enhancement: adding transformation step 32 to 64 bit to jenkins
  • Fix: use architecture as string
  • fix some colors (most of them were hardcoded)
  • Enhancement: put all archived files together
  • correct formating
  • Fix: bootstrap cache path
  • ok done with pavel a while ago and the failed test is in zinc
  • https://pharo.fogbugz.com/f/cases/20257/bitAnd-description-is-wrong
  • https://pharo.fogbugz.com/f/cases/20233/MCPackageManager-class-managersForCategory-do-marks-too-many-packages-as-modified
  • extended jenkins file with upload
  • Merge pull request #186 from guillep/20291-Convert-32-bit-images-in-64
  • Merge latest pharo development
  • fixed upload with jenkins sshagent
  • Merge pull request #185 from guillep/20290-Add-build-number-to-uploaded-files
  • Fix script path for upload
  • HOTFIX: correct scp server path
  • HOTFIX: fix upload script paths
  • HOTFIX: upload also main images
  • fix height
  • fix border volors
  • Looks ok. I will readd WidgetInput in another PR later
  • Looks ok : https://pharo.fogbugz.com/f/cases/20063/
  • Looks nice and Denis is around. https://pharo.fogbugz.com/f/cases/20238/
  • https://pharo.fogbugz.com/f/cases/20295/
  • bootstrap job should not wait for tests
  • Fix enclosing of brackets
  • https://pharo.fogbugz.com/f/cases/20249/Add-some-colors-to-the-themes
  • Fix variable declarations
  • fixed test variable declaration
  • https://pharo.fogbugz.com/f/cases/17848/SequenciableCollection-first-raise-an-Error-if-the-collection-if-too-small
  • Merge pull request #188 from guillep/20297-Avoid-deadlocks-in-jenkins
  • Merge pull request #182 from guillep/20286-Bootstrap-packages-are-dirty-in-a-fresh-image
  • do not ignore BaselineOfIDE warnings
  • Issue 13217 Initial commit
  • add class comment
  • commit
  • https://pharo.fogbugz.com/f/cases/13217/FS-basename-with-compound-path-string
  • Integrate WebBrowser-Core package to be able to open a browser on a URL
  • https://pharo.fogbugz.com/f/cases/20009/Recompilation-of-trait-methods-creates-changes-record-in-the-users
  • added pharo repository name
  • Merge pull request #194 from guillep/20305-Pharo-system-repository-should-have-a-name
  • Integrate in next Build
  • make SUnit exportable by Hermes and add PerformMessageCommandLineHandler
  • 19802-Make-sure-Symbol-concatenation-results-in-a-Symbol-not-a-String
  • https://pharo.fogbugz.com/f/cases/20196/Remove-StringMorphEditor
  • case 18650
  • Merge pull request #190 from pavel-krivanek/20301-loading-of-BaselineOfIDE-must-not-resolve-conflicts-automatically
  • Add comment to AbstractFileReference>>size.
  • Add 'iso88591' to the encoding names of Latin1TextConverters + recategorize some methods.
  • Change the disable color from the dark theme because it is too close from the basic color.
  • https://pharo.fogbugz.com/f/cases/20105/Implement-WeakIdentityValueDictionary
  • Split WorldState class>>mostUsedTools: to let each tool define its own entry on the menu. This commit also add #order: to the different items. This is helpful when we want to add some items as Iceberg.
  • This PR will increment the progress bar of ZipArchive unzip. This incrementation will be done each 100ms to not lose perfs. Also, I change the update of the progress bar label to be done only each 100ms. I tried on a zip with only small files and it improved the perf by around 5-6%.
  • Improve comment of SmallDictionary
  • Pash down index variable from slot to indexed slots. See case 20191 https://pharo.fogbugz.com/f/cases/20191/index-inst-var-should-move-from-Slot-to-IndexedSlot
  • Case 20307 File names should not be canonicalised by default
  • https://pharo.fogbugz.com/f/cases/20091/Improve-comment-of-SmallDictionary
  • Convert HenrikNergaard slice.
  • Create a first class error for instance variable access failure when we try to access it by its name.
  • https://pharo.fogbugz.com/f/cases/20307/File-names-should-not-be-canonicalised-by-default
  • Merge in Renraku v1.0.1
  • https://pharo.fogbugz.com/f/cases/20269/FileReference-size-needs-a-comment
  • Issue 20165 Support segment path printing
  • Merged in Renraku v1.0.2
  • Just four tests from https://pharo.fogbugz.com/f/cases/20165/Support-segment-path-printing
  • https://pharo.fogbugz.com/f/cases/18084/FileReference-EnsureCreateFile
  • Add tests for new exception "NoInstanceVariableNamed"
  • Use a more robust way to get the package associated to a protocol.
  • Merge branch 'development' of https://github.com/pharo-project/pharo into 20304-Integrate-WebBrowser-package
  • use LibC
  • add web browser package to BaselineOfIDE as requested by Pavel on https://github.com/pharo-project/pharo/pull/193
  • allow extensible search for #webbrowserClassForPlatform
  • https://pharo.fogbugz.com/f/cases/19697/MailMessage-API-Improvement
  • use #fromRfc822:
  • Merge pull request #211 from pavel-krivanek/20320-MailMessage-tests-are-broken-
  • to avoid Undeclared, we move it to the BaselineOfUI (before HelpSystem-Core)
  • Fix case 20321: built image should contain build number in suffix
  • Simplify system version
  • Fix case 20321: about window should show build info
  • Fix case 20321: fix build scripts
  • Merge branch 'development' into 20306-SUnit-exportable-by-Hermes
  • removing outdated tests
  • Fix case 20321: add build info to bootstrap.sh script
  • add InitializePackageCommandLineHandler, make JenkinsTools-Core loadable by Hermes
  • Fix case 20321: set BUILD_NUMBER in jenkins file
  • Replace NoInstanceVariableNamed by InstanceVariableNotFound
  • Fix case 20321: command line handler should use same version info
  • 20062-Open-a-package-extending-a-class-via-the-extension-protocol
  • https://pharo.fogbugz.com/f/cases/20321/Add-build-number-to-SystemVersion
  • https://pharo.fogbugz.com/f/cases/20230/Space-analysis-resurrection
  • https://pharo.fogbugz.com/f/cases/20256/Latin1TextConverter-should-know-mone-encoding-names
  • https://pharo.fogbugz.com/f/cases/20247/Refactor-the-MostUsedTools-of-the-world-menu-to-cut-dependencies-and-use-priorities
  • https://pharo.fogbugz.com/f/cases/18864/Remove-empty-protocols-on-categorize-all-uncategorized
  • Matrix: Trivial typo fix in method comment
  • https://pharo.fogbugz.com/f/cases/20114/Replace-self-error-no-such-inst-var-by-a-first-class-error
  • Use #lineNumberColor in rubric because current line number color is not dark theme friendly.
  • Merge branch 'development' into 20108-CompiledMethod-isAbstract-fails-on-64-bit
  • Merge branch 'development' into 19964-SendsDeprecatedMethodToGlobalRule-might-be-hard-to-spot
  • https://pharo.fogbugz.com/f/cases/resolve/18172/Rubric-line-numbers-are-not-dark-theme-friendly
  • https://pharo.fogbugz.com/f/cases/20326/Matrix-Trivial-typo-fix
  • Merge branch 'development' into 20306-SUnit-exportable-by-Hermes
  • use command line handler for the RPackage initialization
  • update jenkinsfile
  • fix typo
  • use ZnCharacterWriteStream for progress file because of windows slave
  • Merge pull request #195 from pavel-krivanek/20306-SUnit-exportable-by-Hermes
  • Merge pull request #205 from jecisc/20191-index-inst-var-should-move-from-Slot-to-IndexedSlot
  • Merge pull request #193 from astares/20304-Integrate-WebBrowser-package
  • Merge pull request #174 from pavel-krivanek/20260-FastTable-not-support-cell-morphs-with-stepping-animation
  • add kernel tests validation step
  • use explicit file names
  • fix variable access
  • Reviewed with Pavel
  • Merge pull request #104 from pavel-krivanek/19964-SendsDeprecatedMethodToGlobalRule-might-be-hard-to-spot
  • Merge pull request #201 from jecisc/20248-DarkTheme-disabledTextColor-is-too-close-of-textColor
  • Dead code: #destinationBuffer: and #digitBuffer:
  • remove deprecated call
  • * ported fallback for strings when primitive 105 fails from Squeak
  • Merge pull request #219 from pavel-krivanek/20340-IconHardcodedMessageRuleinitialize-is-dirty
  • updated iceberg to 0.5.7
  • Merge pull request #218 from MarcusDenker/20234-Dead-code-destinationBuffer-and-digitBuffer
  • Merge pull request #222 from estebanlm/20346-Update-Iceberg-to-057
  • Merge pull request #217 from pavel-krivanek/20332-Add-validation-step-for-binary-loaded-tests
  • Merge pull request #221 from theseion/20337-Squeak-has-a-fix-for-storing-wide-strings-into-a-ByteArray
  • do not expect failure from testWideStringClassName
  • Merge pull request #223 from pavel-krivanek/20348-testWideStringClassName-needs-to-be-unmarked-as-expected-failure
  • Merge pull request #216 from pavel-krivanek/20108-CompiledMethod-isAbstract-fails-on-64-bit
  • close 20314
  • Cleanup the method protocols of

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"20349 cleanup pinning protocols (#224)"}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/224"}}}</script>
David T Lewis
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [pharo-project/pharo] 20349 cleanup pinning protocols (#224)

David T Lewis

@pavel-krivanek approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pavel-krivanek approved #224"}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/224#pullrequestreview-59520923"}}}</script>
Free forum by Nabble Edit this page