[pharo-project/pharo-core] 82ed3f: 60058

  Branch: refs/heads/6.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: 82ed3f40c8bdac80c9d86cc20576167e66422da2
      https://github.com/pharo-project/pharo-core/commit/82ed3f40c8bdac80c9d86cc20576167e66422da2
  Author: Jenkins Build Server <[hidden email]>
  Date:   2016-06-03 (Fri, 03 Jun 2016)

  Changed paths:
    A Announcements-Core.package/Announcement.class/class/converting/where_.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/README.md
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/class/instance creation/for_where_.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/definition.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/instance/accessing/announcementClass.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/instance/accessing/announcementClass_.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/instance/accessing/conditionBlock.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/instance/accessing/conditionBlock_.st
    A Announcements-Core.package/AnnouncementDeliveryCondition.class/instance/testing/handlesAnnouncement_.st
    A Announcements-Tests-Core.package/AnnouncementMockB.class/class/instance creation/with_.st
    M Announcements-Tests-Core.package/AnnouncementMockB.class/definition.st
    A Announcements-Tests-Core.package/AnnouncementMockB.class/instance/accessing/parameter.st
    A Announcements-Tests-Core.package/AnnouncementMockB.class/instance/accessing/parameter_.st
    A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testSubscribeOnSpecificAnnouncer.st
    M ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/symbolic versions/stable_.st
    A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v3%5F0%5F1_.st
    M Monticello.package/MCClassDefinition.class/instance/printing/kindOfSubclass.st
    M QualityAssistantRecording.package/QAEventCollector.class/class/class initialization/initialize.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60057.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60058.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60057.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60058.st
    M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st

  Log Message:
  -----------
  60058
18389 Obsolete Critic class
        https://pharo.fogbugz.com/f/cases/18389

18392 Announcer should allow to subscribe on specific instances of events
        https://pharo.fogbugz.com/f/cases/18392

18387 Extend monticello to load ephemeron classes
        https://pharo.fogbugz.com/f/cases/18387

http://files.pharo.org/image/60/60058.zip

Hi Denis


I would really like that we get a public discussion about such addition

> 18392 Announcer should allow to subscribe on specific instances of events
> https://pharo.fogbugz.com/f/cases/18392

AnnouncementDeliveryCondition introduced. It can be used in place of
Announcement class in all subscription methods:

announcer when: (ValueChanged where: [:change | change oldValue =
#expected]) do: [:ann | ]

So since there was no real discussion I check the class comments:

Good class comment! Thanks.

Now I still would like to understand: AnnouncementDeliveryCondition is a
wrapper on a Announcement? I imagine yes.

Probably we should add that in the class comment.

Now I do not get why this filtering should be in the delivery because
the risk is that we will get
even more announcements in announcements queue. Of course it will
probably reduce the number of announcement
emitted. So I would like to know more.

Stef