[pharo-project/pharo-core] 986ba2: 60402

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[pharo-project/pharo-core] 986ba2: 60402

Eliot Miranda-3
  Branch: refs/heads/6.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: 986ba23013b6a211ee2f02693494240aec1bf922
      https://github.com/pharo-project/pharo-core/commit/986ba23013b6a211ee2f02693494240aec1bf922
  Author: Jenkins Build Server <[hidden email]>
  Date:   2017-02-20 (Mon, 20 Feb 2017)

  Changed paths:
    M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/baseline_.st
    M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/groups_.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60401.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60402.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60401.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60402.st
    M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
    A SublimishTheme.package/SublimishTheme.class/README.md
    A SublimishTheme.package/SublimishTheme.class/class/accessing/baseColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/basePassiveBackgroundColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/baseSelectionColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/darkBaseColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/lightBaseColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/lightSelectionColor.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/themeName.st
    A SublimishTheme.package/SublimishTheme.class/class/accessing/veryLightSelectionColor.st
    A SublimishTheme.package/SublimishTheme.class/class/private/importIcons_fromFolder_inClass_category_.st
    A SublimishTheme.package/SublimishTheme.class/class/settings/newDefaultSettings.st
    A SublimishTheme.package/SublimishTheme.class/class/settings/setPreferredPreferences.st
    A SublimishTheme.package/SublimishTheme.class/class/testing/isAbstract.st
    A SublimishTheme.package/SublimishTheme.class/definition.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/backgroundColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/balloonBackgroundColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/borderColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/buttonColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/caretColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/disabledColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/enabledColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/lightBackgroundColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/listTextColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/menuBorderColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/menuBorderWidth.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/scrollbarColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/secondarySelectionColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/selectionColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/selectionTextColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/spotlightWindowColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/textColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/textColorForNonStandardBackground.st
    A SublimishTheme.package/SublimishTheme.class/instance/accessing colors/unfocusedSelectionColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/basic-colors/subgroupColorFrom_.st
    A SublimishTheme.package/SublimishTheme.class/instance/basic-colors/taskbarButtonLabelColorForCollapsed_.st
    A SublimishTheme.package/SublimishTheme.class/instance/basic-colors/taskbarButtonLabelColorForExpanded_.st
    A SublimishTheme.package/SublimishTheme.class/instance/basic-colors/taskbarButtonLabelColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-buttons/buttonCornerStyleIn_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-buttons/buttonNormalBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-scrollbars/scrollbarNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-scrollbars/scrollbarNormalThumbBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-scrollbars/scrollbarPagingAreaCornerStyleIn_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles-scrollbars/scrollbarPressedThumbFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/configureWindowBorderFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/configureWindowDropShadowFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/dropListNormalBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/dropListNormalListBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/groupPanelBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/plainGroupPanelBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/tabLabelNormalBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/tabPanelBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/taskbarThumbnailCornerStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/taskbarThumbnailNormalBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/border-styles/textEditorNormalBorderStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/configure/configureMorphTreeMorph_.st
    A SublimishTheme.package/SublimishTheme.class/instance/configure/configurePluggableTextMorph_.st
    A SublimishTheme.package/SublimishTheme.class/instance/configure/configureScrollPane_.st
    A SublimishTheme.package/SublimishTheme.class/instance/configure/configureSystemWindow_.st
    A SublimishTheme.package/SublimishTheme.class/instance/configure/configureTextMorph_.st
    A SublimishTheme.package/SublimishTheme.class/instance/defaults/dialogWindowPreferredCornerStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/defaults/shStyleTable.st
    A SublimishTheme.package/SublimishTheme.class/instance/defaults/windowShadowColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/buttonNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/buttonSelectedFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/controlButtonNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/menuItemInDockingBarSelectedFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/tabLabelNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-buttons/tabLabelSelectedFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-scrollbars/scrollbarNormalButtonFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles-scrollbars/scrollbarNormalThumbFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/desktopColor.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/dockingBarNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/dropListDisabledFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/dropListNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/dropListNormalListFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/expanderTitleNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/listDisabledFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/listNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/morphTreeSplitterNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/morphTreeSplitterPressedFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/progressBarFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/progressBarProgressFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/progressFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/separatorFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/sliderDisabledFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/splitterNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/splitterPressedFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/taskbarFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/textEditorDisabledFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/textEditorNormalFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/windowActiveFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/windowActiveLabelFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/windowActiveTitleFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/windowInactiveFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/fill-styles/windowInactiveTitleFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/checkboxForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/checkboxSelectedForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/checkboxUnselectedForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/menuPinForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newCheckboxMarkerForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newRadioButtonMarkerForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowCloseForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowCloseOverForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMaximizeForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMaximizeOverForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMenuForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMenuPassiveForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMinimizeForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/newWindowMinimizeOverForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/radioButtonForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/radioButtonSelectedForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/windowClosePassiveForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/windowMaximizePassiveForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/forms/windowMinimizePassiveForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/growl - specific/growlBorderColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/growl - specific/growlDismissHandleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/growl - specific/growlFillColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/growl - specific/growlLabelColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/initialize-release/initialize.st
    A SublimishTheme.package/SublimishTheme.class/instance/initialize-release/initializeForms.st
    A SublimishTheme.package/SublimishTheme.class/instance/initialize-release/newRadioMarkerForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/label-styles/buttonLabelForText_.st
    A SublimishTheme.package/SublimishTheme.class/instance/label-styles/configureWindowLabelAreaFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/label-styles/createMenuBoxFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/label-styles/windowLabelForText_.st
    A SublimishTheme.package/SublimishTheme.class/instance/label-styles/windowMenuPassiveForm.st
    A SublimishTheme.package/SublimishTheme.class/instance/morph creation/newFocusIndicatorMorphFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousBaseColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousBasePassiveBackgroundColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousBaseSelectionColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousDarkBaseColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousLightColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousLightSelectionColorFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousNormalFillStyleFor_height_.st
    A SublimishTheme.package/SublimishTheme.class/instance/private/glamorousNormalFillStyleWithBaseColor_for_height_.st
    A SublimishTheme.package/SublimishTheme.class/instance/scrollbars/scrollBarButtonArrowVertices_.st
    A SublimishTheme.package/SublimishTheme.class/instance/watcher window/configureWatcherWindowLabelAreaFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/watcher window/watcherWindowActiveFillStyleFor_.st
    A SublimishTheme.package/SublimishTheme.class/instance/watcher window/watcherWindowInactiveFillStyleFor_.st
    M Tool-FileList.package/FileList.class/class/menu/contentMenu_.st

  Log Message:
  -----------
  60402
19728 Integrate Sublimish theme
        https://pharo.fogbugz.com/f/cases/19728

18460 FileLists "more..." menu item in preview panes context menu does not work
        https://pharo.fogbugz.com/f/cases/18460

http://files.pharo.org/image/60/60402.zip


Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] 986ba2: 60402

Sven Van Caekenberghe-2

On 20 Feb 2017, at 16:45, GitHub <[hidden email]> wrote:

19728 Integrate Sublimish theme
https://pharo.fogbugz.com/f/cases/19728

Very nice !

But does it also not need Spotter styling ? This looks odd:

Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] 986ba2: 60402

philippeback
I have fixed the spotter styling but need to get a 6.0 and move it there.

Inline image 1

On Mon, Feb 20, 2017 at 5:25 PM, Sven Van Caekenberghe <[hidden email]> wrote:

On 20 Feb 2017, at 16:45, GitHub <[hidden email]> wrote:

19728 Integrate Sublimish theme
https://pharo.fogbugz.com/f/cases/19728

Very nice !

But does it also not need Spotter styling ? This looks odd:


Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] 986ba2: 60402

Sven Van Caekenberghe-2
Thanks.

Not that it is a big deal, but the default background does not really match, but that might be taste as well.

> On 20 Feb 2017, at 17:41, [hidden email] wrote:
>
> I have fixed the spotter styling but need to get a 6.0 and move it there.
>
> <image.png>
>
> On Mon, Feb 20, 2017 at 5:25 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> On 20 Feb 2017, at 16:45, GitHub <[hidden email]> wrote:
>>
>> 19728 Integrate Sublimish theme
>> https://pharo.fogbugz.com/f/cases/19728
>
> Very nice !
>
> But does it also not need Spotter styling ? This looks odd:
>
> <Screen Shot 2017-02-20 at 17.23.27.png>
>


Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] 986ba2: 60402

philippeback
There are quite a few Themers + hard coded colors in GT.

Maybe someone from the GT team can pair for an hour or two with me so that we can get this done.

I can do this in the evening CET as I am pretty busy this week (managed to have Pharo a large part of my daily work now).

Phil

On Mon, Feb 20, 2017 at 6:54 PM, Sven Van Caekenberghe <[hidden email]> wrote:
Thanks.

Not that it is a big deal, but the default background does not really match, but that might be taste as well.

> On 20 Feb 2017, at 17:41, [hidden email] wrote:
>
> I have fixed the spotter styling but need to get a 6.0 and move it there.
>
> <image.png>
>
> On Mon, Feb 20, 2017 at 5:25 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> On 20 Feb 2017, at 16:45, GitHub <[hidden email]> wrote:
>>
>> 19728 Integrate Sublimish theme
>>      https://pharo.fogbugz.com/f/cases/19728
>
> Very nice !
>
> But does it also not need Spotter styling ? This looks odd:
>
> <Screen Shot 2017-02-20 at 17.23.27.png>
>



Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] 986ba2: 60402

Andrei Chis
Ping me in the evening when you have time. I might have some time but I'm not 100% sure.

Cheers,
Andrei

On Tue, Feb 21, 2017 at 7:47 AM, [hidden email] <[hidden email]> wrote:
There are quite a few Themers + hard coded colors in GT.

Maybe someone from the GT team can pair for an hour or two with me so that we can get this done.

I can do this in the evening CET as I am pretty busy this week (managed to have Pharo a large part of my daily work now).

Phil

On Mon, Feb 20, 2017 at 6:54 PM, Sven Van Caekenberghe <[hidden email]> wrote:
Thanks.

Not that it is a big deal, but the default background does not really match, but that might be taste as well.

> On 20 Feb 2017, at 17:41, [hidden email] wrote:
>
> I have fixed the spotter styling but need to get a 6.0 and move it there.
>
> <image.png>
>
> On Mon, Feb 20, 2017 at 5:25 PM, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> On 20 Feb 2017, at 16:45, GitHub <[hidden email]> wrote:
>>
>> 19728 Integrate Sublimish theme
>>      https://pharo.fogbugz.com/f/cases/19728
>
> Very nice !
>
> But does it also not need Spotter styling ? This looks odd:
>
> <Screen Shot 2017-02-20 at 17.23.27.png>
>