[pharo-project/pharo-core] a813b2: 60138

>    Branch: refs/heads/6.0
>    Home:   https://github.com/pharo-project/pharo-core
>    Commit: a813b2cc8d72ea3442e7ab1e9be5856203ea4c3f
>        https://github.com/pharo-project/pharo-core/commit/a813b2cc8d72ea3442e7ab1e9be5856203ea4c3f
>    Author: Jenkins Build Server <[hidden email]>
>    Date:   2016-07-06 (Wed, 06 Jul 2016)
>
>    Changed paths:
>      M ConfigurationOfGTEventRecorder.package/ConfigurationOfGTEventRecorder.class/instance/versions/version018_.st
>      M ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/symbolic versions/stable_.st
>      M ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/versions/version310_.st
>      A ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/versions/version311_.st
>      M ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/versions/version212_.st
>      M GT-BytecodeDebugger.package/extension/Context/instance/gtBytecodeDebuggerRetrieveContextValues.st
>      M GT-EventRecorder.package/GTEventPacking.class/instance/private/updateAnnouncement_for_.st
>      A GT-EventRecorder.package/GlobalIdentifier.class/class/class initialization/initialize.st
>      A GT-EventRecorder.package/GlobalIdentifier.class/class/system startup/startUp_.st
>      R GT-Inspector.package/GTExample.class/class/examples/gtExample.st
>      A GT-Inspector.package/GTExample.class/class/examples/gtExampleFromPragma.st
>      R GT-Inspector.package/GTExample.class/instance/pragma-selectors/afterClass_selector_arguments_.st
>      R GT-Inspector.package/GTExample.class/instance/pragma-selectors/afterFinishClass_selector_.st
>      R GT-Inspector.package/GTExample.class/instance/pragma-selectors/afterFinishClass_selector_arguments_.st
>      R GT-Inspector.package/GTExample.class/instance/pragma-selectors/afterFinish_.st
>      R GT-Inspector.package/GTExample.class/instance/pragma-selectors/after_arguments_.st
>      A GT-Inspector.package/GTExample.class/instance/public/signalableExceptions.st
>      M GT-Inspector.package/GTExampleEvaluator.class/README.md
>      M GT-Inspector.package/GTExampleEvaluator.class/definition.st
>      M GT-Inspector.package/GTExampleEvaluator.class/instance/initializing/initialize.st
>      R GT-Inspector.package/GTExampleEvaluator.class/instance/primitives/primitiveProcessExampleAfterFinish_.st
>      R GT-Inspector.package/GTExampleEvaluator.class/instance/primitives/primitiveProcessExampleAfter_.st
>      M GT-Inspector.package/GTExampleEvaluator.class/instance/primitives/primitiveProcessExample_withArguments_.st
>      A GT-Inspector.package/GTExampleEvaluator.class/instance/private/newResultFor_.st
>      A GT-Inspector.package/GTExampleEvaluator.class/instance/private/processAfter_.st
>      A GT-Inspector.package/GTExampleEvaluator.class/instance/private/processAfter_withResult_.st
>      M GT-Inspector.package/GTExampleEvaluator.class/instance/private/process_withArguments_.st
>      R GT-Inspector.package/GTExampleEvaluator.class/instance/private/withLinkContextFor_do_.st
>      M GT-Inspector.package/GTExampleEvaluator.class/instance/public/result.st
>      R GT-Inspector.package/GTExampleLinkContext.class/README.md
>      R GT-Inspector.package/GTExampleLinkContext.class/definition.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/accessing/example.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/accessing/example_.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/private/install.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/private/onLinkNode_arguments_.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/private/onLinkNode_at_put_.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/private/uninstall.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/private/withLinksDo_.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/public/arguments.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/public/do_.st
>      R GT-Inspector.package/GTExampleLinkContext.class/instance/testing/hasLinks.st
>      M GT-Inspector.package/GTExampleTestCase.class/instance/private/runExampleContainers_.st
>      A GT-Inspector.package/GTExampleTestCase.class/instance/private/runExample_.st
>      R GT-Inspector.package/GTExampleTestCase.class/instance/private/runExample_fromContainer_.st
>      M GT-Inspector.package/GTInspector.class/class/inspecting/inspectorExtendingMethods.st
>      M GT-Inspector.package/GTInspector.class/instance/building/compose.st
>      M GT-Inspector.package/GTInspectorHelp.class/class/accessing/pages.st
>      A GT-Inspector.package/extension/Class/instance/gtInspectorGTExamplesIn_.st
>      M GT-Inspector.package/extension/CompiledMethod/instance/gtExample.st
>      A GT-Inspector.package/extension/CompiledMethod/instance/gtExampleValue.st
>      A GT-Inspector.package/extension/CompiledMethod/instance/valueWithReceiver_possibleArguments_.st
>      M GT-Inspector.package/extension/ProtoObject/instance/gtInspectorPresentationsFromPragmas_In_inContext_.st
>      A GT-InspectorExtensions-Core.package/extension/MethodChunk/instance/gtDisplayOn_.st
>      A GT-InspectorExtensions-Core.package/extension/RBAbstractCondition/instance/gtInspectorChildren.st
>      A GT-InspectorExtensions-Core.package/extension/RBAbstractCondition/instance/gtInspectorTreeIn_.st
>      A GT-InspectorExtensions-Core.package/extension/RBConjunctiveCondition/instance/gtInspectorChildren.st
>      M GT-Spotter.package/GTSpotter.class/class/inspecting/spotterExtendingMethods.st
>      R GT-SpotterExtensions-Core.package/GTSelector.class/instance/ui/spotterSendersFor_.st
>      A GT-SpotterExtensions-Core.package/GTSelector.class/instance/ui/spotterUsersFor_.st
>      M GT-SpotterExtensions-Core.package/PragmaType.class/instance/accessing/pragmas.st
>      A GT-SpotterExtensions-Core.package/PragmaType.class/instance/accessing/users.st
>      M GT-SpotterExtensions-Core.package/PragmaType.class/instance/ui/gtInspectorPragmasIn_.st
>      A GT-SpotterExtensions-Core.package/PragmaType.class/instance/ui/gtInspectorUsersIn_.st
>      R GT-SpotterExtensions-Core.package/PragmaType.class/instance/ui/spotterSendersFor_.st
>      A GT-SpotterExtensions-Core.package/PragmaType.class/instance/ui/spotterUsersFor_.st
>      M GT-SpotterExtensions-Core.package/extension/MCWorkingCopy/class/gtExampleWorkingCopy.st
>      M GT-SpotterExtensions-Core.package/extension/MCWorkingCopy/instance/allAncestors.st
>      M GT-SpotterExtensions-Core.package/extension/MCWorkingCopy/instance/nextAncestors.st
>      M GT-SpotterExtensions-Core.package/extension/MCWorkingCopy/instance/spotterPackageFor_.st
>      M GT-SpotterExtensions-Core.package/extension/RPackage/instance/spotterMonticelloPackageFor_.st
>      M GT-SpotterExtensions-Core.package/extension/RPackage/instance/spotterMonticelloWorkingCopyFor_.st
>      M GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/private-navigation/pragmas_inPackages_.st
>      A GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/private-navigation/users_.st
>      A GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/private-navigation/users_inPackages_.st
>      M GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/tests/testProcessorForPragmasThenDiveIn.st
>      M Glamour-Core.package/GLMAction.class/definition.st
>      A Glamour-Core.package/GLMAction.class/instance/accessing/enabledCondition.st
>      A Glamour-Core.package/GLMAction.class/instance/accessing/enabledCondition_.st
>      A Glamour-Core.package/GLMAction.class/instance/testing/isEnabledOn_.st
>      A Glamour-Core.package/GLMPresentation.class/instance/scripting actions/selectionAct_entitled_enabledWhen_.st
>      M Glamour-Examples.package/GLMBasicExamples.class/instance/actions examples/staticAndDynamicMenu.st
>      M Glamour-Morphic-Renderer.package/GLMMorphicWidgetRenderer.class/instance/private/menuIn_for_.st
>      M Glamour-Morphic-Renderer.package/GLMMorphicWidgetRenderer.class/instance/private/moreToolbarActions_on_.st
>      M Glamour-Morphic-Widgets.package/GLMMorphicModel.class/instance/callbacks/menu_.st
>      M Glamour-Morphic-Widgets.package/GLMPopper.class/instance/private/updateWithString_from_.st
>      M Glamour-Morphic-Widgets.package/GLMPrintPopper.class/instance/public/openFromRubric_withResult_.st
>      M Glamour-Morphic-Widgets.package/GLMTreeMorphNodeModel.class/instance/menu/menu_shifted_.st
>      M PragmaCollector.package/PragmaCollector.class/instance/system changes/removedEventOccurs_.st
>      R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60137.st
>      A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60138.st
>      R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60137.st
>      A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60138.st
>      M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
>
>    Log Message:
>    -----------
>    60138
> Moose
>
> http://files.pharo.org/image/60/60138.zip
>
>

>> On 06 Jul 2016, at 18:16, stepharo <[hidden email]> wrote:
>>
>> I always found such kind of changes totally obscure and it would be nice to have a description.
>>
>
> Fixes issues:
>
> - 18450 GT-Tools: "Do not use #ifNotNilDo:ifNil:, #ifNil:ifNotNilDo:, #ifNotNilDo:"
> - 18453 GT-Tools: "do not use #ifEmpty:ifNotEmptyDo: #ifNotEmptyDo: #ifNotEmptyDo:ifEmpty:”
> - 18431 attach glmpopplers shortcut to the textarea instead of the scroll pane
> - Esteban's change to GLMAction
>
> This was mostly me pushing for getting the trivial things *DONE* and not wait another 3 weeks…

> On Thu, Jul 7, 2016 at 12:52 AM, Marcus Denker <[hidden email]> wrote:
>>> On 06 Jul 2016, at 18:16, stepharo <[hidden email]> wrote:
>>>
>>> I always found such kind of changes totally obscure and it would be nice to have a description.
>>>
>>
> The point I took from Stef's question is... not just getting a
> followup description here in the mail list, but could this text you've
> typed here....
>
>> Fixes issues:
>>
>> - 18450 GT-Tools: "Do not use #ifNotNilDo:ifNil:, #ifNil:ifNotNilDo:, #ifNotNilDo:"
>> - 18453 GT-Tools: "do not use #ifEmpty:ifNotEmptyDo: #ifNotEmptyDo: #ifNotEmptyDo:ifEmpty:”
>> - 18431 attach glmpopplers shortcut to the textarea instead of the scroll pane
>> - Esteban's change to GLMAction
> ...in future be added as the Log message instead of just "Moose" so
> there is a permanent record in our package history.
>
>> This was mostly me pushing for getting the trivial things *DONE* and not wait another 3 weeks…
>>
>> (I should have just committed slices, the overhead with committing and syncing is to high for
>> trivial refactorings)
> Sure, buts lets document this. Since anyway we'll just ask for a
> followup in the mail list ;) and I presume it takes more effort to go
> back and look these up after the fact, than copy-pasting at
> integration time.
>
> cheers -ben
>>          Marcus
> P.S.  Not to take your efforts doing the integrations for granted,
> thanks for regularly doing this task.
>
>