[pharo-project/pharo-core] bb7382: 60072

  Branch: refs/heads/6.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: bb73827748efad1f9fa06147e7c90c49149eec05
      https://github.com/pharo-project/pharo-core/commit/bb73827748efad1f9fa06147e7c90c49149eec05
  Author: Jenkins Build Server <[hidden email]>
  Date:   2016-06-08 (Wed, 08 Jun 2016)

  Changed paths:
    M ConfigurationOfVersionner.package/ConfigurationOfVersionner.class/instance/symbolic versions/stable_.st
    A ConfigurationOfVersionner.package/ConfigurationOfVersionner.class/instance/versions/version21314_.st
    M FileSystem-Disk.package/FileHandle.class/instance/streams-compatibility/binaryReadStream.st
    M FuelPlatform.package/FLPharo11Platform.class/class/private-extensions-methodcontext/tempNamed_.st
    M Jobs.package/Job.class/instance/private/prepareForRunning.st
    M Metacello-Core.package/MetacelloProjectRegistration.class/instance/accessing/currentVersionString.st
    M Metacello-Core.package/MetacelloProjectRegistration.class/instance/accessing/merge_.st
    M Monticello.package/MCPackage.class/instance/testing/isDirty.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60071.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60072.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60071.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60072.st
    M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
    M Slot-Tests.package/SlotErrorsTest.class/instance/tests/testDangerousClassesConditions.st
    M Slot-Tests.package/SlotErrorsTest.class/instance/tests/testDangerousClassesEnabling.st
    M Slot.package/DangerousClassNotifier.class/class/accessing/shouldNotBeRedefined_.st
    M Slot.package/DangerousClassNotifier.class/class/accessing/tooDangerousClasses.st
    M Slot.package/DangerousClassNotifier.class/class/validation/check_.st

  Log Message:
  -----------
  60072
18451 Do not use #ifNotNilDo:ifNil:,  #ifNil:ifNotNilDo:, #ifNotNilDo:
        https://pharo.fogbugz.com/f/cases/18451

18443 update Versionner configuration to 2.13.14
        https://pharo.fogbugz.com/f/cases/18443

18433 Simplify DangerousClassNotifier logic
        https://pharo.fogbugz.com/f/cases/18433

http://files.pharo.org/image/60/60072.zip

>    60072
> 18451 Do not use #ifNotNilDo:ifNil:,  #ifNil:ifNotNilDo:, #ifNotNilDo:
> https://pharo.fogbugz.com/f/cases/18451
>
>

Is there a rule for such case?

Stef

Indeed, there are!

RBRuleIfNotEmptyDo
RBRuleIfNotNilDo

Added in Pharo5, so we can deprecate these methods in Pharo6.

(Maybe we can use them as a reason to add the “automatic rewrite deprecation”
in Pharo6… with the idea that it says “this is departed, but I can fix it for you”.
At runtime we can do that with 100% correctness.)

        Marcus

Le 9/6/16 à 09:04, Marcus Denker a écrit :
Excellent!