[pharo-project/pharo-core] c3cfac: 50226

  Branch: refs/heads/5.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: c3cfac65acd27c4e50a84d78a03ace6e6a253ad1
      https://github.com/pharo-project/pharo-core/commit/c3cfac65acd27c4e50a84d78a03ace6e6a253ad1
  Author: Jenkins Build Server <[hidden email]>
  Date:   2015-08-13 (Thu, 13 Aug 2015)

  Changed paths:
    A FileSystem-Disk.package/ManifestFileSystemDisk.class/README.md
    A FileSystem-Disk.package/ManifestFileSystemDisk.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A FileSystem-Disk.package/ManifestFileSystemDisk.class/definition.st
    A Graphics-Display Objects.package/ManifestGraphicsDisplayObjects.class/README.md
    A Graphics-Display Objects.package/ManifestGraphicsDisplayObjects.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A Graphics-Display Objects.package/ManifestGraphicsDisplayObjects.class/definition.st
    R Graphics-Resources.package/extension/ThemeIcons/instance/commentsIconContents.st
    R Graphics-Resources.package/extension/ThemeIcons/instance/hierarchyIconContents.st
    A Multilingual-Languages.package/ManifestMultilingualLanguages.class/README.md
    A Multilingual-Languages.package/ManifestMultilingualLanguages.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A Multilingual-Languages.package/ManifestMultilingualLanguages.class/definition.st
    A Multilingual-TextConverterOtherLanguages.package/ManifestMultilingualTextConverterOtherLanguages.class/README.md
    A Multilingual-TextConverterOtherLanguages.package/ManifestMultilingualTextConverterOtherLanguages.class/definition.st
    M Nautilus.package/AbstractNautilusUI.class/instance/build ui/buildButtonsBar.st
    M Nautilus.package/AbstractNautilusUI.class/instance/build ui/buildColumns_height_.st
    A NonInteractiveTranscript.package/ManifestNonInteractiveTranscript.class/README.md
    A NonInteractiveTranscript.package/ManifestNonInteractiveTranscript.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A NonInteractiveTranscript.package/ManifestNonInteractiveTranscript.class/definition.st
    A Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/nautilus/commentsIcon.st
    A Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/nautilus/hierarchyIcon.st
    A Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/private - contents/commentsIconContents.st
    A Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/private - contents/hierarchyIconContents.st
    A Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/private - contents/smallHierarchyBrowserIconContents.st
    R Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/private - notused/smallHiararchyBrowserIconContents.st
    R Polymorph-Widgets.package/EclipseUIThemeIcons.class/instance/private/smallHierarchyBrowserIconContents.st
    M Polymorph-Widgets.package/ThemeIcons.class/instance/accessing - icons/commentsIcon.st
    A Polymorph-Widgets.package/ThemeIcons.class/instance/accessing - icons/hierarchyIcon.st
    R Polymorph-Widgets.package/ThemeIcons.class/instance/private - icons/hierarchyIcon.st
    A Ring-Core-Kernel.package/ManifestRingCoreKernel.class/README.md
    A Ring-Core-Kernel.package/ManifestRingCoreKernel.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A Ring-Core-Kernel.package/ManifestRingCoreKernel.class/definition.st
    A Ring-Monticello.package/ManifestRingMonticello.class/README.md
    A Ring-Monticello.package/ManifestRingMonticello.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A Ring-Monticello.package/ManifestRingMonticello.class/definition.st
    A SUnit-Core.package/ManifestSUnitCore.class/README.md
    A SUnit-Core.package/ManifestSUnitCore.class/definition.st
    R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50225.st
    A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50226.st
    R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50225.st
    A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50226.st
    M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
    A Slot-Tests.package/SlotAnnouncementsTest.class/instance/tests-comments/testCreateAndChangeWithCommentDoesAnnounceBoth.st
    M Slot-Tests.package/SlotAnnouncementsTest.class/instance/tests-comments/testCreateWithCommentDoesAnnounce.st
    M System-Announcements.package/ClassCommented.class/instance/accessing/oldStamp.st
    A Text-Scanning.package/ManifestTextScanning.class/README.md
    A Text-Scanning.package/ManifestTextScanning.class/definition.st
    A Tool-Diff.package/ManifestToolDiff.class/README.md
    A Tool-Diff.package/ManifestToolDiff.class/definition.st
    A Tool-ExternalBrowser.package/ManifestToolExternalBrowser.class/README.md
    A Tool-ExternalBrowser.package/ManifestToolExternalBrowser.class/definition.st
    M Traits.package/TClassDescription.class/instance/filein%2Fout/classComment_stamp_.st
    A Unicode-Initialization.package/ManifestUnicodeInitialization.class/README.md
    A Unicode-Initialization.package/ManifestUnicodeInitialization.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st
    A Unicode-Initialization.package/ManifestUnicodeInitialization.class/definition.st
    A UserManager-Core.package/ManifestUserManagerCore.class/README.md
    A UserManager-Core.package/ManifestUserManagerCore.class/definition.st

  Log Message:
  -----------
  50226
16183 Clean up class comment implementation
        https://pharo.fogbugz.com/f/cases/16183

16181 Better unifying of the columns width in Nautilus
        https://pharo.fogbugz.com/f/cases/16181

16182  Add Manifests for the bootstrap (part 2)
        https://pharo.fogbugz.com/f/cases/16182

16178 new nautilus icons (for class side, hierarchy, etc) are defined in wrong class
        https://pharo.fogbugz.com/f/cases/16178

http://files.pharo.org/image/50/50226.zip

Le 13/8/15 17:17, GitHub a écrit :
> 16181 Better unifying of the columns width in Nautilus
> https://pharo.fogbugz.com/f/cases/16181
I do not see why having the exact same column width is good.
I personnally do not use long protocol names and I prefer to see
the method name.

Stef

visual impact.
they have to be the same or your eyes will bleed.

some days ago I pasted a link with a small explanation about (http://web.cs.wpi.edu/~matt/courses/cs563/talks/smartin/int_design.html), and there are tons of books that talk about that stuff… along with the book I recommended ("do not make me think”) this days I’m also reading “About Face, the essentials of Interaction Design”… is good lecture (a bit long) and provides good insights about UI design.
Human mind decode certain things as beauty (harmony, symmetry, regularity, etc.) and others as ugly (dissonance, etc.)… if you put irregular sizes in your panels, no matter how functionally good is your tool, it will look ugly and people will see it as ugly.
"It does not just have to be better, it also has to look better"

That’s why I asked Frank to at least group panels in package-class then protocol-method to see if it improves by creating a regularity, and it looks already better (but still not perfect… would be better all same size, but well… since conceptually first two panes can be grouped and last two panes too, it can pass).

Esteban