[pharo-project/pharo-core] d87de4: 60237

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[pharo-project/pharo-core] d87de4: 60237

Eliot Miranda-3
  Branch: refs/heads/6.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: d87de481a22f9fdc663f44726cd6e9f2fede217a
      https://github.com/pharo-project/pharo-core/commit/d87de481a22f9fdc663f44726cd6e9f2fede217a
  Author: Jenkins Build Server <[hidden email]>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/versions/version32_.st
    M ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/versions/version320_.st
    M ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/versions/version316_.st
    M ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/versions/version217_.st
    M ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/versions/version328_.st
    M ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/symbolic versions/stable_.st
    A ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/versions/version422_.st
    A GT-Debugger.package/ManifestGTDebugger.class/README.md
    A GT-Debugger.package/ManifestGTDebugger.class/class/unloading/preUnload.st
    A GT-Debugger.package/ManifestGTDebugger.class/definition.st
    M GT-Playground.package/GTPlayground.class/instance/building/compose.st
    R Glamour-Morphic-Brick.package/GLMBrick.class/instance/brick-structure-testing/isLastInOwner.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60236.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60237.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60236.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60237.st
    M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st

  Log Message:
  -----------
  60237
Moose

http://files.pharo.org/image/60/60237.zip


Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] d87de4: 60237

Marcus Denker-4

>
>  Log Message:
>  -----------
>  60237
> Moose
>
> http://files.pharo.org/image/60/60237.zip
>
>

This is:

- case 19032
- testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits was failing due to #isLastInOwner
- add manifest wit preUnload action in GTDebugger

But:

=> 19032 seems to be not fixed. (there is still a sender if #ifNotNilDo:)

=> the gt problem with testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits was fixed, but in the meantime
     we got more problems (from epicea). This is a nice example how not fixing a trivial bug leads to more decay fast
     that we do not even know about. “yes, that test fails and I know why. Will be fixed when we merge”.  
     What happens instead is that this “known failure” will fail soon due to many more other reasons… that nobody is
     even aware of.

Trivial is not trivial.. that is why one needs to fix them as soon as possible and *never* think that batching trivialities is
a good idea…

        Marcus
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo-core] d87de4: 60237

Marcus Denker-4

> On 23 Sep 2016, at 11:34, Marcus Denker <[hidden email]> wrote:
>
>
>>
>> Log Message:
>> -----------
>> 60237
>> Moose
>>
>> http://files.pharo.org/image/60/60237.zip
>>
>>
>
> This is:
>
> - case 19032
> - testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits was failing due to #isLastInOwner
> - add manifest wit preUnload action in GTDebugger
>
> But:
>
> => 19032 seems to be not fixed. (there is still a sender if #ifNotNilDo:)
>
> => the gt problem with testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits was fixed, but in the meantime
>     we got more problems (from epicea). This is a nice example how not fixing a trivial bug leads to more decay fast
>     that we do not even know about. “yes, that test fails and I know why. Will be fixed when we merge”.  
>     What happens instead is that this “known failure” will fail soon due to many more other reasons… that nobody is
>     even aware of.
>
> Trivial is not trivial.. that is why one needs to fix them as soon as possible and *never* think that batching trivialities is
> a good idea…
>

Issue tracker entries are updated. (closed / edited so reflect what is left to be done)

        Marcus