[pharo-project/pharo-core] e64121: 60202

  Branch: refs/heads/6.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: e641210bd1705920c482de8b77d611cd3460434a
      https://github.com/pharo-project/pharo-core/commit/e641210bd1705920c482de8b77d611cd3460434a
  Author: Jenkins Build Server <[hidden email]>
  Date:   2016-09-04 (Sun, 04 Sep 2016)

  Changed paths:
    M Athens-Examples.package/AthensSurfaceExamples.class/class/examples/exampleDrawForm2.st
    M Athens-Examples.package/AthensSurfaceExamples.class/definition.st
    M FreeType.package/FreeTypeSystemSettings.class/class/settings/freeTypeSettingsOn_.st
    M FreeType.package/FreeTypeSystemSettings.class/definition.st
    M HelpSystem-Core.package/ClassAPIHelpBuilder.class/instance/building/build.st
    M HelpSystem-Core.package/CustomHelp.class/class/accessing/icon.st
    M HelpSystem-Core.package/CustomHelp.class/definition.st
    M HelpSystem-Core.package/HelpBrowser.class/class/icons/taskbarIcon.st
    M HelpSystem-Core.package/HelpBrowser.class/class/ui/menuOn_.st
    M HelpSystem-Core.package/HelpBrowser.class/class/world menu/menuCommandOn_.st
    M HelpSystem-Core.package/HelpBrowser.class/definition.st
    M HelpSystem-Core.package/HelpBuilder.class/definition.st
    M Komitter.package/KomitClassNode.class/class/icons/addedClassIcon.st
    M Komitter.package/KomitClassNode.class/class/icons/defaultClassIcon.st
    M Komitter.package/KomitClassNode.class/class/icons/deletedClassIcon.st
    M Komitter.package/KomitClassNode.class/class/icons/modifiedClassIcon.st
    M Komitter.package/KomitterUI.class/class/icons/historyIcon.st
    M Nautilus.package/AbstractNautilusUI.class/instance/icon/packageIconFor_.st
    M Nautilus.package/CategoryWidget.class/class/menus/categoriesMenu_.st
    M Nautilus.package/MethodOveridesAction.class/instance/order/privateActionIcon.st
    M Nautilus.package/MethodOveridesAction.class/instance/private/buildUpAndDownArrowIcon_.st
    M Nautilus.package/MethodWidget.class/class/menu/elementsMenu_.st
    A NautilusRefactoring.package/extension/ClassDescription/instance/iconNamed_.st
    M NautilusRefactoring.package/extension/ClassDescription/instance/instVarRefactoring_.st
    M NautilusRefactoring.package/extension/ClassDescription/instance/refactoringSubmenu_.st
    M NautilusRefactoring.package/extension/ClassDescription/instance/varRefactoringSubMenu_.st
    M Refactoring-Help.package/RBClassesHelp.class/class/building/buildClassHierarchyHelpFrom_.st
    M Refactoring-Help.package/RBClassesHelp.class/definition.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60201.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60202.st
    R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60201.st
    A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60202.st
    M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
    M Settings-Graphics.package/GraphicFontSettings.class/class/fonts/resetAllFontToDefaultButton.st
    M Settings-Graphics.package/GraphicFontSettings.class/definition.st
    M Spec-Debugger.package/SpecDebugger.class/class/icons/taskbarIcon.st
    M Spec-Inspector.package/EyeAbstractInspector.class/class/accessing/taskbarIcon.st
    M Spec-Tools.package/DualChangeSorterApplication.class/class/icons/taskbarIcon.st
    M Spec-Tools.package/KeymapBrowser.class/class/accessing/taskbarIcon.st
    M Tool-Catalog.package/CatalogBrowser.class/class/utilities/iconFor_.st
    M Tool-Catalog.package/CatalogBrowser.class/class/world menu/menuCommandOn_.st
    M Tool-Catalog.package/CatalogBrowser.class/definition.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/Nautilus groups support/installAndCreateGroupButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/building/refreshButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/defineAllRepositoriesInMCBrowserButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/defineCurrentVersionRepositoryButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/installStableVersionButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/installStableVersionMenuItem_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/loadConfigurationButton_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/menu/loadConfigurationMenuItem_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/private - utilities/buildContextMenuOn_.st
    M Tool-Catalog.package/CatalogBrowser.class/instance/private - utilities/buildMenuOn_.st
    M Tool-CriticBrowser.package/CriticBrowser.class/class/menu/icon.st
    M Tool-DependencyAnalyser-UI.package/DAPackageDependenciesWelcome.class/class/world menu/menuCommandOn_.st
    M Tool-FileList.package/FileList.class/class/icons/taskbarIcon.st
    R Tool-FileList.package/FileList.class/class/menu/iconNamed_.st
    M Tool-Finder.package/FinderUI.class/class/icons/icon.st

  Log Message:
  -----------
  60202
19001 Another pass to introduce iconNamed: and avoid Smalltalk ui icons
        https://pharo.fogbugz.com/f/cases/19001

19002 iconNamed: in Catalog Browser
        https://pharo.fogbugz.com/f/cases/19002

http://files.pharo.org/image/60/60202.zip

GitHub wrote

19001 Another pass to introduce iconNamed: and avoid Smalltalk ui icons
        https://pharo.fogbugz.com/f/cases/19001

This one surprised me. I thought we were trying to avoid extensions to low-level classes when possible. How is icon retrieval a responsibility of ClassDescription?! I'm all about convenience, but not getting this change. Was there a discussion somewhere? What benefits am I missing?

Sean

this is like that since years.

Stef


Le 4/9/16 à 20:06, Sean P. DeNigris a écrit :