problem with find & replace in PharoCore 1.2

Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :

First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.

thanks Mariano,

Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent
Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;)
I should do that when I change the method I guess, or when I press cancel.

the orange color is for the current searched text which is updated while you are typing some text in the find field.
It is the same when you select some text and cmd-h.
so I can set the search text to empty string if one cancel the find & replace.
is it what you want ?
notice that you can do that with cmd-h with nothing selected in the current text morph.

Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.

sorry, I don't really understand.
You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?

Cheers
Alain

Thanks

mariano

Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :

First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.

thanks Mariano,

Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent
Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;)
I should do that when I change the method I guess, or when I press cancel.

the orange color is for the current searched text which is updated while you are typing some text in the find field.
It is the same when you select some text and cmd-h.
so I can set the search text to empty string if one cancel the find & replace.
is it what you want ?

notice that you can do that with cmd-h with nothing selected in the current text morph.

Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.

sorry, I don't really understand.
You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?

Cheers
Alain

Thanks

mariano

Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.

ok, you just want a normal window top bar with a red button for the find & replace dialog, that it ?

alain

On Thu, Dec 2, 2010 at 5:53 PM, Alain Plantec <[hidden email]> wrote:

Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :

First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.

thanks Mariano,

Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent
Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;)
I should do that when I change the method I guess, or when I press cancel.

the orange color is for the current searched text which is updated while you are typing some text in the find field.
It is the same when you select some text and cmd-h.
so I can set the search text to empty string if one cancel the find & replace.
is it what you want ?
notice that you can do that with cmd-h with nothing selected in the current text morph.

imho setting search text to empty string in any other context different that the place you did the search would be the best

As an example if i search for "self" browsing a method even if after i open an Inspector i can see  "self" highlighted

Cheers,

Francisco

 

Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.

sorry, I don't really understand.
You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?

Cheers
Alain

Thanks

mariano

I guess so. What I mean is....when the find/replace finished instead???  my problem is that even closing the popup it continues putting colors...so...until when? forever?

click on the text (empty selection, visible caret), then cmd-h