rb broken in dev 10495
Locked
 
|
Hi,
The refactorings are broken in the dev image 10495. I opened a ticket: http://code.google.com/p/pharo/issues/detail?id=1451 Cheers, Doru -- www.tudorgirba.com "No matter how many recipes we know, we still value a chef." _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
I cannot reproduce this using the RB tests and in the default OB
loaded into a Pharo-Core image. RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and OB-Regex are dirty packages. There are numerous overrides that subtly break these packages. The menus of OB are messed up too. What browser are you using? What menu item are you using? In Pharo-Dev I have 3 different rename menus :-/ Lukas 2009/11/16 Tudor Girba <[hidden email]>: > Hi, > > The refactorings are broken in the dev image 10495. I opened a ticket: > http://code.google.com/p/pharo/issues/detail?id=1451 > > Cheers, > Doru > > > -- > www.tudorgirba.com > > "No matter how many recipes we know, we still value a chef." > > > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
I used the "refactor class/rename" menu entry.
I noticed the problem first in the PackageBrowser, and then reproduced it in the OBSystemBrowser. Cheers, Doru On 16 Nov 2009, at 10:13, Lukas Renggli wrote: > I cannot reproduce this using the RB tests and in the default OB > loaded into a Pharo-Core image. > > RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and > OB-Regex are dirty packages. There are numerous overrides that subtly > break these packages. The menus of OB are messed up too. > > What browser are you using? What menu item are you using? In Pharo-Dev > I have 3 different rename menus :-/ > > Lukas > > 2009/11/16 Tudor Girba <[hidden email]>: >> Hi, >> >> The refactorings are broken in the dev image 10495. I opened a >> ticket: >> http://code.google.com/p/pharo/issues/detail?id=1451 >> >> Cheers, >> Doru >> >> >> -- >> www.tudorgirba.com >> >> "No matter how many recipes we know, we still value a chef." >> >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "The coherence of a trip is given by the clearness of the goal." _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Indeed, that looks like a bug in the parser of the RB. Can you send me
the code of MooseBrowsers>>codeBrowser Lukas 2009/11/16 Tudor Girba <[hidden email]>: > I used the "refactor class/rename" menu entry. > > I noticed the problem first in the PackageBrowser, and then reproduced > it in the OBSystemBrowser. > > Cheers, > Doru > > > On 16 Nov 2009, at 10:13, Lukas Renggli wrote: > >> I cannot reproduce this using the RB tests and in the default OB >> loaded into a Pharo-Core image. >> >> RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and >> OB-Regex are dirty packages. There are numerous overrides that subtly >> break these packages. The menus of OB are messed up too. >> >> What browser are you using? What menu item are you using? In Pharo-Dev >> I have 3 different rename menus :-/ >> >> Lukas >> >> 2009/11/16 Tudor Girba <[hidden email]>: >>> Hi, >>> >>> The refactorings are broken in the dev image 10495. I opened a >>> ticket: >>> http://code.google.com/p/pharo/issues/detail?id=1451 >>> >>> Cheers, >>> Doru >>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "No matter how many recipes we know, we still value a chef." >>> >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > www.tudorgirba.com > > "The coherence of a trip is given by the clearness of the goal." > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Hi Lukas,
I listed it below: codeBrowser | browser | browser := GLMTableLayoutBrowser new. browser row: #navigation; row: #details. browser showOn: #navigation; using: [ browser custom: self codeNavigator ]. browser showOn: #details; from: #navigation->#class; from: #navigation->#method; using: [ browser text display: [:cls | cls sourceText]; useExplicitNotNil; when: [:cls :method | cls notNil and: [method isNil] ]. browser text display: [:cls :method | method sourceText] ]. browser sendToOutside: #namespace from: #navigation->#namespace. browser sendToOutside: #class from: #navigation->#classe. browser sendToOutside: #method from: #navigation->#method. browser sendTo: ##navigation->#namespaceToSelect fromOutside: #namespaceToSelect. browser sendTo: ##navigation->#classToSelect fromOutside: #classToSelect. browser sendTo: ##navigation->#methodToSelect fromOutside: #methodToSelect. ^ browser Cheers, Doru On 16 Nov 2009, at 12:01, Lukas Renggli wrote: > Indeed, that looks like a bug in the parser of the RB. Can you send me > the code of > > MooseBrowsers>>codeBrowser > > Lukas > > > 2009/11/16 Tudor Girba <[hidden email]>: >> I used the "refactor class/rename" menu entry. >> >> I noticed the problem first in the PackageBrowser, and then >> reproduced >> it in the OBSystemBrowser. >> >> Cheers, >> Doru >> >> >> On 16 Nov 2009, at 10:13, Lukas Renggli wrote: >> >>> I cannot reproduce this using the RB tests and in the default OB >>> loaded into a Pharo-Core image. >>> >>> RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and >>> OB-Regex are dirty packages. There are numerous overrides that >>> subtly >>> break these packages. The menus of OB are messed up too. >>> >>> What browser are you using? What menu item are you using? In Pharo- >>> Dev >>> I have 3 different rename menus :-/ >>> >>> Lukas >>> >>> 2009/11/16 Tudor Girba <[hidden email]>: >>>> Hi, >>>> >>>> The refactorings are broken in the dev image 10495. I opened a >>>> ticket: >>>> http://code.google.com/p/pharo/issues/detail?id=1451 >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "No matter how many recipes we know, we still value a chef." >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> >>> -- >>> Lukas Renggli >>> http://www.lukas-renggli.ch >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> -- >> www.tudorgirba.com >> >> "The coherence of a trip is given by the clearness of the goal." >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "Next time you see your life passing by, say 'hi' and get to know her." _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
I also have a problem I think in relation.
The error comes from: RBMessageNode>>primitiveNode ^ primitiveNode ifNil: [PrimitiveNode null].
There are no PrimitivieNode in the dev image. hth, Cédrick _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Tudor Girba
> browser sendTo: ##navigation->#namespaceToSelect fromOutside:
> #namespaceToSelect. > browser sendTo: ##navigation->#classToSelect fromOutside: > #classToSelect. > browser sendTo: ##navigation->#methodToSelect fromOutside: > #methodToSelect. ##navigation is not really valid Smalltalk. I don't know why the Pharo Compiler accepts that. I can change the refactoring browser to also accept that, but it looks strange to me. -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by cedreek
Unlikely. I don't have that message in my image. Please update.
Lukas 2009/11/16 Cédrick Béler <[hidden email]>: > I also have a problem I think in relation. > The error comes from: > RBMessageNode>>primitiveNode > ^ primitiveNode ifNil: [PrimitiveNode null]. > > There are no PrimitivieNode in the dev image. > hth, > Cédrick > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Lukas Renggli
I fixed RBParser so that it properly accepts degraded Pharo code:
Name: AST-Core-lr.23 Author: lr Time: 16 November 2009, 1:53:36 pm UUID: 0f649dde-0cb4-4552-8d70-f4f782339af3 Ancestors: AST-Core-lr.22 - fixed RBScanner so that it properly parses degraded literals such as # foo -> #foo ##foo -> #foo ### ##foo -> #foo This fixes also the last problem parsing the complete image. An utterly strange example of deformed Smalltalk can be found in the core image at: MirrorPrimitiveTests>>testMirrorPerform (has spaces between # and the symbol) Lukas 2009/11/16 Lukas Renggli <[hidden email]>: >> browser sendTo: ##navigation->#namespaceToSelect fromOutside: >> #namespaceToSelect. >> browser sendTo: ##navigation->#classToSelect fromOutside: >> #classToSelect. >> browser sendTo: ##navigation->#methodToSelect fromOutside: >> #methodToSelect. > > ##navigation is not really valid Smalltalk. I don't know why the Pharo > Compiler accepts that. I can change the refactoring browser to also > accept that, but it looks strange to me. > > -- > Lukas Renggli > http://www.lukas-renggli.ch > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Lukas Renggli
may be we should avoid ##
because I think that this is not smalltalk (did not check the standard). and I do not see an usage for now. Stef On Nov 16, 2009, at 1:34 PM, Lukas Renggli wrote: >> browser sendTo: ##navigation->#namespaceToSelect fromOutside: >> #namespaceToSelect. >> browser sendTo: ##navigation->#classToSelect fromOutside: >> #classToSelect. >> browser sendTo: ##navigation->#methodToSelect fromOutside: >> #methodToSelect. > > ##navigation is not really valid Smalltalk. I don't know why the Pharo > Compiler accepts that. I can change the refactoring browser to also > accept that, but it looks strange to me. > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Lukas Renggli
On Mon, Nov 16, 2009 at 10:13 AM, Lukas Renggli <[hidden email]> wrote:
> RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and > OB-Regex are dirty packages. There are numerous overrides that subtly > break these packages. The menus of OB are messed up too. can this be related to O2? -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Stéphane Ducasse
Hi,
Indeed, this was actually a mistake in the code. But either the parser does not allow me to enter it, or the tools should not break. Cheers, Doru On 16 Nov 2009, at 13:57, Stéphane Ducasse wrote: > may be we should avoid ## > because I think that this is not smalltalk (did not check the > standard). > and I do not see an usage for now. > > Stef > > On Nov 16, 2009, at 1:34 PM, Lukas Renggli wrote: > >>> browser sendTo: ##navigation->#namespaceToSelect fromOutside: >>> #namespaceToSelect. >>> browser sendTo: ##navigation->#classToSelect fromOutside: >>> #classToSelect. >>> browser sendTo: ##navigation->#methodToSelect fromOutside: >>> #methodToSelect. >> >> ##navigation is not really valid Smalltalk. I don't know why the >> Pharo >> Compiler accepts that. I can change the refactoring browser to also >> accept that, but it looks strange to me. >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "Not knowing how to do something is not an argument for how it cannot be done." _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Stéphane Ducasse
> may be we should avoid ##
In Dolphin Smalltalk ## it is used as a prefix for compile time expressions. Putting spaces (or even comments) between the #-character and the symbol/array/bytearray is accepted in some other Smalltalk dialects too, but I still think it is bad style. > because I think that this is not smalltalk (did not check the standard). > and I do not see an usage for now. The Smalltalk standard has a very restrictive syntax. The Pharo compiler is very permissive. For example it allows an arbitrary number of statement separators, something that no other Smalltalk allows. Lukas -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Tudor Girba
> Indeed, this was actually a mistake in the code. But either the parser
> does not allow me to enter it, or the tools should not break. Yeah, it caused a bug in the parser, but that is fixed now. Lukas -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Lukas Renggli
On Nov 16, 2009, at 3:10 PM, Lukas Renggli wrote: >> may be we should avoid ## > > In Dolphin Smalltalk ## it is used as a prefix for compile time expressions. > > Putting spaces (or even comments) between the #-character and the > symbol/array/bytearray is accepted in some other Smalltalk dialects > too, but I still think it is bad style. yes I think that we should keep ## if one day we need something special. >> because I think that this is not smalltalk (did not check the standard) >> and I do not see an usage for now. > > The Smalltalk standard has a very restrictive syntax. The Pharo > compiler is very permissive. For example it allows an arbitrary number > of statement separators, something that no other Smalltalk allows. you mean . . . I would really make it less permissive because these are variations with no value. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |