Smalltalk › Pharo › Pharo Smalltalk Developers

remove MczInstaller?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

tinchodias

remove MczInstaller?

Hi,

Does somebody use MczInstaller to load Monticello files? The only users in the image are it's tests.

The class comment states: "

An installer for Monticello files with the *.mcz extension.

MczInstaller installFileNamed: 'MyKillerApp-Core-Author.1.mcz'

Martín

stepharo

Re: remove MczInstaller?

Hi martin

how MCZ are then read?

Stef

Le 4/9/15 15:18, Martin Dias a écrit :

> Hi,
>
> Does somebody use MczInstaller to load Monticello files? The only
> users in the image are it's tests.
>
> The class comment states: "
> An installer for Monticello files with the *.mcz extension.
>
> MczInstaller installFileNamed: 'MyKillerApp-Core-Author.1.mcz'
> "
>
> Martín

stepharo

Re: remove MczInstaller?

In reply to this post by tinchodias

Are you sure that it is not used when we drag an MCZ on the desktop?
right now it is not working and we should address it (probably because
we removed the duplication two copies of registration in different
classes and we introduced
a pragma).

Le 4/9/15 15:18, Martin Dias a écrit :

stepharo

Re: remove MczInstaller?

In reply to this post by tinchodias

When I drop an mcz file , in pharo 40 we got

and in Pharo 50

Le 4/9/15 15:18, Martin Dias a écrit :

Hi,

Does somebody use MczInstaller to load Monticello files? The only users in the image are it's tests.

The class comment states: "

An installer for Monticello files with the *.mcz extension.

MczInstaller installFileNamed: 'MyKillerApp-Core-Author.1.mcz'

"

Martín

Marcus Denker-4

Re: remove MczInstaller?

In reply to this post by stepharo

> On 05 Sep 2015, at 15:54, stepharo <[hidden email]> wrote:
>
> Are you sure that it is not used when we drag an MCZ on the desktop?

No, at least I do not think so.

it’s the installer that was added to Squeak before Monticello. The idea is that it can be used
to install .mzc files even when Monticello is not there.

I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep.
(to load monticello).

Marcus

tinchodias

Re: remove MczInstaller?

Hi,

I logged for which classes MCVersionReader >>
fileReaderServicesForFile:suffix: is invoked:

In Pharo 4:

MCVersionReader class
MCMczReader class
MCMcmReader class
MCMcdReader class

In Pharo 5:

MCVersionReader class

and it should be MCMczReader who adds those services for the MCZ files.

Note: I tried in Pharo 4, and the list of file services didn't change
after removing MczInstaller.

Martín

On Sat, Sep 5, 2015 at 6:24 PM, Marcus Denker <[hidden email]> wrote:

>
>> On 05 Sep 2015, at 15:54, stepharo <[hidden email]> wrote:
>>
>> Are you sure that it is not used when we drag an MCZ on the desktop?
>
> No, at least I do not think so.
>
> it’s the installer that was added to Squeak before Monticello. The idea is that it can be used
> to install .mzc files even when Monticello is not there.
>
> I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep.
> (to load monticello).
>
> Marcus
>
>
>

tinchodias

Re: remove MczInstaller?

On Sat, Sep 5, 2015 at 7:00 PM, Martin Dias <[hidden email]> wrote:

I sent this email because I was starting to update the change of this method:

useNewChangeSetDuring: aBlock

| changeHolder oldChanges newChanges |

changeHolder := (ChangeSet respondsTo: #newChanges:)

ifTrue: [ChangeSet]

ifFalse: [Smalltalk].

oldChanges := (ChangeSet respondsTo: #current)

ifTrue: [ChangeSet current]

ifFalse: [Smalltalk changes].

newChanges := ChangeSet new name: (ChangeSet uniqueNameLike: self extractPackageName).

changeHolder newChanges: newChanges.

[aBlock value] ensure: [changeHolder newChanges: oldChanges].

to just assume that ChangeSet can respond to those messages, and then I realized that there were no references to the whole class...

Martín

stepharo

Re: remove MczInstaller?

In reply to this post by tinchodias

Thanks a lot martin!
I checked also and I got confused :)
I have to investigate more. Could you open a bug entry because this is
handy to be able to browse an mcz by dropping it on the world
My impression is that we could remove

MCMcmReader class
MCMcdReader class

Le 5/9/15 19:00, Martin Dias a écrit :

> Hi,
>
> I logged for which classes MCVersionReader >>
> fileReaderServicesForFile:suffix: is invoked:
>
> In Pharo 4:
>
> MCVersionReader class
> MCMczReader class
> MCMcmReader class
> MCMcdReader class
>
> In Pharo 5:
>
> MCVersionReader class
>
>
> and it should be MCMczReader who adds those services for the MCZ files.
>
> Note: I tried in Pharo 4, and the list of file services didn't change
> after removing MczInstaller.
>
>
>
>
>
> Martín
>
> On Sat, Sep 5, 2015 at 6:24 PM, Marcus Denker <[hidden email]> wrote:
>>> On 05 Sep 2015, at 15:54, stepharo <[hidden email]> wrote:
>>>
>>> Are you sure that it is not used when we drag an MCZ on the desktop?
>> No, at least I do not think so.
>>
>> it’s the installer that was added to Squeak before Monticello. The idea is that it can be used
>> to install .mzc files even when Monticello is not there.
>>
>> I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep.
>> (to load monticello).
>>
>> Marcus
>>
>>
>>
>

stepharo

Re: remove MczInstaller?

In reply to this post by Marcus Denker-4

Le 5/9/15 18:24, Marcus Denker a écrit :

>> On 05 Sep 2015, at 15:54, stepharo <[hidden email]> wrote:
>>
>> Are you sure that it is not used when we drag an MCZ on the desktop?
> No, at least I do not think so.
>
> it’s the installer that was added to Squeak before Monticello. The idea is that it can be used
> to install .mzc files even when Monticello is not there.
>
> I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep.
> (to load monticello).

Yes I thought the same when I looked at them and comparing with Pharo40.
But after I could not find why we lost menu items but I was wrong.
I think that this is just one single and simple package so we can keep
it for now.

> Marcus
>
>
>
>