roassal-based blueprint review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

roassal-based blueprint review

Tudor Girba-2
Hi,

I looked over the Roassal blueprint implementation. We start to have a working solution. Good work.

However, there is still some work left :)

What is nice:
- Edges are properly drawn below the nodes
- The implementation layer shows a tree layout
- The morph menus work
- The layers do not capture the interaction

What is not so nice:
- Morph menus are shown even on left click. They should only appear on right click. I fixed this.
- The size of the root node grows too large and we get a little gap at the bottom (see the first attached picture). This has likely something to do with the latest fix from Alex related to padding.
- When dragging a method or attribute node outside of the bounds of the parent, the parent continues to grow (see the second picture). This is not good :). The problem is that the logic depends on setting the parent to have extensible size. Instead, in the case of the blueprint, it should be the responsibility of the layout to grow the parent as needed without actually making the parent to be extensible. This is why in Mondrian the layout could be set to stretch.
- Right now, the edges start and end in the center of the nodes. The convention in the blueprint is to have edges drawn starting from the right side and end on the left side of nodes.

In any case, I already added it to the MooseFinder (the blueprint tab).


Cheers,
Doru




--
www.tudorgirba.com

"There are no old things, there are only old ways of looking at them."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

Juraj Kubelka-5
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

Juraj Kubelka-5
In reply to this post by Tudor Girba-2
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

Juraj Kubelka-5
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

Tudor Girba-2
Hi Juraj,


On Apr 30, 2013, at 7:34 PM, Juraj Kubelka <[hidden email]> wrote:

> Hi!
>
> We have just fixed blueprint. Now, it should behave fine. There one open question which I mentioned yesterday:

Great, I will review it.

> By default the edges are drawn by Roassal below the nodes. In Mondrian-blueprint all the edges are on top. Is it fine to keep the default Roassal zOrdering? I have tried to change it and I have reached other problem. If the lines are on top, I cannot move (or it is almost impossible) with nodes below (in case of many lines pass over a node). And for now I do not know how to solve it. I have removed all the interactions of edges, but it does not work.

The Roassal ordering is correct and it is consistent with the original Mondrian. We want to keep it as it is. The one from the current Mondrian is wrong.

Cheers,
Doru


> Cheers,
> Jura
>
>
> 2013/4/29 Juraj Kubelka <[hidden email]>
> Hi Doru,
>
> there is some progress info:
>
> 2013/4/24 Tudor Girba <[hidden email]>
> Hi,
>
> I looked over the Roassal blueprint implementation. We start to have a working solution. Good work.
>
> However, there is still some work left :)
>
> What is nice:
> - Edges are properly drawn below the nodes
> - The implementation layer shows a tree layout
> - The morph menus work
> - The layers do not capture the interaction
>
> What is not so nice:
> - Morph menus are shown even on left click. They should only appear on right click. I fixed this.
>
> Thank you.
>  
> - The size of the root node grows too large and we get a little gap at the bottom (see the first attached picture). This has likely something to do with the latest fix from Alex related to padding.
>
> Fixed.
>  
> - When dragging a method or attribute node outside of the bounds of the parent, the parent continues to grow (see the second picture). This is not good :). The problem is that the logic depends on setting the parent to have extensible size. Instead, in the case of the blueprint, it should be the responsibility of the layout to grow the parent as needed without actually making the parent to be extensible. This is why in Mondrian the layout could be set to stretch.
>
> It has not been fixed yet. Alex and I are searching for the good solution.
>  
> - Right now, the edges start and end in the center of the nodes. The convention in the blueprint is to have edges drawn starting from the right side and end on the left side of nodes.
>
> Fixed.
>
> I have one more question. By default the edges are drawn by Roassal below the nodes. In Mondrian-blueprint all the edges are on top. Is it fine to keep the default Roassal zOrdering? I have tried to change it and I have reached other problem. If the lines are on top, I cannot move (or it is almost impossible) with nodes below (in case of many lines pass over a node). And for now I do not know how to solve it. I have removed all the interactions of edges, but it does not work.
>  
>
> In any case, I already added it to the MooseFinder (the blueprint tab).
>
>
> Thanks.
>  
>
> Cheers,
> Doru
>
> Cheers,
> Jura
>  
>
>
> <example-blueprint.png>
>
> <problem-dragging-nodes.png>
>
> --
> www.tudorgirba.com
>
> "There are no old things, there are only old ways of looking at them."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Beauty is where we see it."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

abergel
Cool!

Alexandre

Le 1 mai 2013 à 00:34, Tudor Girba <[hidden email]> a écrit :

> Hi Juraj,
>
>
> On Apr 30, 2013, at 7:34 PM, Juraj Kubelka <[hidden email]> wrote:
>
>> Hi!
>>
>> We have just fixed blueprint. Now, it should behave fine. There one open question which I mentioned yesterday:
>
> Great, I will review it.
>
>> By default the edges are drawn by Roassal below the nodes. In Mondrian-blueprint all the edges are on top. Is it fine to keep the default Roassal zOrdering? I have tried to change it and I have reached other problem. If the lines are on top, I cannot move (or it is almost impossible) with nodes below (in case of many lines pass over a node). And for now I do not know how to solve it. I have removed all the interactions of edges, but it does not work.
>
> The Roassal ordering is correct and it is consistent with the original Mondrian. We want to keep it as it is. The one from the current Mondrian is wrong.
>
> Cheers,
> Doru
>
>
>> Cheers,
>> Jura
>>
>>
>> 2013/4/29 Juraj Kubelka <[hidden email]>
>> Hi Doru,
>>
>> there is some progress info:
>>
>> 2013/4/24 Tudor Girba <[hidden email]>
>> Hi,
>>
>> I looked over the Roassal blueprint implementation. We start to have a working solution. Good work.
>>
>> However, there is still some work left :)
>>
>> What is nice:
>> - Edges are properly drawn below the nodes
>> - The implementation layer shows a tree layout
>> - The morph menus work
>> - The layers do not capture the interaction
>>
>> What is not so nice:
>> - Morph menus are shown even on left click. They should only appear on right click. I fixed this.
>>
>> Thank you.
>>
>> - The size of the root node grows too large and we get a little gap at the bottom (see the first attached picture). This has likely something to do with the latest fix from Alex related to padding.
>>
>> Fixed.
>>
>> - When dragging a method or attribute node outside of the bounds of the parent, the parent continues to grow (see the second picture). This is not good :). The problem is that the logic depends on setting the parent to have extensible size. Instead, in the case of the blueprint, it should be the responsibility of the layout to grow the parent as needed without actually making the parent to be extensible. This is why in Mondrian the layout could be set to stretch.
>>
>> It has not been fixed yet. Alex and I are searching for the good solution.
>>
>> - Right now, the edges start and end in the center of the nodes. The convention in the blueprint is to have edges drawn starting from the right side and end on the left side of nodes.
>>
>> Fixed.
>>
>> I have one more question. By default the edges are drawn by Roassal below the nodes. In Mondrian-blueprint all the edges are on top. Is it fine to keep the default Roassal zOrdering? I have tried to change it and I have reached other problem. If the lines are on top, I cannot move (or it is almost impossible) with nodes below (in case of many lines pass over a node). And for now I do not know how to solve it. I have removed all the interactions of edges, but it does not work.
>>
>>
>> In any case, I already added it to the MooseFinder (the blueprint tab).
>>
>>
>> Thanks.
>>
>>
>> Cheers,
>> Doru
>>
>> Cheers,
>> Jura
>>
>>
>>
>> <example-blueprint.png>
>>
>> <problem-dragging-nodes.png>
>>
>> --
>> www.tudorgirba.com
>>
>> "There are no old things, there are only old ways of looking at them."
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Beauty is where we see it."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: roassal-based blueprint review

Juraj Kubelka-5
In reply to this post by Tudor Girba-2
CONTENTS DELETED
The author has deleted this message.