running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Sheridan Mahoney
Hi there,

I am trying to use Hapao to check test coverage in the String class and
have run across some trouble. To begin, I loaded Spy2 and Roassal2 using
the following code:

Gofer new smalltalkhubUser: 'ObjectProfile'
  project: 'Roassal2';
  package: 'ConfigurationOfRoassal2';
  load.
(Smalltalk at: #ConfigurationOfRoassal2) load.

Gofer it
  smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
  configurationOf: 'Spy2';
  loadStable.

Hapao then showed up in the "World" menu, and I selected it.  I chose
"Hapao @ class ... " and entered "String".

Hapao starts running tests, but before long a debugger comes up with the
error: KeyNotFound: key #testClassComment not found in MethodDictionary
.  IF I click "Proceed", other keyNotFound errors come up.  This is in a
50524 image.

Is there something wrong with the way I am invoking Hapao?
Many thanks,
Sheridan


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

stepharo
Hi sheridan

spy string can be a challenge.
Now I was thikning recently that we should have tests for Ring. So if
you are interested I would love to review your tests.

Sef


Le 18/1/16 22:45, [hidden email] a écrit :

> Hi there,
>
> I am trying to use Hapao to check test coverage in the String class
> and have run across some trouble. To begin, I loaded Spy2 and Roassal2
> using the following code:
>
> Gofer new smalltalkhubUser: 'ObjectProfile'
>  project: 'Roassal2';
>  package: 'ConfigurationOfRoassal2';
>  load.
> (Smalltalk at: #ConfigurationOfRoassal2) load.
>
> Gofer it
>  smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
>  configurationOf: 'Spy2';
>  loadStable.
>
> Hapao then showed up in the "World" menu, and I selected it.  I chose
> "Hapao @ class ... " and entered "String".
>
> Hapao starts running tests, but before long a debugger comes up with
> the error: KeyNotFound: key #testClassComment not found in
> MethodDictionary .  IF I click "Proceed", other keyNotFound errors
> come up.  This is in a 50524 image.
>
> Is there something wrong with the way I am invoking Hapao?
> Many thanks,
> Sheridan
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Sheridan Mahoney
In reply to this post by Sheridan Mahoney
Hi Stef,

That would be great. I have only been writing very simple tests but it
would be nice to get some feedback.

What is the best way to get you the tests? Publish a slice to the
Pharo50Inbox?

Thanks,

Sheridan



Hi sheridan spy string can be a challenge. Now I was thikning recently
that we should have tests for Ring. So if you are interested I would
love to review your tests. Sef

Le 18/1/16 22:45,

>> Hi there, I am trying to use Hapao to check test coverage in the
>> String class and have run across some trouble. To begin, I loaded Spy2
>> and Roassal2 using the following code: Gofer new smalltalkhubUser:
>> 'ObjectProfile' project: 'Roassal2'; package:
>> 'ConfigurationOfRoassal2'; load. (Smalltalk at:
>> #ConfigurationOfRoassal2) load. Gofer it smalltalkhubUser:
>> 'ObjectProfile' project: 'Spy2'; configurationOf: 'Spy2'; loadStable.
>> Hapao then showed up in the "World" menu, and I selected it. I chose
>> "Hapao @ class ... " and entered "String". Hapao starts running tests,
>> but before long a debugger comes up with the error: KeyNotFound: key
>> #testClassComment not found in MethodDictionary . IF I click
>> "Proceed", other keyNotFound errors come up. This is in a 50524 image.
>> Is there something wrong with the way I am invoking Hapao? Many
>> thanks, Sheridan
> ******************************


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Alejandro Infante
In reply to this post by stepharo
Hi,
So this is not problem of Spy2, but a bug of Hapao. There should be no problem instrumenting String with Spy2 if your profiler is correct, the proof of this is that the image does not explode when you were debugging the execution (I was actually able to open a browser and check the tests of String).

This problem happened because we naively assumed, at least in this implementation Hapao, that for every Test Object there is a Test Method associated in the class of the Test Object. This is not correct for inherited tests, where the Test Method is in one of the superclasses.

I will submit a fix for that as soon as possible ;)

Thanks for the bug report!!
Alejandro

> On Jan 19, 2016, at 8:58 AM, stepharo <[hidden email]> wrote:
>
> Hi sheridan
>
> spy string can be a challenge.
> Now I was thikning recently that we should have tests for Ring. So if you are interested I would love to review your tests.
>
> Sef
>
>
> Le 18/1/16 22:45, [hidden email] a écrit :
>> Hi there,
>>
>> I am trying to use Hapao to check test coverage in the String class and have run across some trouble. To begin, I loaded Spy2 and Roassal2 using the following code:
>>
>> Gofer new smalltalkhubUser: 'ObjectProfile'
>> project: 'Roassal2';
>> package: 'ConfigurationOfRoassal2';
>> load.
>> (Smalltalk at: #ConfigurationOfRoassal2) load.
>>
>> Gofer it
>> smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
>> configurationOf: 'Spy2';
>> loadStable.
>>
>> Hapao then showed up in the "World" menu, and I selected it.  I chose "Hapao @ class ... " and entered "String".
>>
>> Hapao starts running tests, but before long a debugger comes up with the error: KeyNotFound: key #testClassComment not found in MethodDictionary .  IF I click "Proceed", other keyNotFound errors come up.  This is in a 50524 image.
>>
>> Is there something wrong with the way I am invoking Hapao?
>> Many thanks,
>> Sheridan
>>
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

stepharo
In reply to this post by Sheridan Mahoney


Le 19/1/16 19:45, [hidden email] a écrit :
> Hi Stef,
>
> That would be great. I have only been writing very simple tests but it
> would be nice to get some feedback.
>
> What is the best way to get you the tests? Publish a slice to the
> Pharo50Inbox?
Create a bug entry and post in Pharo50Inbox.
I think that you canget an impact because Ring should be nice to get
tests and like that we can make sure that we will
know if we break it in the future

> Thanks,
>
> Sheridan
>
>
>
> Hi sheridan spy string can be a challenge. Now I was thikning recently
> that we should have tests for Ring. So if you are interested I would
> love to review your tests. Sef
>
> Le 18/1/16 22:45,
>
>>> Hi there, I am trying to use Hapao to check test coverage in the
>>> String class and have run across some trouble. To begin, I loaded
>>> Spy2 and Roassal2 using the following code: Gofer new
>>> smalltalkhubUser: 'ObjectProfile' project: 'Roassal2'; package:
>>> 'ConfigurationOfRoassal2'; load. (Smalltalk at:
>>> #ConfigurationOfRoassal2) load. Gofer it smalltalkhubUser:
>>> 'ObjectProfile' project: 'Spy2'; configurationOf: 'Spy2';
>>> loadStable. Hapao then showed up in the "World" menu, and I selected
>>> it. I chose "Hapao @ class ... " and entered "String". Hapao starts
>>> running tests, but before long a debugger comes up with the error:
>>> KeyNotFound: key #testClassComment not found in MethodDictionary .
>>> IF I click "Proceed", other keyNotFound errors come up. This is in a
>>> 50524 image. Is there something wrong with the way I am invoking
>>> Hapao? Many thanks, Sheridan
>> ******************************
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Alejandro Infante
In reply to this post by Alejandro Infante
Hi again!
So I looked at the problem, wrote a fix, committed, created a new version and tested it. It should work out of the box :)

Also the ConfigurationOfSpy should load Roassal by its own, so to download Hapao just run:
——
Gofer it
smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
configurationOf: 'Spy2';
loadStable.
——

Cheers!
Alejandro

> On Jan 19, 2016, at 4:25 PM, Alejandro Infante <[hidden email]> wrote:
>
> Hi,
> So this is not problem of Spy2, but a bug of Hapao. There should be no problem instrumenting String with Spy2 if your profiler is correct, the proof of this is that the image does not explode when you were debugging the execution (I was actually able to open a browser and check the tests of String).
>
> This problem happened because we naively assumed, at least in this implementation Hapao, that for every Test Object there is a Test Method associated in the class of the Test Object. This is not correct for inherited tests, where the Test Method is in one of the superclasses.
>
> I will submit a fix for that as soon as possible ;)
>
> Thanks for the bug report!!
> Alejandro
>
>> On Jan 19, 2016, at 8:58 AM, stepharo <[hidden email]> wrote:
>>
>> Hi sheridan
>>
>> spy string can be a challenge.
>> Now I was thikning recently that we should have tests for Ring. So if you are interested I would love to review your tests.
>>
>> Sef
>>
>>
>> Le 18/1/16 22:45, [hidden email] a écrit :
>>> Hi there,
>>>
>>> I am trying to use Hapao to check test coverage in the String class and have run across some trouble. To begin, I loaded Spy2 and Roassal2 using the following code:
>>>
>>> Gofer new smalltalkhubUser: 'ObjectProfile'
>>> project: 'Roassal2';
>>> package: 'ConfigurationOfRoassal2';
>>> load.
>>> (Smalltalk at: #ConfigurationOfRoassal2) load.
>>>
>>> Gofer it
>>> smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
>>> configurationOf: 'Spy2';
>>> loadStable.
>>>
>>> Hapao then showed up in the "World" menu, and I selected it.  I chose "Hapao @ class ... " and entered "String".
>>>
>>> Hapao starts running tests, but before long a debugger comes up with the error: KeyNotFound: key #testClassComment not found in MethodDictionary .  IF I click "Proceed", other keyNotFound errors come up.  This is in a 50524 image.
>>>
>>> Is there something wrong with the way I am invoking Hapao?
>>> Many thanks,
>>> Sheridan
>>>
>>>
>>>
>>
>>
>


Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

abergel
Thanks Alejandro!
I also bumped into this problem this very morning

Cheers,
Alexandre


> On Jan 19, 2016, at 5:21 PM, Alejandro Infante <[hidden email]> wrote:
>
> Hi again!
> So I looked at the problem, wrote a fix, committed, created a new version and tested it. It should work out of the box :)
>
> Also the ConfigurationOfSpy should load Roassal by its own, so to download Hapao just run:
> ——
> Gofer it
> smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
> configurationOf: 'Spy2';
> loadStable.
> ——
>
> Cheers!
> Alejandro
>
>> On Jan 19, 2016, at 4:25 PM, Alejandro Infante <[hidden email]> wrote:
>>
>> Hi,
>> So this is not problem of Spy2, but a bug of Hapao. There should be no problem instrumenting String with Spy2 if your profiler is correct, the proof of this is that the image does not explode when you were debugging the execution (I was actually able to open a browser and check the tests of String).
>>
>> This problem happened because we naively assumed, at least in this implementation Hapao, that for every Test Object there is a Test Method associated in the class of the Test Object. This is not correct for inherited tests, where the Test Method is in one of the superclasses.
>>
>> I will submit a fix for that as soon as possible ;)
>>
>> Thanks for the bug report!!
>> Alejandro
>>
>>> On Jan 19, 2016, at 8:58 AM, stepharo <[hidden email]> wrote:
>>>
>>> Hi sheridan
>>>
>>> spy string can be a challenge.
>>> Now I was thikning recently that we should have tests for Ring. So if you are interested I would love to review your tests.
>>>
>>> Sef
>>>
>>>
>>> Le 18/1/16 22:45, [hidden email] a écrit :
>>>> Hi there,
>>>>
>>>> I am trying to use Hapao to check test coverage in the String class and have run across some trouble. To begin, I loaded Spy2 and Roassal2 using the following code:
>>>>
>>>> Gofer new smalltalkhubUser: 'ObjectProfile'
>>>> project: 'Roassal2';
>>>> package: 'ConfigurationOfRoassal2';
>>>> load.
>>>> (Smalltalk at: #ConfigurationOfRoassal2) load.
>>>>
>>>> Gofer it
>>>> smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
>>>> configurationOf: 'Spy2';
>>>> loadStable.
>>>>
>>>> Hapao then showed up in the "World" menu, and I selected it.  I chose "Hapao @ class ... " and entered "String".
>>>>
>>>> Hapao starts running tests, but before long a debugger comes up with the error: KeyNotFound: key #testClassComment not found in MethodDictionary .  IF I click "Proceed", other keyNotFound errors come up.  This is in a 50524 image.
>>>>
>>>> Is there something wrong with the way I am invoking Hapao?
>>>> Many thanks,
>>>> Sheridan
>>>>
>>>>
>>>>
>>>
>>>
>>
>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

abergel
In reply to this post by Sheridan Mahoney
hi Sheridan,

Let us know how it goes with Hapao

Alexandre


> On Jan 18, 2016, at 6:45 PM, [hidden email] wrote:
>
> Hi there,
>
> I am trying to use Hapao to check test coverage in the String class and have run across some trouble. To begin, I loaded Spy2 and Roassal2 using the following code:
>
> Gofer new smalltalkhubUser: 'ObjectProfile'
> project: 'Roassal2';
> package: 'ConfigurationOfRoassal2';
> load.
> (Smalltalk at: #ConfigurationOfRoassal2) load.
>
> Gofer it
> smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
> configurationOf: 'Spy2';
> loadStable.
>
> Hapao then showed up in the "World" menu, and I selected it.  I chose "Hapao @ class ... " and entered "String".
>
> Hapao starts running tests, but before long a debugger comes up with the error: KeyNotFound: key #testClassComment not found in MethodDictionary .  IF I click "Proceed", other keyNotFound errors come up.  This is in a 50524 image.
>
> Is there something wrong with the way I am invoking Hapao?
> Many thanks,
> Sheridan
>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




Reply | Threaded
Open this post in threaded view
|

Re: running Hapao on the String class - error: key not found in MethodDictionary for testClassComment

Sheridan Mahoney
In reply to this post by Sheridan Mahoney
Hi Alejandro and Alexandro,
Just wanted to let you know Hapao is working fine for me now...thanks
for the help.
Cheers,
Sheridan



Hi again!
So I looked at the problem, wrote a fix, committed, created a new
version and tested it. It should work out of the box :)

Also the ConfigurationOfSpy should load Roassal by its own, so to
download Hapao just run:
??
Gofer it
smalltalkhubUser: 'ObjectProfile' project: 'Spy2';
configurationOf: 'Spy2';
loadStable.
??

Cheers!
Alejandro

> On Jan 19, 2016, at 4:25 PM, Alejandro Infante
> <[hidden email]> wrote:

Hi, So this is not problem of Spy2, but a bug of Hapao. There should be
no problem instrumenting String with Spy2 if your profiler is correct,
the proof of this is that the image does not explode when you were
debugging the execution (I was actually able to open a browser and check
the tests of String). This problem happened because we naively assumed,
at least in this implementation Hapao, that for every Test Object there
is a Test Method associated in the class of the Test Object. This is not
correct for inherited tests, where the Test Method is in one of the
superclasses. I will submit a fix for that as soon as possible ;) Thanks
for the bug report!! Alejandro

On Jan 19, 2016, at 8:58 AM, stepharo <[hidden email]> wrote:
Hi sheridan spy string can be a challenge. Now I was thikning recently
that we should have tests for Ring. So if you are interested I would
love to review your tests. Sef

Le 18/1/16 22:45, [hidden email] a ?crit :
Hi there, I am trying to use Hapao to check test coverage in the String
class and have run across some trouble. To begin, I loaded Spy2 and
Roassal2 using the following code: Gofer new smalltalkhubUser:
'ObjectProfile' project: 'Roassal2'; package: 'ConfigurationOfRoassal2';
load. (Smalltalk at: #ConfigurationOfRoassal2) load. Gofer it
smalltalkhubUser: 'ObjectProfile' project: 'Spy2'; configurationOf:
'Spy2'; loadStable. Hapao then showed up in the "World" menu, and I
selected it. I chose "Hapao @ class ... " and entered "String". Hapao
starts running tests, but before long a debugger comes up with the
error: KeyNotFound: key #testClassComment not found in MethodDictionary
. IF I click "Proceed", other keyNotFound errors come up. This is in a
50524 image. Is there something wrong with the way I am invoking Hapao?
Many thanks, Sheridan