shape review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

shape review

Paolo Bonzini-2
Still to do:

1) use singletons.  Creating instances all the time is not acceptable.

2) no empty classes.

3) no empty methods returning self.  Leave those unimplemented or use
#subclassResponsibility.

4) methods such as wrongClassIfFloatShape: and
wrongClassIfCharacterShape: make no sense.  Just override
checkArgumentClass: instead.

5) #shape: not implemented yet using shapes, as a result #resolveShape:
is unused.

6) no class-method-only classes.  Move those to Shape.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk