Smalltalk › Pharo › Pharo Smalltalk Developers

slow method editor on syntax problems

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Johan Brichau

slow method editor on syntax problems

Hi everyone,

Editing becomes very slow very rapidly when some (syntax) errors are
present in the edited method. It suffices to have a couple of
undefined variables to make the text editor take 1 second to display a
typed character. Quite annoying...

I have not yet investigated the issue but since I guess I must not be
the only one to see this happen maybe someone has some thoughts or is
already on the issue (although I could not find an issue on the
tracker).

I am working with the latest (1.0rc) image.

cheers!

----------------------------
Johan Brichau
[hidden email]

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Alexandre Bergel

Re: slow method editor on syntax problems

> I have not yet investigated the issue but since I guess I must not be
> the only one to see this happen maybe someone has some thoughts or is
> already on the issue (although I could not find an issue on the
> tracker).

+1
You're not the only one

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Henrik Sperre Johansen

Re: slow method editor on syntax problems

In reply to this post by Johan Brichau

Yes, I have.
Do I have a fix done, or time to explain it right now? No :)
I'll see what I can do this weekend, I have some ideas.

Cheers,
Henry

On Nov 13, 2009, at 3:40 46PM, Johan Brichau wrote:

> Hi everyone,
>
> Editing becomes very slow very rapidly when some (syntax) errors are
> present in the edited method. It suffices to have a couple of
> undefined variables to make the text editor take 1 second to display a
> typed character. Quite annoying...
>
> I have not yet investigated the issue but since I guess I must not be
> the only one to see this happen maybe someone has some thoughts or is
> already on the issue (although I could not find an issue on the
> tracker).
>
> I am working with the latest (1.0rc) image.
>
> cheers!
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Mariano Martinez Peck

Re: slow method editor on syntax problems

In reply to this post by Alexandre Bergel

You should then open a bug ticket!

On Fri, Nov 13, 2009 at 1:03 PM, Alexandre Bergel <[hidden email]> wrote:

> I have not yet investigated the issue but since I guess I must not be
> the only one to see this happen maybe someone has some thoughts or is
> already on the issue (although I could not find an issue on the
> tracker).

+1
You're not the only one

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;<you._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Henrik Sperre Johansen

Re: slow method editor on syntax problems

Made issue 1452.

It's an OCompletion problem, really.

It reuses the text parsing from ECompletion, which calculates the ranges of the entire text on every invocation.

(Scanning the entire SymbolTable once for every undefined token in the text...)

Which I guess is fine when invocation is user-initiated, but not so much when it happens automatically as a response to every key press.

What I am planning to do, is rewrite it to not discard the context between each invocation, but rather update the type of range under the cursor, and the extent of subsequent ranges based on whether a character/string has been inserted or removed.

An easier solution would be to cache the last X queried undefined/partial symbols somewhere (Not in the parser-instance, as a new one is created by the context every time), as that would limit each parsing run to a worstcase of one full scan of the SymbolTable (for the current token).

It means an extra cache that has to be maintained though, and feels like working around the problem instead of solving it, so I'd rather do the former.

Cheers,

Henry

On Nov 14, 2009, at 9:45 10PM, Mariano Martinez Peck wrote:

You should then open a bug ticket!

On Fri, Nov 13, 2009 at 1:03 PM, Alexandre Bergel <[hidden email]> wrote:

> I have not yet investigated the issue but since I guess I must not be
> the only one to see this happen maybe someone has some thoughts or is
> already on the issue (although I could not find an issue on the
> tracker).

+1
You're not the only one

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;<you._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project