sourceText method wrong implementation
Locked
sourceText method wrong implementation
 
|
Hi,
I have noticed that both FAMIXClass and FAMIXMethod sourceText methods starts with: self mooseModel isSmalltalk I think this is wrong. It should always be:
self sourceLanguage isSmalltalk This way if a FAMIX element has a language which is default language for the model you can capture that. Do you agree? Cheers, Fabrizio _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Re: sourceText method wrong implementation
|
|
Indeed. Good catch.
Just make sure you commit it to SmalltalkHub. You should give us the user so that we can add you. Cheers, Doru On Mar 4, 2013, at 5:12 PM, Fabrizio Perin <[hidden email]> wrote: > Hi, > I have noticed that both FAMIXClass and FAMIXMethod sourceText methods starts with: > > self mooseModel isSmalltalk > > I think this is wrong. It should always be: > > self sourceLanguage isSmalltalk > > This way if a FAMIX element has a language which is default language for the model you can capture that. > > Do you agree? > > Cheers, > Fabrizio > _______________________________________________ > Moose-dev mailing list > [hidden email] > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Sometimes the best solution is not the best solution." _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Re: sourceText method wrong implementation
|
|
Hi Doru,
just created an account, the user name is: FabrizioPerin
Cheers,
Fabrizio
2013/3/5 Tudor Girba <[hidden email]> Indeed. Good catch. _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Re: sourceText method wrong implementation
|
|
You are in. Doru On Tue, Mar 5, 2013 at 8:33 AM, Fabrizio Perin <[hidden email]> wrote:
"Every thing has its own flow"
_______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Re: sourceText method wrong implementation
|
|
Thanks I will commit this evening on the repo because from the office I cannot access external repositories. (you know, security policies)
Cheers,
Fabrizio
2013/3/5 Tudor Girba <[hidden email]>
_______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Re: sourceText method wrong implementation
|
|
Thanks.
Doru On Mar 5, 2013, at 3:00 PM, Fabrizio Perin <[hidden email]> wrote: > Thanks I will commit this evening on the repo because from the office I cannot access external repositories. (you know, security policies) > > Cheers, > Fabrizio > > > 2013/3/5 Tudor Girba <[hidden email]> > You are in. > > Doru > > > On Tue, Mar 5, 2013 at 8:33 AM, Fabrizio Perin <[hidden email]> wrote: > Hi Doru, > just created an account, the user name is: FabrizioPerin > Cheers, > Fabrizio > 2013/3/5 Tudor Girba <[hidden email]> > Indeed. Good catch. > > Just make sure you commit it to SmalltalkHub. You should give us the user so that we can add you. > > Cheers, > Doru > > > On Mar 4, 2013, at 5:12 PM, Fabrizio Perin <[hidden email]> wrote: > > > Hi, > > I have noticed that both FAMIXClass and FAMIXMethod sourceText methods starts with: > > > > self mooseModel isSmalltalk > > > > I think this is wrong. It should always be: > > > > self sourceLanguage isSmalltalk > > > > This way if a FAMIX element has a language which is default language for the model you can capture that. > > > > Do you agree? > > > > Cheers, > > Fabrizio > > _______________________________________________ > > Moose-dev mailing list > > [hidden email] > > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > -- > www.tudorgirba.com > > "Sometimes the best solution is not the best solution." > > > _______________________________________________ > Moose-dev mailing list > [hidden email] > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > [hidden email] > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > > -- > www.tudorgirba.com > > "Every thing has its own flow" > > _______________________________________________ > Moose-dev mailing list > [hidden email] > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > [hidden email] > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Yesterday is a fact. Tomorrow is a possibility. Today is a challenge." _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
«
Return to Moose
|
1 view|%1 views
| Free forum by Nabble | Edit this page |