Smalltalk › Pharo › Pharo Smalltalk Developers

spotter much slower (GTools 3.6)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Nicolai Hess-3-2

spotter much slower (GTools 3.6)

since pharo 50524 spotter is much slower.

Most probably related to search results from classes with many subclasses

Morph / Object / Error / Announcement.

For example, search for Announcement

and dive into the result for the Announcement class.

It takes about ~ 10 seconds to build the result page (instance methods / super instance methods....)

Testcase

GTSpotterStepTest>>timeClassTest:aClassName
[ self basicSearch:aClassName ] timeToRun logCr.

"Pharo 50523"

timeClassTest:'Announcement'
0:00:00:00.539
timeClassTest:'Morph'
0:00:00:01.448

"Pharo 50524"
timeClassTest:'Announcement'
0:00:00:06.936
timeClassTest:'Morph'
0:00:00:49.044

Or open SUnit Testrunner and run tests for package:

GT-Tests-Spotter-Scripting

nicolai

Tudor Girba-2

Re: spotter much slower (GTools 3.6)

Hi,

Nice catch!

I looked at it, and I cannot understand where the slowness comes from because there is essentially no change in the processors of a Behavior. Now I am intrigued.

Please open an issue.

Cheers,
Doru

> On Jan 15, 2016, at 10:32 AM, Nicolai Hess <[hidden email]> wrote:
>
> since pharo 50524 spotter is much slower.
>
> Most probably related to search results from classes with many subclasses
> Morph / Object / Error / Announcement.
>
> For example, search for Announcement
> and dive into the result for the Announcement class.
> It takes about ~ 10 seconds to build the result page (instance methods / super instance methods....)
>
> Testcase
>
> GTSpotterStepTest>>timeClassTest:aClassName
> [ self basicSearch:aClassName ] timeToRun logCr.
>
> "Pharo 50523"
> timeClassTest:'Announcement'
> 0:00:00:00.539
> timeClassTest:'Morph'
> 0:00:00:01.448
>
> "Pharo 50524"
> timeClassTest:'Announcement'
> 0:00:00:06.936
> timeClassTest:'Morph'
> 0:00:00:49.044
>
> Or open SUnit Testrunner and run tests for package:
> GT-Tests-Spotter-Scripting
>
> nicolai

--
www.tudorgirba.com
www.feenk.com

"Every successful trip needs a suitable vehicle."

Mariano Martinez Peck

Re: spotter much slower (GTools 3.6)

This is not the case but related: https://pharo.fogbugz.com/f/cases/17381/GTSpotter-hangs-image-with-slow-internet-connection-catalog

On Fri, Jan 15, 2016 at 9:33 AM, Tudor Girba <[hidden email]> wrote:

Hi,

Nice catch!

I looked at it, and I cannot understand where the slowness comes from because there is essentially no change in the processors of a Behavior. Now I am intrigued.

Please open an issue.

Cheers,
Doru

> On Jan 15, 2016, at 10:32 AM, Nicolai Hess <[hidden email]> wrote:
>
> since pharo 50524 spotter is much slower.
>
> Most probably related to search results from classes with many subclasses
> Morph / Object / Error / Announcement.
>
> For example, search for Announcement
> and dive into the result for the Announcement class.
> It takes about ~ 10 seconds to build the result page (instance methods / super instance methods....)
>
> Testcase
>
> GTSpotterStepTest>>timeClassTest:aClassName
> [ self basicSearch:aClassName ] timeToRun logCr.
>
> "Pharo 50523"
> timeClassTest:'Announcement'
> 0:00:00:00.539
> timeClassTest:'Morph'
> 0:00:00:01.448
>
> "Pharo 50524"
> timeClassTest:'Announcement'
> 0:00:00:06.936
> timeClassTest:'Morph'
> 0:00:00:49.044
>
> Or open SUnit Testrunner and run tests for package:
> GT-Tests-Spotter-Scripting
>
> nicolai

--
www.tudorgirba.com
www.feenk.com

"Every successful trip needs a suitable vehicle."

Mariano
http://marianopeck.wordpress.com

Tudor Girba-2

Re: spotter much slower (GTools 3.6)

In reply to this post by Tudor Girba-2

Hi,

Oh, I got it. Your test does not test inside a class, but the top search.

I now committed GT-SpotterExtensions-Core-TudorGirba.187 to only search for exact references. Could you check?

Before, searching for Morphs took 58s:

Now, searching for Morphs takes 1s:

Cheers,

Doru

On Jan 15, 2016, at 1:33 PM, Tudor Girba <[hidden email]> wrote:

Hi,

Nice catch!

I looked at it, and I cannot understand where the slowness comes from because there is essentially no change in the processors of a Behavior. Now I am intrigued.

Please open an issue.

Cheers,
Doru

On Jan 15, 2016, at 10:32 AM, Nicolai Hess <[hidden email]> wrote:

since pharo 50524 spotter is much slower.

Most probably related to search results from classes with many subclasses
Morph / Object / Error / Announcement.

For example, search for Announcement
and dive into the result for the Announcement class.
It takes about ~ 10 seconds to build the result page (instance methods / super instance methods....)

Testcase

GTSpotterStepTest>>timeClassTest:aClassName
[ self basicSearch:aClassName ] timeToRun logCr.

"Pharo 50523"
timeClassTest:'Announcement'
0:00:00:00.539
timeClassTest:'Morph'
0:00:00:01.448

"Pharo 50524"
timeClassTest:'Announcement'
0:00:00:06.936
timeClassTest:'Morph'
0:00:00:49.044

Or open SUnit Testrunner and run tests for package:
GT-Tests-Spotter-Scripting

nicolai

--
www.tudorgirba.com
www.feenk.com

"Every successful trip needs a suitable vehicle."

--
www.tudorgirba.com
www.feenk.com

"What we can governs what we wish."

Nicolai Hess-3-2

Re: spotter much slower (GTools 3.6)

2016-01-15 14:02 GMT+01:00 Tudor Girba <[hidden email]>:

Hi,

Oh, I got it. Your test does not test inside a class, but the top search.

I now committed GT-SpotterExtensions-Core-TudorGirba.187 to only search for exact references. Could you check?

Yes! Much better :)

Before, searching for Morphs took 58s:

Cheers,
Doru

On Jan 15, 2016, at 1:33 PM, Tudor Girba <[hidden email]> wrote:

Hi,

Nice catch!

I looked at it, and I cannot understand where the slowness comes from because there is essentially no change in the processors of a Behavior. Now I am intrigued.

Please open an issue.

Cheers,
Doru

On Jan 15, 2016, at 10:32 AM, Nicolai Hess <[hidden email]> wrote:

since pharo 50524 spotter is much slower.

Most probably related to search results from classes with many subclasses
Morph / Object / Error / Announcement.

For example, search for Announcement
and dive into the result for the Announcement class.
It takes about ~ 10 seconds to build the result page (instance methods / super instance methods....)

Testcase

GTSpotterStepTest>>timeClassTest:aClassName
[ self basicSearch:aClassName ] timeToRun logCr.

"Pharo 50523"
timeClassTest:'Announcement'
0:00:00:00.539
timeClassTest:'Morph'
0:00:00:01.448

"Pharo 50524"
timeClassTest:'Announcement'
0:00:00:06.936
timeClassTest:'Morph'
0:00:00:49.044

Or open SUnit Testrunner and run tests for package:
GT-Tests-Spotter-Scripting

nicolai

--
www.tudorgirba.com
www.feenk.com

"Every successful trip needs a suitable vehicle."

--
www.tudorgirba.com
www.feenk.com

"What we can governs what we wish."