[sqeak-dev] Latest updates, dark themes don't look so good

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
cbc
Reply | Threaded
Open this post in threaded view
|

[sqeak-dev] Latest updates, dark themes don't look so good

cbc
I don't know where this happened, but in a pre-etoys-updated 6.0Alpha image (16548), things like inspectors are readable:
Inline image 1
while in a post-etoys updated 6.0Alpha image (16903), these inspectors are nearly useless:
Inline image 2
It may be that I had tweaked the colors in the older image, or loaded a different code where someone else fixed it. I'll look for where the change came from, but if someone knows what to fix, I'd appreciate that.

-cbc


cbc
Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

cbc
Hmm.  This only happens when i open a new explorer.  If I open an explorer, then change normal squeak theme, then go back to Monokai(dark), the tree view is now dark (like I would expect).  But the next explorer will have the white background again.

-cbc

On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <[hidden email]> wrote:
I don't know where this happened, but in a pre-etoys-updated 6.0Alpha image (16548), things like inspectors are readable:
Inline image 1
while in a post-etoys updated 6.0Alpha image (16903), these inspectors are nearly useless:
Inline image 2
It may be that I had tweaked the colors in the older image, or loaded a different code where someone else fixed it. I'll look for where the change came from, but if someone knows what to fix, I'd appreciate that.

-cbc



cbc
Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

cbc
So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in method MorphicToolBuilder>>buildPluggableTree:, where it sends:
widget color: Preferences defaultBackgroundColor.
This if after the theme-based setting of the color, so it overrides whatever the theme wants it to be.

Fix in the inbox, in:
    ToolBuilder-Morphic-cbc.191
Basically, I just removed the override of the color, to let the theme color be used instead.

(as an aside, I'm not sure why in a selected dark theme, the defualtBackgroundColor is "veryVeryLightGray").

-cbc

On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <[hidden email]> wrote:
Hmm.  This only happens when i open a new explorer.  If I open an explorer, then change normal squeak theme, then go back to Monokai(dark), the tree view is now dark (like I would expect).  But the next explorer will have the white background again.

-cbc

On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <[hidden email]> wrote:
I don't know where this happened, but in a pre-etoys-updated 6.0Alpha image (16548), things like inspectors are readable:
Inline image 1
while in a post-etoys updated 6.0Alpha image (16903), these inspectors are nearly useless:
Inline image 2
It may be that I had tweaked the colors in the older image, or loaded a different code where someone else fixed it. I'll look for where the change came from, but if someone knows what to fix, I'd appreciate that.

-cbc




Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

David T. Lewis
I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
from the inbox looks the same as the method currently in my trunk image,
and I am not able to reproduce the problem with explorers in dark theme.

Is there a version mixup here? Or maybe someone already merged the fix?

Dave

On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:

> So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in method
> MorphicToolBuilder>>buildPluggableTree:, where it sends:
> widget color: Preferences defaultBackgroundColor.
> This if after the theme-based setting of the color, so it overrides
> whatever the theme wants it to be.
>
> Fix in the inbox, in:
>     ToolBuilder-Morphic-cbc.191
> Basically, I just removed the override of the color, to let the theme color
> be used instead.
>
> (as an aside, I'm not sure why in a selected dark theme, the
> defualtBackgroundColor is "veryVeryLightGray").
>
> -cbc
>
> On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <[hidden email]>
> wrote:
>
> > Hmm.  This only happens when i open a new explorer.  If I open an
> > explorer, then change normal squeak theme, then go back to Monokai(dark),
> > the tree view is now dark (like I would expect).  But the next explorer
> > will have the white background again.
> >
> > -cbc
> >
> > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <[hidden email]
> > > wrote:
> >
> >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
> >> image (16548), things like inspectors are readable:
> >> [image: Inline image 1]
> >> while in a post-etoys updated 6.0Alpha image (16903), these inspectors
> >> are nearly useless:
> >> [image: Inline image 2]
> >> It may be that I had tweaked the colors in the older image, or loaded a
> >> different code where someone else fixed it. I'll look for where the change
> >> came from, but if someone knows what to fix, I'd appreciate that.
> >>
> >> -cbc
> >>
> >
> >




>


cbc
Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

cbc
I think you may be correct.

What I suspect happened is that I had loaded the Theme SAR before this was put into trunk, and when I migrated up afterwards, somehow it didn't migrate nicely.
In any case, what is in Trunk is what I proposed (with slightly different formatting - but same code).

Sorry for the disruption.

-cbc

On Wed, Feb 1, 2017 at 6:03 PM, David T. Lewis <[hidden email]> wrote:
I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
from the inbox looks the same as the method currently in my trunk image,
and I am not able to reproduce the problem with explorers in dark theme.

Is there a version mixup here? Or maybe someone already merged the fix?

Dave

On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:
> So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in method
> MorphicToolBuilder>>buildPluggableTree:, where it sends:
> widget color: Preferences defaultBackgroundColor.
> This if after the theme-based setting of the color, so it overrides
> whatever the theme wants it to be.
>
> Fix in the inbox, in:
>     ToolBuilder-Morphic-cbc.191
> Basically, I just removed the override of the color, to let the theme color
> be used instead.
>
> (as an aside, I'm not sure why in a selected dark theme, the
> defualtBackgroundColor is "veryVeryLightGray").
>
> -cbc
>
> On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <[hidden email]>
> wrote:
>
> > Hmm.  This only happens when i open a new explorer.  If I open an
> > explorer, then change normal squeak theme, then go back to Monokai(dark),
> > the tree view is now dark (like I would expect).  But the next explorer
> > will have the white background again.
> >
> > -cbc
> >
> > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <[hidden email]
> > > wrote:
> >
> >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
> >> image (16548), things like inspectors are readable:
> >> [image: Inline image 1]
> >> while in a post-etoys updated 6.0Alpha image (16903), these inspectors
> >> are nearly useless:
> >> [image: Inline image 2]
> >> It may be that I had tweaked the colors in the older image, or loaded a
> >> different code where someone else fixed it. I'll look for where the change
> >> came from, but if someone knows what to fix, I'd appreciate that.
> >>
> >> -cbc
> >>
> >
> >




>





Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

Chris Muller-3
Pressing Backspace (clear filter) with focus on the list will
reproduce the problem.

On Thu, Feb 2, 2017 at 4:38 PM, Chris Cunningham
<[hidden email]> wrote:

> I think you may be correct.
>
> What I suspect happened is that I had loaded the Theme SAR before this was
> put into trunk, and when I migrated up afterwards, somehow it didn't migrate
> nicely.
> In any case, what is in Trunk is what I proposed (with slightly different
> formatting - but same code).
>
> Sorry for the disruption.
>
> -cbc
>
> On Wed, Feb 1, 2017 at 6:03 PM, David T. Lewis <[hidden email]> wrote:
>>
>> I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
>> from the inbox looks the same as the method currently in my trunk image,
>> and I am not able to reproduce the problem with explorers in dark theme.
>>
>> Is there a version mixup here? Or maybe someone already merged the fix?
>>
>> Dave
>>
>> On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:
>> > So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in
>> > method
>> > MorphicToolBuilder>>buildPluggableTree:, where it sends:
>> > widget color: Preferences defaultBackgroundColor.
>> > This if after the theme-based setting of the color, so it overrides
>> > whatever the theme wants it to be.
>> >
>> > Fix in the inbox, in:
>> >     ToolBuilder-Morphic-cbc.191
>> > Basically, I just removed the override of the color, to let the theme
>> > color
>> > be used instead.
>> >
>> > (as an aside, I'm not sure why in a selected dark theme, the
>> > defualtBackgroundColor is "veryVeryLightGray").
>> >
>> > -cbc
>> >
>> > On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham
>> > <[hidden email]>
>> > wrote:
>> >
>> > > Hmm.  This only happens when i open a new explorer.  If I open an
>> > > explorer, then change normal squeak theme, then go back to
>> > > Monokai(dark),
>> > > the tree view is now dark (like I would expect).  But the next
>> > > explorer
>> > > will have the white background again.
>> > >
>> > > -cbc
>> > >
>> > > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham
>> > > <[hidden email]
>> > > > wrote:
>> > >
>> > >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
>> > >> image (16548), things like inspectors are readable:
>> > >> [image: Inline image 1]
>> > >> while in a post-etoys updated 6.0Alpha image (16903), these
>> > >> inspectors
>> > >> are nearly useless:
>> > >> [image: Inline image 2]
>> > >> It may be that I had tweaked the colors in the older image, or loaded
>> > >> a
>> > >> different code where someone else fixed it. I'll look for where the
>> > >> change
>> > >> came from, but if someone knows what to fix, I'd appreciate that.
>> > >>
>> > >> -cbc
>> > >>
>> > >
>> > >
>>
>>
>>
>>
>> >
>>
>>
>
>
>
>

cbc
Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

cbc
True, didn't notice that.

If you switch to inspect and back to explore, it fixes it again.

I did notice that apparently the SAR had installed other methods that set global preferences (such as defaultBackgroundColor) to a decent default for some of the themes, and I think it was this default color that managed to avoid these issues (or at least my issue) previously.  The updates seems to have deleted these messages (maybe - I'll have to spend more time to see what really happened and/or where these issues are coming from, if applicable).

-cbc

On Thu, Feb 2, 2017 at 2:43 PM, Chris Muller <[hidden email]> wrote:
Pressing Backspace (clear filter) with focus on the list will
reproduce the problem.

On Thu, Feb 2, 2017 at 4:38 PM, Chris Cunningham
<[hidden email]> wrote:
> I think you may be correct.
>
> What I suspect happened is that I had loaded the Theme SAR before this was
> put into trunk, and when I migrated up afterwards, somehow it didn't migrate
> nicely.
> In any case, what is in Trunk is what I proposed (with slightly different
> formatting - but same code).
>
> Sorry for the disruption.
>
> -cbc
>
> On Wed, Feb 1, 2017 at 6:03 PM, David T. Lewis <[hidden email]> wrote:
>>
>> I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
>> from the inbox looks the same as the method currently in my trunk image,
>> and I am not able to reproduce the problem with explorers in dark theme.
>>
>> Is there a version mixup here? Or maybe someone already merged the fix?
>>
>> Dave
>>
>> On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:
>> > So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in
>> > method
>> > MorphicToolBuilder>>buildPluggableTree:, where it sends:
>> > widget color: Preferences defaultBackgroundColor.
>> > This if after the theme-based setting of the color, so it overrides
>> > whatever the theme wants it to be.
>> >
>> > Fix in the inbox, in:
>> >     ToolBuilder-Morphic-cbc.191
>> > Basically, I just removed the override of the color, to let the theme
>> > color
>> > be used instead.
>> >
>> > (as an aside, I'm not sure why in a selected dark theme, the
>> > defualtBackgroundColor is "veryVeryLightGray").
>> >
>> > -cbc
>> >
>> > On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham
>> > <[hidden email]>
>> > wrote:
>> >
>> > > Hmm.  This only happens when i open a new explorer.  If I open an
>> > > explorer, then change normal squeak theme, then go back to
>> > > Monokai(dark),
>> > > the tree view is now dark (like I would expect).  But the next
>> > > explorer
>> > > will have the white background again.
>> > >
>> > > -cbc
>> > >
>> > > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham
>> > > <[hidden email]
>> > > > wrote:
>> > >
>> > >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
>> > >> image (16548), things like inspectors are readable:
>> > >> [image: Inline image 1]
>> > >> while in a post-etoys updated 6.0Alpha image (16903), these
>> > >> inspectors
>> > >> are nearly useless:
>> > >> [image: Inline image 2]
>> > >> It may be that I had tweaked the colors in the older image, or loaded
>> > >> a
>> > >> different code where someone else fixed it. I'll look for where the
>> > >> change
>> > >> came from, but if someone knows what to fix, I'd appreciate that.
>> > >>
>> > >> -cbc
>> > >>
>> > >
>> > >
>>
>>
>>
>>
>> >
>>
>>
>
>
>
>




Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

David T. Lewis
In reply to this post by cbc
Good. And however it got into trunk, thanks for the fix :-)

I moved ToolBuilder-Morphic-cbc.191 (with just that one method) over to
the treated inbox.

Dave

On Thu, Feb 02, 2017 at 02:38:16PM -0800, Chris Cunningham wrote:

> I think you may be correct.
>
> What I suspect happened is that I had loaded the Theme SAR before this was
> put into trunk, and when I migrated up afterwards, somehow it didn't
> migrate nicely.
> In any case, what is in Trunk is what I proposed (with slightly different
> formatting - but same code).
>
> Sorry for the disruption.
>
> -cbc
>
> On Wed, Feb 1, 2017 at 6:03 PM, David T. Lewis <[hidden email]> wrote:
>
> > I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
> > from the inbox looks the same as the method currently in my trunk image,
> > and I am not able to reproduce the problem with explorers in dark theme.
> >
> > Is there a version mixup here? Or maybe someone already merged the fix?
> >
> > Dave
> >
> > On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:
> > > So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in
> > method
> > > MorphicToolBuilder>>buildPluggableTree:, where it sends:
> > > widget color: Preferences defaultBackgroundColor.
> > > This if after the theme-based setting of the color, so it overrides
> > > whatever the theme wants it to be.
> > >
> > > Fix in the inbox, in:
> > >     ToolBuilder-Morphic-cbc.191
> > > Basically, I just removed the override of the color, to let the theme
> > color
> > > be used instead.
> > >
> > > (as an aside, I'm not sure why in a selected dark theme, the
> > > defualtBackgroundColor is "veryVeryLightGray").
> > >
> > > -cbc
> > >
> > > On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <
> > [hidden email]>
> > > wrote:
> > >
> > > > Hmm.  This only happens when i open a new explorer.  If I open an
> > > > explorer, then change normal squeak theme, then go back to
> > Monokai(dark),
> > > > the tree view is now dark (like I would expect).  But the next explorer
> > > > will have the white background again.
> > > >
> > > > -cbc
> > > >
> > > > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <
> > [hidden email]
> > > > > wrote:
> > > >
> > > >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
> > > >> image (16548), things like inspectors are readable:
> > > >> [image: Inline image 1]
> > > >> while in a post-etoys updated 6.0Alpha image (16903), these inspectors
> > > >> are nearly useless:
> > > >> [image: Inline image 2]
> > > >> It may be that I had tweaked the colors in the older image, or loaded
> > a
> > > >> different code where someone else fixed it. I'll look for where the
> > change
> > > >> came from, but if someone knows what to fix, I'd appreciate that.
> > > >>
> > > >> -cbc
> > > >>
> > > >
> > > >
> >
> >
> >
> >
> > >
> >
> >
> >

>


cbc
Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

cbc
In reply to this post by Chris Muller-3
Hi.

On Thu, Feb 2, 2017 at 2:43 PM, Chris Muller <[hidden email]> wrote:
Pressing Backspace (clear filter) with focus on the list will
reproduce the problem.

If you integrate:
The Inbox: ToolBuilder-Morphic-cbc.191.mcz
the problem will be fixed.  It was specifically setting the color to White (and not quite related to my previous non-problem).

-cbc 


Reply | Threaded
Open this post in threaded view
|

Re: [sqeak-dev] Latest updates, dark themes don't look so good

Chris Muller-3
Reviewed and moved to trunk.

Thanks for fixing that.

On Mon, Feb 6, 2017 at 1:19 PM, Chris Cunningham
<[hidden email]> wrote:

> Hi.
>
> On Thu, Feb 2, 2017 at 2:43 PM, Chris Muller <[hidden email]> wrote:
>>
>> Pressing Backspace (clear filter) with focus on the list will
>> reproduce the problem.
>>
> If you integrate:
> The Inbox: ToolBuilder-Morphic-cbc.191.mcz
> the problem will be fixed.  It was specifically setting the color to White
> (and not quite related to my previous non-problem).
>
> -cbc
>
>
>