status bar in Glamour browsers

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

status bar in Glamour browsers

Usman Bhatti
Hi, 

When adding status bar to Glamour browsers in Pharo 4.0, the contained presentations overlap the top elements of container. Here's a little script to reproduce this problem (see attached screenshot). 

Status bar does not seem to have changed, surely the layout frames of the container browser or the presentations are not handled correctly. I tried to dig the problem but could not get to its cause.

regards.
usman

| browser |
browser := GLMTabulator withStatusbar.
browser column: #one.
browser transmit to: #one; andShow: [:a |
a text 
display: 'something wrong with my browsers layout';
title: 'Tab'.
a text 
display: 'something wrong with my browsers layout';
title: 'Tab' ].
browser openOn: 1

Inline image 3

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: status bar in Glamour browsers

Tudor Girba-2
I noticed this, too, but only recently. I think something has changed at the Morphic level, but I am not sure either.

Doru

On Tue, Jul 7, 2015 at 3:47 PM, Usman Bhatti <[hidden email]> wrote:
Hi, 

When adding status bar to Glamour browsers in Pharo 4.0, the contained presentations overlap the top elements of container. Here's a little script to reproduce this problem (see attached screenshot). 

Status bar does not seem to have changed, surely the layout frames of the container browser or the presentations are not handled correctly. I tried to dig the problem but could not get to its cause.

regards.
usman

| browser |
browser := GLMTabulator withStatusbar.
browser column: #one.
browser transmit to: #one; andShow: [:a |
a text 
display: 'something wrong with my browsers layout';
title: 'Tab'.
a text 
display: 'something wrong with my browsers layout';
title: 'Tab' ].
browser openOn: 1

Inline image 3

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: status bar in Glamour browsers

Usman Bhatti
The problem seems to come from the changes in Rectangle class.

In Pharo 3.0:
 0@10 corner: 0@(-20) ==> Rectangle with topleft: 0@10 and bottomRight: 0@-20
 
Pharo 4.0 introduces a bit of intelligence to put minimal values on topleft:

0@10 corner: 0@(-20) ==> Rectangle with topleft: 0@-20 and bottomRight: 0@10

Hence bottom right negative offset should be set directly for layout frame:

(0 @ 0 corner: 1 @ 1) asLayoutFrame 
topLeftOffset: 0 @ 10 ; 
bottomRightOffset: 0@ -20

instead of:
LayoutFrame fractions: (0@0 corner: 1@1) offsets: (0@10 corner: 0@(-20)) 

I committed a version that should fix this problem but I didn't check any other occurrences.

Name: Glamour-Morphic-Renderer-usmanbhatti.323
Author: usmanbhatti
Time: 7 July 2015, 10:53:15.753678 pm
UUID: 98393fcc-26c6-493e-933d-f58195090c58
Ancestors: Glamour-Morphic-Renderer-CyrilFerlicot.322

correctly setting layout frame coordinates to fix the bug regarding overlapping layout with status bar






On Tue, Jul 7, 2015 at 4:48 PM, Tudor Girba <[hidden email]> wrote:
I noticed this, too, but only recently. I think something has changed at the Morphic level, but I am not sure either.

Doru

On Tue, Jul 7, 2015 at 3:47 PM, Usman Bhatti <[hidden email]> wrote:
Hi, 

When adding status bar to Glamour browsers in Pharo 4.0, the contained presentations overlap the top elements of container. Here's a little script to reproduce this problem (see attached screenshot). 

Status bar does not seem to have changed, surely the layout frames of the container browser or the presentations are not handled correctly. I tried to dig the problem but could not get to its cause.

regards.
usman

| browser |
browser := GLMTabulator withStatusbar.
browser column: #one.
browser transmit to: #one; andShow: [:a |
a text 
display: 'something wrong with my browsers layout';
title: 'Tab'.
a text 
display: 'something wrong with my browsers layout';
title: 'Tab' ].
browser openOn: 1

Inline image 3

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev