styling in spotter preview broken ?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

styling in spotter preview broken ?

Nicolai Hess
since 50064 some methods lost syntaxhighlight when previewed
in spotter.
This does not happens for all methods (but most of them) and I can not see a pattern.
Styling is lost on short and or long methods
Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Marcus Denker-4
Does this happen, too, when you turn off AST based highlighting?


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods


Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Nicolai Hess


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric

 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods


Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Nicolai Hess


2015-06-01 10:55 GMT+02:00 Nicolai Hess <[hidden email]>:


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric


Now with a bug report:
15663 styling in spotter preview broken

I think some changes in rubric are responsible but I am not sure, because
I cannot debug spotters preview.
( #haltOnce is cleared without opening the debugger!)

 
 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods



Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Andrei Chis
To debug spotter you should first open it in debug mode. The simplest solution is to use GTSpotterGlobalShortcut class>>openGlobalSpotterDebug
When not in debug mode spotter has an exception handler that captures all exceptions and write them to transcript.

I remember we fixed a while back some bugs related to styling caused by the fact that styling was done in a background process.
Though a quick look on the changes introduced in 50064 doesn't reveal any style related change that could cause this issue.


Cheers,
Andrei

On Mon, Jun 1, 2015 at 10:28 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 10:55 GMT+02:00 Nicolai Hess <[hidden email]>:


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric


Now with a bug report:
15663 styling in spotter preview broken

I think some changes in rubric are responsible but I am not sure, because
I cannot debug spotters preview.
( #haltOnce is cleared without opening the debugger!)

 
 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods




Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Nicolai Hess


2015-06-01 22:45 GMT+02:00 Andrei Chis <[hidden email]>:
To debug spotter you should first open it in debug mode. The simplest solution is to use GTSpotterGlobalShortcut class>>openGlobalSpotterDebug

No, that does not work. If you put a "self haltOnce" in a <spotterPreview> method, the preview is just empty, no debugger
window (not in "normal" spotter and not in "spotter debug mode").

 
When not in debug mode spotter has an exception handler that captures all exceptions and write them to transcript.

I remember we fixed a while back some bugs related to styling caused by the fact that styling was done in a background process.
Though a quick look on the changes introduced in 50064 doesn't reveal any style related change that could cause this issue.


Cheers,
Andrei

On Mon, Jun 1, 2015 at 10:28 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 10:55 GMT+02:00 Nicolai Hess <[hidden email]>:


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric


Now with a bug report:
15663 styling in spotter preview broken

I think some changes in rubric are responsible but I am not sure, because
I cannot debug spotters preview.
( #haltOnce is cleared without opening the debugger!)

 
 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods





Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Andrei Chis
There is small mistake in the preview as GTSpotterPreviewBrick>>updatePreviewWith: catches Exception and not Error. 
We also need to make the preview use the exception handled registered with the spotter.

 

On Mon, Jun 1, 2015 at 11:26 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 22:45 GMT+02:00 Andrei Chis <[hidden email]>:
To debug spotter you should first open it in debug mode. The simplest solution is to use GTSpotterGlobalShortcut class>>openGlobalSpotterDebug

No, that does not work. If you put a "self haltOnce" in a <spotterPreview> method, the preview is just empty, no debugger
window (not in "normal" spotter and not in "spotter debug mode").

 
When not in debug mode spotter has an exception handler that captures all exceptions and write them to transcript.

I remember we fixed a while back some bugs related to styling caused by the fact that styling was done in a background process.
Though a quick look on the changes introduced in 50064 doesn't reveal any style related change that could cause this issue.


Cheers,
Andrei

On Mon, Jun 1, 2015 at 10:28 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 10:55 GMT+02:00 Nicolai Hess <[hidden email]>:


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric


Now with a bug report:
15663 styling in spotter preview broken

I think some changes in rubric are responsible but I am not sure, because
I cannot debug spotters preview.
( #haltOnce is cleared without opening the debugger!)

 
 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods






Reply | Threaded
Open this post in threaded view
|

Re: styling in spotter preview broken ?

Nicolai Hess


2015-06-01 23:39 GMT+02:00 Andrei Chis <[hidden email]>:
There is small mistake in the preview as GTSpotterPreviewBrick>>updatePreviewWith: catches Exception and not Error. 
We also need to make the preview use the exception handled registered with the spotter.

 

Please, can someone check if this change


RubAbstractTextArea>>textColor: newColor

    textColor = newColor ifTrue: [^ self].             "<<<<---- this line removed "
    textColor := newColor.
    self addAttribute: (TextColor color: newColor).
    self changed.


was necessary, or if it is a failure from brick/spotter? to call this method.

(this above line was removed in 50064, since then the styling in spotters code preview does not work always).

 

On Mon, Jun 1, 2015 at 11:26 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 22:45 GMT+02:00 Andrei Chis <[hidden email]>:
To debug spotter you should first open it in debug mode. The simplest solution is to use GTSpotterGlobalShortcut class>>openGlobalSpotterDebug

No, that does not work. If you put a "self haltOnce" in a <spotterPreview> method, the preview is just empty, no debugger
window (not in "normal" spotter and not in "spotter debug mode").

 
When not in debug mode spotter has an exception handler that captures all exceptions and write them to transcript.

I remember we fixed a while back some bugs related to styling caused by the fact that styling was done in a background process.
Though a quick look on the changes introduced in 50064 doesn't reveal any style related change that could cause this issue.


Cheers,
Andrei

On Mon, Jun 1, 2015 at 10:28 PM, Nicolai Hess <[hidden email]> wrote:


2015-06-01 10:55 GMT+02:00 Nicolai Hess <[hidden email]>:


2015-06-01 10:39 GMT+02:00 Marcus Denker <[hidden email]>:
Does this happen, too, when you turn off AST based highlighting?

Yes, I think this is an issue on rubric.

  50064
15605 Update Rubric


Now with a bug report:
15663 styling in spotter preview broken

I think some changes in rubric are responsible but I am not sure, because
I cannot debug spotters preview.
( #haltOnce is cleared without opening the debugger!)

 
 


> On 30 May 2015, at 12:55, Nicolai Hess <[hidden email]> wrote:
>
> since 50064 some methods lost syntaxhighlight when previewed
> in spotter.
> This does not happens for all methods (but most of them) and I can not see a pattern.
> Styling is lost on short and or long methods