Smalltalk - Re: Rectangle center rounding

Smalltalk › Pharo › Pharo Smalltalk Users

Re: Rectangle center rounding

Posted by Nicolai Hess on Jul 19, 2015; 4:33pm
URL: https://forum.world.st/Rectangle-center-rounding-tp4837980p4838216.html

2015-07-18 10:25 GMT+02:00 Peter Uhnák <[hidden email]>:

The discussion was that Rectangle is used by Morphic which uses integer coordinates so rounding is required. I think the idea was to split the two classes?

Peter

On Sat, Jul 18, 2015 at 9:50 AM, Stephan Eggermont <[hidden email]> wrote:
On 17/07/15 18:16, Jan Blizničenko wrote:

Shouldn't the rounded method be separated as for
example roundedCenter or something like that to eliminate the confusion?

I would like to keep Rectangles current implementation, because the Rectangle class

is used for Screen-Rectangles and the screen only knows about integer/pixel positions.

But on the other hand, you are right, we already use and allow rectangles with non-integer corners.

And changing that (resp. enforcing integer coordinates) is maybe much more difficult.

And at latest when we use Athens for rendering the full world, Rectangles with integer rounded position for every shape, does'nt make much sense.

If you do some time comparsions, can you use

center
"Answer the point at the center of the receiver."

^self topLeft + self bottomRight / 2.0

(instead of "/ 2" ) (fraction vs. float)

I think I've seen discussions about this before and vaguely
remember the conclusion that there was too much current
code depending on it for this to be an easy change at the
moment

Stephan