Hi nicolai

Indeed we need on way to define "menuItem action"

I do not know if it should be bound to shortcut but it should have a shortcut.

I saw that Glamour has one way, the core other ways and probably Spec a third one.

So this is really confusing.

With guille we discussed a while ago about a hierarchy of command

    id

    description

    flyhelp

    action

    shortcut.

So probably the shortcut should be virtual so that we can bind the one we want system wide.

I would love to have Ctrle Ctrla.... ")

stef

Le 8/6/16 à 19:35, Nicolai Hess a écrit :

2016-06-08 19:11 GMT+02:00 Tudor Girba <[hidden email]>:

Yes, we already agreed on that both for the debugger and for Spotter. We just did not get the chance to do it yet.

Hey Doru,

about your report
https://pharo.fogbugz.com/f/cases/18455 Spotter shortcuts should be externalized as settings

Please don't do this just for spotter. We really need a general solution for all tools shortcuts.

I am alread about to clean up the shortcut definitions. In the tools and the PharoShortcuts class.

But we still need a way to really define this in a customizable way.

I already wrote about this and asked (ML or fogbugz, I don't remember).

The current shortcut definitions (with pragmas for example). Can be browsed and in the Keymap browser (that is good), but they can not be changed of course, they are defined in the source.

And, the current keymap definitions (KMKEyCombination) need a way to be able to read and write as a setting, that currently does not work (as I wrote).

My proposition was, to define some kind of "Named-Keyaction" or "Named-Action", for example

CopySelectionAction (name = CopySelection,  shortcut Ctrl+C), it would act as a KMKeyCombination, but its own shortcut (Ctrl+C) would be configurable.

Now, in PharoShortcuts instead of

PharoShortcuts >>#copySelectionShortcut

    ^ $c meta

we define

PharoShortcuts >>#copySelectionShortcut

    ^ CopySelectionAction withShortcut: $c meta

(maybe on unique Instance of CopySelectionAction, or one per category)

And the keymap browser, or the settings browser could list these actions and provide a way to reset the

keycombination:

CopySelectionAction  -   | type some keycombination here |

The current way with the PharoShortcuts class and how the keys are binded to the tools don't really work for customizable shortcut definitions (or keymaps) or

I just don't see it.

nicolai

 

Doru

> On Jun 8, 2016, at 11:33 AM, Esteban Lorenzano <[hidden email]> wrote:
>
>
>> On 08 Jun 2016, at 09:04, stepharo <[hidden email][hidden email]> wrote:
>>
>>  the fact that I cannot access Spotter without hurting my hand it is also probably why I do not try more.
>
> yeah, shortcut has to be configurable, for people with big hands :)
>
>

--
www.tudorgirba.com
www.feenk.com

"Every now and then stop and ask yourself if the war you're fighting is the right one."