testMatrixSign Failing Test

Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

testMatrixSign Failing Test

hemalvarambhia
I issued a PR against develop with a fix for testMatrixSign. It seems the assert message was mistakenly being sent to a PMMatrix object:


If someone could review this I'd sincerely appreciate it.

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: testMatrixSign Failing Test

hemalvarambhia
A reminder that if someone could review my two pull requests:


I would appreciate it greatly.

Thank you,

Hemal

On Sunday, November 4, 2018 at 7:44:18 PM UTC, Hemal Varambhia wrote:
I issued a PR against develop with a fix for testMatrixSign. It seems the assert message was mistakenly being sent to a PMMatrix object:

<a href="https://github.com/PolyMathOrg/PolyMath/pull/83" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F83\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZYm2g8DtujEAa4Sc7nw_I3HyppQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F83\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZYm2g8DtujEAa4Sc7nw_I3HyppQ&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/pull/83

If someone could review this I'd sincerely appreciate it.

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.