[tode_st] [dalehenrich/tode] e150fa: breakthrough ... realized that in TDTodeExpandedCo...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[tode_st] [dalehenrich/tode] e150fa: breakthrough ... realized that in TDTodeExpandedCo...

Dale Henrichs-3
  Branch: refs/heads/pharo
  Home:   https://github.com/dalehenrich/tode
  Commit: e150fa713d0d1cff0a25930b6b1d37db34bbda9f
      https://github.com/dalehenrich/tode/commit/e150fa713d0d1cff0a25930b6b1d37db34bbda9f
  Author: Dale Henrichs <[hidden email]>
  Date:   2016-12-30 (Fri, 30 Dec 2016)

  Changed paths:
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/instance/testExecBlockNestedBlockTempsAndArgsBaseNodeMap.st
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/methodProperties.json
    M repository/Tode-GemStone-Server3x-Tests.package/monticello.meta/version
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/instance/nestedArgsAndTempsInto.excluding..st
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/methodProperties.json
    M repository/Topez-Server-3x-DebugTools.package/monticello.meta/version

  Log Message:
  -----------
  breakthrough ... realized that in TDTodeExpandedContext>>nestedArgsAndTempsInto:excluding: the frame is the "homeContext" so just do the arg lookup in place ... turns out that i the live debugger I see the proper values, but in the debugger something is different and I don't see the block with `c` in it:( ... need to be able to validate the frames in tests!!!


  Commit: 9ae1a5f6af07dbe65deb6f807790d0525d7609dd
      https://github.com/dalehenrich/tode/commit/9ae1a5f6af07dbe65deb6f807790d0525d7609dd
  Author: Dale Henrichs <[hidden email]>
  Date:   2016-12-30 (Fri, 30 Dec 2016)

  Changed paths:
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/instance/nestedArgsAndTempsInto.excluding..st
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/methodProperties.json
    M repository/Topez-Server-3x-DebugTools.package/monticello.meta/version
    M repository/Topez-Server-Core.package/TDExecBlockNodeBuilder.class/instance/objectValueForSpecialElementName.for..st
    M repository/Topez-Server-Core.package/TDExecBlockNodeBuilder.class/instance/specialNames.st
    M repository/Topez-Server-Core.package/TDExecBlockNodeBuilder.class/methodProperties.json
    M repository/Topez-Server-Core.package/monticello.meta/version

  Log Message:
  -----------
  checkpoint ... finally trapping the elusive c temp variable ... threw kitchen sink at problem in TDTodeExpandedContext>>nestedArgsAndTempsInto:excluding: ... now need to scale it back to minimum needed.


  Commit: c8a3f9e0489214fb8fc22bdd4fb63a4d283eb339
      https://github.com/dalehenrich/tode/commit/c8a3f9e0489214fb8fc22bdd4fb63a4d283eb339
  Author: Dale Henrichs <[hidden email]>
  Date:   2016-12-30 (Fri, 30 Dec 2016)

  Changed paths:
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/instance/testExecBlockNestedBlockTempsAndArgsBaseNodeMap.st
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/instance/testExecBlockSimpleBaseNodeMap.st
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/instance/testExecBlockSimpleWithTempsBaseNodeMap.st
    M repository/Tode-GemStone-Server3x-Tests.package/TDStackFrameNewTests.class/methodProperties.json
    M repository/Tode-GemStone-Server3x-Tests.package/monticello.meta/version
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/instance/nestedArgsAndTempsInto.excluding..st
    M repository/Topez-Server-3x-DebugTools.package/TDTodeExpandedContext.class/methodProperties.json
    M repository/Topez-Server-3x-DebugTools.package/monticello.meta/version

  Log Message:
  -----------
  skinnied up TDTodeExpandedContext>>nestedArgsAndTempsInto:excluding: ... there might be more trimming to be done ... but I must move on to other tests and test cases ... functional is good.

15 run, 4 passes, 0 expected defects, 11 failures, 0 errors, 0 unexpected passes
  15 tests
TDStackFrameNewTests>>#testExecBlockComplexTempsBaseNodeMap
TDStackFrameNewTests>>#testExecBlockNestedBlockTempsAndArgsBaseNodeMap
TDStackFrameNewTests>>#testExecBlockSimpleBaseNodeMap
TDStackFrameNewTests>>#testExecBlockSimpleWithTempsBaseNodeMap


Compare: https://github.com/dalehenrich/tode/compare/4d84a7bf16eb...c8a3f9e04892

--
You received this message because you are subscribed to the Google Groups "tODE" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Loading...