[unix] RePlugin patch for pcre

 


Begin forwarded message:

>

 
Hi, Bert,

is there more details what is this patch about?

On 12 August 2013 17:50, Bert Freudenberg <[hidden email]> wrote:


--
Best regards,
Igor Stasenko.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710375

- Bert -

On 2013-08-12, at 17:55, Igor Stasenko <[hidden email]> wrote:

 
I added a Mantis entry for follow up
http://bugs.squeak.org/view.php?id=7785

Dave

On Mon, Aug 12, 2013 at 06:29:52PM +0200, Bert Freudenberg wrote:

This is a patch to generated source.  Who's maintaining the image-side code these days?  If nobody, does anyone volunteer to adopt it?

On Aug 12, 2013, at 08:50 , Bert Freudenberg wrote:

>> attached patch should fix it
>> there is another mention in RePlugin.cs but I have no idea what that is (smalltalk I guess?) so its still there
> <pcre-compat.patch>

 
We pulled the RePlugin in VMMaker some time ago, so the update can be done
there. I'll try to get the patch done, and regenerate the trunk/src, by this
weekend at the latest (unless someone else gets to it first).

Dave

On Mon, Aug 12, 2013 at 03:17:11PM -0700, Ian Piumarta wrote:
>
> This is a patch to generated source.  Who's maintaining the image-side code these days?  If nobody, does anyone volunteer to adopt it?
>
> On Aug 12, 2013, at 08:50 , Bert Freudenberg wrote:
>
> >> attached patch should fix it
> >> there is another mention in RePlugin.cs but I have no idea what that is (smalltalk I guess?) so its still there
> > <pcre-compat.patch>
>

 
On Tue, Aug 13, 2013 at 09:06:59AM -0400, David T. Lewis wrote:
I took a look at the Debian patch, and it simply disables the offending
primitive, so I think that a bit more work may be needed to update to the
current version of the pcre library.

I did some searching through the Swiki and SqueakMap, and here is a summary
of what I found:

RePlugin was written by Andrew C. Greenberg. It consists of a VM plugin in
package RegexPlugin, some interface classes in package Regex-Base, and a
test suite in package Regex-tests.

An overview is on the Swiki at http://wiki.squeak.org/squeak/558.

The RePlugin distribution is on SqueakMap as package "Regular Expression
Plugin". The most recent update is version 3.31, which is a SAR distribution
containing the plugin, the image support code, the unit tests, and documention.
The package is fully functional and all tests are green when running on a
32-bit VM (e.g. an interpreter VM from www.squeakvm.org/unix, or Cog if the
plugin is present).

The RePlugin is now part of the VMMaker package, so the RegexPlugin package
from the SqueakMap distribution is superceded by the RePlugin VMMaker-Plugins.

The RePlugin in VMMaker requires an update to use the newer pcre_fullinfo()
function rather than the obsolete pcre_info() function, which is no longer
present in some unix/linux distributions, as reported on
http://bugs.squeak.org/view.php?id=7785.

Additional follow up required:

The RePlugin requires updates for 32/64 bit compilation. It crashes the VM
when compiled in 64-bit mode.

The Regex package needs a new home in a Monticello repository to support
new updates, and to allow Regex to be distributed separately from the plugin.

The SqueakMap registry for Regular Expression Plugin needs a new (or additional)
maintainer.

Dave

 
In principle this should be a trivial fix. In practice it is a bit more
complicated.  I have collected some information and added it to a mantis issue
at http://bugs.squeak.org/view.php?id=7785.

I suspect that the error that the Debian maintainers are encountering reflects
a linker path conflict between the OS-supplied PCRE library versus the local
Squeak VM code in platforms/Cross/plugins/RePlugin.

Presumably we should use the OS-supplied library where possible, but I don't
know if PCRE is readily available on non-Linux platforms, and I'm having
problems getting the linker to work when I compile in 32-bit mode on my
computer, and the plugin still has issues compiling in 64-bit mode, so
I won't attempt a patch for RePlugin until this is sorted out.

More to follow, meanwhile anyone interested please read the mantis notes
at http://bugs.squeak.org/view.php?id=7785, guidance or advice welcome.

Dave



On Mon, Aug 12, 2013 at 02:23:52PM -0400, David T. Lewis wrote: