[update 1.2] #12170
Locked
 
|
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Henrik
when I drop a cs I get a DNU. No time to check now. Stef On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote: >> >> >> From: stephane ducasse <[hidden email]> >> Date: October 5, 2010 11:43:17 AM GMT+02:00 >> To: An open mailing list to discuss any topics related to an open-source Smalltalk <[hidden email]> >> Subject: [update 1.2] #12170 >> >> >> >> 12170 >> ----- >> >> - Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen >> >> > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Stéphane Ducasse
aMethod is a selector.
so we should change the code and like that the tests get green :). Stef > Henrik > > when I drop a cs I get a DNU. > No time to check now. > > Stef > On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote: > >>> >>> >>> From: stephane ducasse <[hidden email]> >>> Date: October 5, 2010 11:43:17 AM GMT+02:00 >>> To: An open mailing list to discuss any topics related to an open-source Smalltalk <[hidden email]> >>> Subject: [update 1.2] #12170 >>> >>> >>> >>> 12170 >>> ----- >>> >>> - Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen >>> >>> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
I got an error when building PharoKernel too:
9 MessageNotUnderstood(Exception)>>signal 10 UndefinedObject(Object)>>doesNotUnderstand: #selector 11 RecategorizedEvent class>>method:protocol:class:oldProtocol:
12 SystemChangeNotifier>>selector:recategorizedFrom:to:inClass: 13 Metaclass(ClassDescription)>>notifyOfRecategorizedSelector:from:to: 14 ClassOrganizer>>notifyOfChangedSelector:from:to:
15 ClassOrganizer>>removeElement: and the version from your comment ^(self method: aMethod protocol: prot class: aClass) itemSelector: aMethod; oldCategory: oldName doesn't solve the fix -- Pavel
On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <[hidden email]> wrote: aMethod is a selector. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [update 1.2] #12170
|
|
In reply to this post by Stéphane Ducasse
So aMethod parameter can be either CompiledMethod (method recategorization), nil (when building core), or a selector (dropping cs).
Makes total sense... :P Cheers, Henry On Oct 5, 2010, at 12:03 22PM, Stéphane Ducasse wrote: > aMethod is a selector. > > so we should change the code and like that the tests get green :). > > Stef > >> Henrik >> >> when I drop a cs I get a DNU. >> No time to check now. >> >> Stef >> On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote: >> >>>> >>>> >>>> From: stephane ducasse <[hidden email]> >>>> Date: October 5, 2010 11:43:17 AM GMT+02:00 >>>> To: An open mailing list to discuss any topics related to an open-source Smalltalk <[hidden email]> >>>> Subject: [update 1.2] #12170 >>>> >>>> >>>> >>>> 12170 >>>> ----- >>>> >>>> - Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen >>>> >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Stéphane Ducasse
Hi,
On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <[hidden email]> wrote: aMethod is a selector. aMethod is a CompiledMethod or nil (when the method is deleted) -- Pavel so we should change the code and like that the tests get green :). _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [update 1.2] #12170
|
|
On Oct 5, 2010, at 12:25 37PM, Pavel Krivanek wrote: Hi, Of course, an alternative is to just set itemSelector if method notNil, the choice simply reflects my personal preference. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
2010/10/5 Henrik Johansen <[hidden email]>
Good solution, thanks... -- Pavel _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Stéphane Ducasse
On Oct 5, 2010, at 12:25 PM, Henrik Johansen wrote: > So aMethod parameter can be either CompiledMethod (method recategorization), nil (when building core), or a selector (dropping cs). > Makes total sense... :P we should really fix that this is really ugly. So we will have to fix that. > Cheers, > Henry > > On Oct 5, 2010, at 12:03 22PM, Stéphane Ducasse wrote: > >> aMethod is a selector. >> >> so we should change the code and like that the tests get green :). >> >> Stef >> >>> Henrik >>> >>> when I drop a cs I get a DNU. >>> No time to check now. >>> >>> Stef >>> On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote: >>> >>>>> >>>>> >>>>> From: stephane ducasse <[hidden email]> >>>>> Date: October 5, 2010 11:43:17 AM GMT+02:00 >>>>> To: An open mailing list to discuss any topics related to an open-source Smalltalk <[hidden email]> >>>>> Subject: [update 1.2] #12170 >>>>> >>>>> >>>>> >>>>> 12170 >>>>> ----- >>>>> >>>>> - Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Pavel Krivanek-3
Thanks I will integrate it now
On Oct 5, 2010, at 12:46 PM, Henrik Johansen wrote: > > On Oct 5, 2010, at 12:25 37PM, Pavel Krivanek wrote: > >> Hi, >> >> On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <[hidden email]> wrote: >> aMethod is a selector. >> >> aMethod is a CompiledMethod or nil (when the method is deleted) >> >> -- Pavel > > Submitted new slice, this time deprecating old constructor, and using a new one passing the selector explicitly, seeing as how method (or nil) was inferred based on it in the first place. > Of course, an alternative is to just set itemSelector if method notNil, the choice simply reflects my personal preference. > > Cheers, > Henry > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |