Smalltalk › Pharo › Pharo Smalltalk Developers

[update 1.4] #14141

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Marcus Denker-4

[update 1.4] #14141

14141
-----

Issue 3726: Turn the orange corner into a real Morph object
http://code.google.com/p/pharo/issues/detail?id=3726

Issue 4791: Add a class to have a better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

--
Marcus Denker -- http://marcusdenker.de

Gary Chambers-4

Re: [update 1.4] #14141

Unfortunately major breakage when I update.
PluggableTextMorph initialize seems to indicate that AdorementMorph is nil
Hence MNU for UndefinedObject does not uunderstand #on:
(shouldn't it be named AdornmentMorph anyway...)

Regards, Gary

----- Original Message -----
From: "Marcus Denker" <[hidden email]>
To: "An open mailing list to discuss any topics related to an
open-sourceSmalltalk" <[hidden email]>
Sent: Thursday, September 15, 2011 9:22 AM
Subject: [Pharo-project] [update 1.4] #14141

> 14141
> -----
>
> Issue 3726: Turn the orange corner into a real Morph object
> http://code.google.com/p/pharo/issues/detail?id=3726
>
> Issue 4791: Add a class to have a better holding of IconicList items
> http://code.google.com/p/pharo/issues/detail?id=4791
>
>
> --
> Marcus Denker -- http://marcusdenker.de
>
>

Marcus Denker-4

Re: [update 1.4] #14141

In reply to this post by Marcus Denker-4

On Sep 15, 2011, at 12:24 PM, Gary Chambers wrote:

> Unfortunately major breakage when I update.
> PluggableTextMorph initialize seems to indicate that AdorementMorph is nil
> Hence MNU for UndefinedObject does not uunderstand #on:
> (shouldn't it be named AdornmentMorph anyway...)
>
Aargh.. the class was in a system category that is not a Package, so it did not get saved...

I will fix it by adding a changeset to the update stream...

--
Marcus Denker -- http://marcusdenker.de

Marcus Denker-4

Re: [update 1.4] #14141

On Sep 15, 2011, at 12:53 PM, Marcus Denker wrote:

>
> On Sep 15, 2011, at 12:24 PM, Gary Chambers wrote:
>
>> Unfortunately major breakage when I update.
>> PluggableTextMorph initialize seems to indicate that AdorementMorph is nil
>> Hence MNU for UndefinedObject does not uunderstand #on:
>> (shouldn't it be named AdornmentMorph anyway...)
>>
> Aargh.. the class was in a system category that is not a Package, so it did not get saved...
>
> I will fix it by adding a changeset to the update stream...

14142 provides the missing class (we can rename it later). Now Morphic is dirty, which will
be fixed in 14143.

--
Marcus Denker -- http://marcusdenker.de

Marcus Denker-4

Re: [update 1.4] #14141

On Sep 15, 2011, at 1:01 PM, Marcus Denker wrote:

>
> On Sep 15, 2011, at 12:53 PM, Marcus Denker wrote:
>
>>
>> On Sep 15, 2011, at 12:24 PM, Gary Chambers wrote:
>>
>>> Unfortunately major breakage when I update.
>>> PluggableTextMorph initialize seems to indicate that AdorementMorph is nil
>>> Hence MNU for UndefinedObject does not uunderstand #on:
>>> (shouldn't it be named AdornmentMorph anyway...)
>>>
>> Aargh.. the class was in a system category that is not a Package, so it did not get saved...
>>
>> I will fix it by adding a changeset to the update stream...
>
>
> 14142 provides the missing class (we can rename it later). Now Morphic is dirty, which will
> be fixed in 14143.
>

Ok, 14243 is done and it seems all to be fixed (I hope)

--
Marcus Denker -- http://marcusdenker.de

Gary Chambers-4

Re: [update 1.4] #14141

Somewhat...
The change in PluggableTextMorph>>initialize to a proportional layout
affects the minExtent calculation, hence splitters for text will not allow
shrinkage any more...

Regards, Gary

----- Original Message -----
From: "Marcus Denker" <[hidden email]>
To: "An open mailing list to discuss any topics related to an
open-sourceSmalltalk" <[hidden email]>
Sent: Thursday, September 15, 2011 12:22 PM
Subject: Re: [Pharo-project] [update 1.4] #14141

On Sep 15, 2011, at 1:01 PM, Marcus Denker wrote:

>
> On Sep 15, 2011, at 12:53 PM, Marcus Denker wrote:
>
>>
>> On Sep 15, 2011, at 12:24 PM, Gary Chambers wrote:
>>
>>> Unfortunately major breakage when I update.
>>> PluggableTextMorph initialize seems to indicate that AdorementMorph is
>>> nil
>>> Hence MNU for UndefinedObject does not uunderstand #on:
>>> (shouldn't it be named AdornmentMorph anyway...)
>>>
>> Aargh.. the class was in a system category that is not a Package, so it
>> did not get saved...
>>
>> I will fix it by adding a changeset to the update stream...
>
>
> 14142 provides the missing class (we can rename it later). Now Morphic is
> dirty, which will
> be fixed in 14143.
>

Ok, 14243 is done and it seems all to be fixed (I hope)

--
Marcus Denker -- http://marcusdenker.de

Marcus Denker-4

Re: [update 1.4] #14141

In reply to this post by Marcus Denker-4

On Sep 15, 2011, at 1:40 PM, Gary Chambers wrote:

> Somewhat...
> The change in PluggableTextMorph>>initialize to a proportional layout
> affects the minExtent calculation, hence splitters for text will not allow shrinkage any more...
>

Maybe we should just undo all the changes...

--
Marcus Denker -- http://marcusdenker.de

Gary Chambers-4

Re: [update 1.4] #14141

Proably, clearly some more work is required before it is ready
(maybe a StackLayout with the adornment in a spaceFill Panel with
proportional layout would work)

Regards, Gary

----- Original Message -----
From: "Marcus Denker" <[hidden email]>
To: <[hidden email]>
Sent: Thursday, September 15, 2011 12:44 PM
Subject: Re: [Pharo-project] [update 1.4] #14141

On Sep 15, 2011, at 1:40 PM, Gary Chambers wrote:

> Somewhat...
> The change in PluggableTextMorph>>initialize to a proportional layout
> affects the minExtent calculation, hence splitters for text will not allow
> shrinkage any more...
>

Maybe we should just undo all the changes...

--
Marcus Denker -- http://marcusdenker.de

Alain Plantec-3

Re: [update 1.4] #14141

In reply to this post by Marcus Denker-4

On 15/09/2011 13:44, Marcus Denker wrote:
>
> On Sep 15, 2011, at 1:40 PM, Gary Chambers wrote:
>
>> Somewhat...
>> The change in PluggableTextMorph>>initialize to a proportional layout
>> affects the minExtent calculation, hence splitters for text will not allow shrinkage any more...
yes, at least the finder, the settingbrowser and the timeprofiler are
curiously dressed now :)
Alain

>>
>
> Maybe we should just undo all the changes...
>
> --
> Marcus Denker -- http://marcusdenker.de
>
>
>

Marcus Denker-4

Re: [update 1.4] #14141

In reply to this post by Marcus Denker-4

On Sep 15, 2011, at 2:21 PM, Gary Chambers wrote:

> Proably, clearly some more work is required before it is ready
> (maybe a StackLayout with the adornment in a spaceFill Panel with proportional layout would work)
>

Now doing the undo with yet another update would be a lot of work...

Is is ok to just remove update 14141-1413 from the update stream?

--
Marcus Denker -- http://marcusdenker.de

Stéphane Ducasse

Re: [update 1.4] #14141

> Proably, clearly some more work is required before it is ready
>> (maybe a StackLayout with the adornment in a spaceFill Panel with proportional layout would work)
>>
>
> Now doing the undo with yet another update would be a lot of work...
>
> Is is ok to just remove update 14141-1413 from the update stream?

Yes

Marcus Denker-4

Re: [update 1.4] #14141

In reply to this post by Marcus Denker-4

On Sep 15, 2011, at 2:48 PM, Stéphane Ducasse wrote:

>> Proably, clearly some more work is required before it is ready
>>> (maybe a StackLayout with the adornment in a spaceFill Panel with proportional layout would work)
>>>
>>
>> Now doing the undo with yet another update would be a lot of work...
>>
>> Is is ok to just remove update 14141-1413 from the update stream?
>
> Yes

Done and Jenkins build re-started.

I will take some time off from integrating fixes..

Marcus

--
Marcus Denker -- http://marcusdenker.de