[update] 10472

> Issue 1310:     Make all tests green (not complete yet)
> - Remove class MethodHighlightingTests
> - ParseNode removeSelector: #addCommentToMorph:
> - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}' prints
> '{1. 1@2. 3})
> - Remove method CompiledMethod>>primitiveNode as it is not used anymore
> - Fix toolbuilder tests (sort of)
> - Fix Decompiler>>decompileBlock: (regression of closure fixes). This
> makes BlockContextTest>>testDecompile pass again
> - Make BlockContextTest>>testTrace run by commenting out broken part
> of code simulation
> Issue 1308:     FixedIdentitySet = fails when compared with an integer
>
>
> ___________________
> http://www.adrian-lienhard.ch/
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> Hi Adrian
> is method highlighting test broken or bogus? Was there a reason to not
> mark it expected failure?
>
> Thanks
> mike
>
> On Saturday, October 17, 2009, Adrian Lienhard <[hidden email]>  
> wrote:
>> Issue 1310:     Make all tests green (not complete yet)
>> - Remove class MethodHighlightingTests
>> - ParseNode removeSelector: #addCommentToMorph:
>> - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}'  
>> prints
>> '{1. 1@2. 3})
>> - Remove method CompiledMethod>>primitiveNode as it is not used  
>> anymore
>> - Fix toolbuilder tests (sort of)
>> - Fix Decompiler>>decompileBlock: (regression of closure fixes). This
>> makes BlockContextTest>>testDecompile pass again
>> - Make BlockContextTest>>testTrace run by commenting out broken part
>> of code simulation
>> Issue 1308:     FixedIdentitySet = fails when compared with an  
>> integer
>>
>>
>> ___________________
>> http://www.adrian-lienhard.ch/
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

> Hi Mike
>
> Thanks for asking. I removed it because I had the impression it
> depends on the class XMLWriter that is not in the image. Looking at it
> again, I see that this is just example code to run the test on. If I
> change XMLWriter to Object the test run green. I will add it again.
>
> Issue 1317: Add MethodHighlightingTests back
> http://code.google.com/p/pharo/issues/detail?id=1317
>
> Adrian
>
> On Oct 17, 2009, at 11:47 , Michael Roberts wrote:
>
>> Hi Adrian
>> is method highlighting test broken or bogus? Was there a reason to not
>> mark it expected failure?
>>
>> Thanks
>> mike
>>
>> On Saturday, October 17, 2009, Adrian Lienhard <[hidden email]>
>> wrote:
>>> Issue 1310:     Make all tests green (not complete yet)
>>> - Remove class MethodHighlightingTests
>>> - ParseNode removeSelector: #addCommentToMorph:
>>> - Fix SelfEvaluatingObjectTest>>testArray ({1 + 0 . 1 @ 2 . 3}'
>>> prints
>>> '{1. 1@2. 3})
>>> - Remove method CompiledMethod>>primitiveNode as it is not used
>>> anymore
>>> - Fix toolbuilder tests (sort of)
>>> - Fix Decompiler>>decompileBlock: (regression of closure fixes). This
>>> makes BlockContextTest>>testDecompile pass again
>>> - Make BlockContextTest>>testTrace run by commenting out broken part
>>> of code simulation
>>> Issue 1308:     FixedIdentitySet = fails when compared with an
>>> integer
>>>
>>>
>>> ___________________
>>> http://www.adrian-lienhard.ch/
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

>
>
> - Make BlockContextTest>>testTrace run by commenting out broken part
> of code simulation
>
>
> Adrian: In 10515 this test sometime fails, but then running it again, it works :(
>
>  
> ___________________
> http://www.adrian-lienhard.ch/
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

> John is right.  This is an important test.  In my work image it works fine.  That it fails in Pharo is indicative of some problem with the execution simulation machinery and closures. You're missing some changes.
>
> BTW, in my image the class is BlockTest (see attached)
>
> 2010/3/19 John M McIntosh <[hidden email]>
> Careful, does anyone understand why it works, then why it fails.
> Is it because the environment changes? Or some subtle issue in blocks?
> Removing it because it fails doesn't seem like a useful criteria if it's attempted to give us a clue?
>
> On 2010-03-19, at 12:41 PM, Stéphane Ducasse wrote:
>
> > remove it!
> >
> > Stef
> >
> > On Mar 19, 2010, at 8:02 PM, Mariano Martinez Peck wrote:
> >
> >>
> >>
> >> - Make BlockContextTest>>testTrace run by commenting out broken part
> >> of code simulation
> >>
> >>
> >> Adrian: In 10515 this test sometime fails, but then running it again, it works :(
> >>
>
> --
> ===========================================================================
> John M. McIntosh <[hidden email]>   Twitter:  squeaker68882
> Corporate Smalltalk Consulting Ltd.  http://www.smalltalkconsulting.com
> ===========================================================================
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> <BlockTest.st>_______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project