[vw 7.9] ODBC EXDI unicode correction

In ODBCSession>>getSQLColumns:tableOwner:tableName:columnName: the portion that

sends SQLColumnsW:… needs to be corrected as follows.

                self connection isUnicodeEncoding ifTrue: [

                                rc := xif SQLColumnsW: self hstmt

                                                                with: szTableQualfier with: tableQualifier size

                                                                with: szTableOwner with: tableOwner size

                                                                with: szTableName with: tableName size

                                                                with: szColumnName with: columnName size.

Terry

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

Terry,

I’ve had other issues with trying to make the whole connection Unicode-enabled and ended up specifying #UnicodeString for fields that needed it when invoking #bindInput:template:. Since don’t actually use Unicode in any of our SQL, just the values and we only use bound variables to prevent injection, that seems to do the trick.

What was your experience so far aside from the fix below?

In ODBCSession>>getSQLColumns:tableOwner:tableName:columnName: the portion that

sends SQLColumnsW:… needs to be corrected as follows.

                self connection isUnicodeEncoding ifTrue: [

                                rc := xif SQLColumnsW: self hstmt

                                                                with: szTableQualfier with: tableQualifier size

                                                                with: szTableOwner with: tableOwner size

                                                                with: szTableName with: tableName size

                                                                with: szColumnName with: columnName size.

Terry

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

Boris

I found out that the other get… methods in the same category also needed fixing.

With respect to the ODBC EXDI, we have many patches. I just got it to work with

Unicode. I wanted to read Excel files in Unicode.

Hi Terry,

Thanks for reporting the problem.

You are right, when Unicode encoding is used, we need to pass number of characters instead of number of bytes to the ODBC APIs in method ODBCSession>>getSQLColumns: and a few others.

AR 66818 “In ODBCEXDI, method ODBCSession>>getSQLColumns: and a few others need to pass number of characters instead of number of bytes to the ODBC APIs when using Unicode” is created for this, we‘ll fix them as soon as possible.

Let me know if you find any other problems or have any concerns.

Regards,

Yuwei