[vw7.9][COM] Comment contradictory about reference counting on temporary interface pointers

Until 7.8.1, temporary interface pointers were not reference counted, as it is stated in the comment of method #forTemporaryInterfacePointerAtAddress:

"Answer a new instance of the receiver for an external interface pointer whose pointer value is in external memory referenced by <anExternalAddress>.  This creation service is used to instantiate interfaces which are temporarily owned - the interface instance is not separately reference counted and should not be released by the caller.  E.g., this is always used by the callee during interface function invocation to access an interface argument provided by an external caller.  The caller must explicitly make a copy of the interface and increment its reference count if it holds on to this interface reference. "

this method however calls #newTemporaryInterfacePointerAtAddress: and there it says:

    " Answer a new instance of the receiver for an interface whose pointer value is in external memory referenced by <anExternalAddress>. In earlier versions of COM connect, this interface pointer was not referencecounted. From 7.9 on,
    it is at it may be kept by the server object."

1) I think the comments should be unambiguous about the fact of reference counting.

2) Another question is why *temporary* interface pointers are suddenly all made reference counted just in case some one holds onto them. The comment above explicitely said that if you hold on to the interface, you should copy your own and reference counted interface pointer.

Thomas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Until 7.8.1, temporary interface pointers were not reference counted, as it is stated in the comment of method #forTemporaryInterfacePointerAtAddress:

"Answer a new instance of the receiver for an external interface pointer whose pointer value is in external memory referenced by <anExternalAddress>.  This creation service is used to instantiate interfaces which are temporarily owned - the interface instance is not separately reference counted and should not be released by the caller.  E.g., this is always used by the callee during interface function invocation to access an interface argument provided by an external caller.  The caller must explicitly make a copy of the interface and increment its reference count if it holds on to this interface reference. "

this method however calls #newTemporaryInterfacePointerAtAddress: and there it says:

    " Answer a new instance of the receiver for an interface whose pointer value is in external memory referenced by <anExternalAddress>. In earlier versions of COM connect, this interface pointer was not referencecounted. From 7.9 on,
    it is at it may be kept by the server object."

1) I think the comments should be unambiguous about the fact of reference counting.

2) Another question is why *temporary* interface pointers are suddenly all made reference counted just in case some one holds onto them. The comment above explicitely said that if you hold on to the interface, you should copy your own and reference counted interface pointer.

Thomas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc